devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mike Looijmans <mike.looijmans@topic.nl>
Cc: devicetree@vger.kernel.org, linux-iio@vger.kernel.org,
	Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Liam Beguin <liambeguin@gmail.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Maksim Kiselev <bigunclemax@gmail.com>,
	Marcus Folkesson <marcus.folkesson@gmail.com>,
	Marius Cristea <marius.cristea@microchip.com>,
	Mark Brown <broonie@kernel.org>,
	Niklas Schnelle <schnelle@linux.ibm.com>,
	Okan Sahin <okan.sahin@analog.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] iio: adc: ti-ads1298: Add driver
Date: Tue, 6 Feb 2024 17:07:36 +0200	[thread overview]
Message-ID: <ZcJLOC7FenCecRMm@smile.fi.intel.com> (raw)
In-Reply-To: <67387cf4-1065-4313-b4c6-054128ba8f3a@topic.nl>

On Tue, Feb 06, 2024 at 03:25:30PM +0100, Mike Looijmans wrote:
> On 06-02-2024 14:50, Andy Shevchenko wrote:
> > On Tue, Feb 06, 2024 at 02:33:47PM +0100, Mike Looijmans wrote:
> > > On 06-02-2024 13:57, Andy Shevchenko wrote:
> > > > On Tue, Feb 06, 2024 at 07:58:18AM +0100, Mike Looijmans wrote:

...

> > You never know what may go wrong in the future :-) That said, I prefer robust
> > code against non-robust.
> 
> Maybe: BUG_ON(!priv->rdata_xfer_busy)

Definitely not. Linus T. will scream at us on this.

-- 
With Best Regards,
Andy Shevchenko



  parent reply	other threads:[~2024-02-06 15:07 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.949ef384-8293-46b8-903f-40a477c056ae.ad72f8ca-a017-42d2-9c07-f17f282264d0@emailsignatures365.codetwo.com>
2024-02-06  6:58 ` [PATCH v3 1/2] dt-bindings: iio: adc: ti-ads1298: Add bindings Mike Looijmans
     [not found]   ` <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.949ef384-8293-46b8-903f-40a477c056ae.fd628a1a-a926-426e-a239-bfd8c9858b94@emailsignatures365.codetwo.com>
2024-02-06  6:58     ` [PATCH v3 2/2] iio: adc: ti-ads1298: Add driver Mike Looijmans
2024-02-06 12:57       ` Andy Shevchenko
2024-02-06 13:33         ` Mike Looijmans
2024-02-06 13:50           ` Andy Shevchenko
2024-02-06 14:25             ` Mike Looijmans
2024-02-06 14:47               ` Mike Looijmans
2024-02-06 15:09                 ` Andy Shevchenko
2024-02-06 15:44                   ` Mike Looijmans
2024-02-06 16:32                     ` Andy Shevchenko
2024-02-06 17:38                       ` Mike Looijmans
2024-02-10 16:27                         ` Jonathan Cameron
2024-02-14  6:48                           ` Mike Looijmans
2024-02-14 14:08                             ` Jonathan Cameron
2024-02-06 15:07               ` Andy Shevchenko [this message]
2024-02-06 15:28   ` [PATCH v3 1/2] dt-bindings: iio: adc: ti-ads1298: Add bindings Conor Dooley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZcJLOC7FenCecRMm@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=bigunclemax@gmail.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=lgirdwood@gmail.com \
    --cc=liambeguin@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcus.folkesson@gmail.com \
    --cc=marius.cristea@microchip.com \
    --cc=mike.looijmans@topic.nl \
    --cc=okan.sahin@analog.com \
    --cc=schnelle@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).