devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Miguel Ojeda <ojeda@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Robin van der Gracht <robin@protonic.nl>,
	Paul Burton <paulburton@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: auxdisplay: hit,hd44780: drop redundant GPIO node
Date: Mon, 12 Feb 2024 16:09:18 +0200	[thread overview]
Message-ID: <Zcomjp9oH9VfO3NA@smile.fi.intel.com> (raw)
In-Reply-To: <906db6a6-48ba-41e5-be23-1dea0ecf96ee@linaro.org>

On Mon, Feb 12, 2024 at 02:56:43PM +0100, Krzysztof Kozlowski wrote:
> On 12/02/2024 14:39, Andy Shevchenko wrote:
> > On Mon, Feb 12, 2024 at 09:34:24AM +0100, Krzysztof Kozlowski wrote:

...

> >> -    i2c {
> >> -            #address-cells = <1>;
> >> -            #size-cells = <0>;
> >>  
> >> -            pcf8574: pcf8574@27 {
> >> -                    compatible = "nxp,pcf8574";
> >> -                    reg = <0x27>;
> >> -                    gpio-controller;
> >> -                    #gpio-cells = <2>;
> >> -            };
> >> -    };
> > 
> > In patch 3 you updated the lines that have lost their sense due to this one.
> 
> How did they lose it?

Now they are referring to the non-existed node in the example. OTOH, there is
already hc595 case...

The Q here (as you pointed out that it's better to name nodes in generic way),
how these names are okay with the schema (hc595, pcf8574) as being referred to?

...

> > And I agree with others, please leave this example in place.
> 
> What for? Why this binding is special and 99% of others do not need GPIO
> expander in the example?

Some people already tried to explain you their point of view, but I see that:
- the unrelated nodes in the schemas are not welcome (as per your talks
  and documentation);
- the current file has other references that have no existing node in the
  example;
- you are DT maintainer, so I believe you know this better.

With this, I'm almost (see above question though) satisfied with the series.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2024-02-12 14:09 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-12  8:34 [PATCH 1/3] dt-bindings: auxdisplay: hit,hd44780: drop redundant GPIO node Krzysztof Kozlowski
2024-02-12  8:34 ` [PATCH 2/3] dt-bindings: auxdisplay: adjust example indentation and use generic node names Krzysztof Kozlowski
2024-02-12 12:14   ` Andy Shevchenko
2024-02-12  8:34 ` [PATCH 3/3] dt-bindings: auxdisplay: hit,hd44780: use defines for GPIO flags Krzysztof Kozlowski
2024-02-12 12:15   ` Andy Shevchenko
2024-02-12  8:41 ` [PATCH 1/3] dt-bindings: auxdisplay: hit,hd44780: drop redundant GPIO node Geert Uytterhoeven
2024-02-12 11:25   ` Krzysztof Kozlowski
2024-02-12 11:58     ` [PATCH 1/3] dt-bindings: auxdisplay: hit, hd44780: " Ralf Schlatterbeck
2024-02-12 13:38       ` Krzysztof Kozlowski
2024-02-12 13:43         ` Andy Shevchenko
2024-02-12 13:59           ` Krzysztof Kozlowski
2024-02-12 14:04             ` Andy Shevchenko
2024-02-13 16:19             ` Rob Herring
2024-02-13 16:43               ` Andy Shevchenko
2024-02-14  9:57                 ` Krzysztof Kozlowski
2024-02-12 14:39         ` Ralf Schlatterbeck
2024-02-12 15:24           ` Geert Uytterhoeven
2024-02-13  9:07         ` Ralf Schlatterbeck
2024-02-12 13:39 ` [PATCH 1/3] dt-bindings: auxdisplay: hit,hd44780: " Andy Shevchenko
2024-02-12 13:56   ` Krzysztof Kozlowski
2024-02-12 14:09     ` Andy Shevchenko [this message]
2024-02-12 14:20       ` Krzysztof Kozlowski
2024-02-12 14:31         ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zcomjp9oH9VfO3NA@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ojeda@kernel.org \
    --cc=paulburton@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=robin@protonic.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).