From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f173.google.com (mail-il1-f173.google.com [209.85.166.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B4D274403 for ; Wed, 28 Feb 2024 19:22:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709148141; cv=none; b=XCz2Yke/c/1bN7yh193Gui8R4FgerEy3sDquo+bVDjb3vos6185NrurfRyCg3WCIy+IETLGVfFFGdxXGoz4wV46VIoJI49LVJdbUZynMa/dYC4AQX/FfLbBtWYrfRjev+9E4dP30sfde4RzqyDFnNpl4QYVl15dpMglYwxvlN9g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709148141; c=relaxed/simple; bh=Ys3XowIf0bm7jRKzuc3PtxqeRx99FE+WClNAKD56B0M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=K5KzamsKKq6gIMPXog49BlbbyW/iPo+VRIoZWW9r/dpaKRmQRCxAOK82YaI6lhCVIzgZfrwRtMJFQoH8f+4An3M0odyhdEf/OzR0MXaZxdgDN8bP9TkqdyAdr80r8K3eOHVT2DkcRz8PG6ElUVVco0yszbFOPcFiiAtEU/vpcZQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=GS7ODvLr; arc=none smtp.client-ip=209.85.166.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="GS7ODvLr" Received: by mail-il1-f173.google.com with SMTP id e9e14a558f8ab-36519980c04so538585ab.3 for ; Wed, 28 Feb 2024 11:22:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1709148139; x=1709752939; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cWZCONUO1eBq93ur5BQyYMDhfKl8EM5yFU5z78+cztc=; b=GS7ODvLrZ4WkXb2ylj9Rf3E1euju9QWLterM4AEx2bYAGFy2rrORH9vfuC9tFZO0By cLddsajAj9eDh5NVIrUGEeLVOZJjMerOWUP9cDdxZjRvW/5+BGnr1znbzLtdjsIJx6Xl WAJJBUyZKOCDN4elNbpazW6tcVnWpWhgfZHYw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709148139; x=1709752939; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cWZCONUO1eBq93ur5BQyYMDhfKl8EM5yFU5z78+cztc=; b=hf3o3yAMbrHxvEsCyHXHfaPuEmfokJvIFFwCUFTHthIlshvkG6au8R91ubOGKnFatD DagvWl5+671muOK5cSr0+v+W7vjfGhknVPQiqzWczrEnyLYpa+3w17jbUVDX5GF3ycXN l4c21iKMfaRNYF+5sFFAOLOT57hvm2Okc/nFwoIZIzteFNNVQDDq5MrnsmS2t5asgDC4 9Y1nZxSOjcGYBgxrnanJRM4LzBqlRzbTXdzUFyUBzfKocU5smiWYH2JrhSm67C7Ebcdk VYzIWQ3ZnnDMyyyRj3qMMcCwSLh+9tGDtxRjRLcEw4ZrvHAtdOKqpp6+bKlDs7zqmEXl QnPg== X-Forwarded-Encrypted: i=1; AJvYcCWiKaAZSv87RMJAsK/L2KrPijRVJBqmTIJdkv19EryiUgOdbs9emIeKulGAJUJYzXMf4E2wK5bOrOtCjvGLGyDA31RsFh56iPFznw== X-Gm-Message-State: AOJu0YySK0gT7sFO/Kr35jCKK7HCDtwYEcm2AsCzdyy8mftO7yNabhde 1mP8tNznfxK+wGvrWR65Cnrudq7FX7VliEJwUob2VT0Jo2U59EwrORTsBuQnow== X-Google-Smtp-Source: AGHT+IFqbcv66YZt2FKNF964iMhI6GTiYtKK3x/4hGk7YfuhA2JWmeUUh4jB5yMEezmNt7X9tFEO2w== X-Received: by 2002:a92:c5a9:0:b0:365:a9fd:1a7a with SMTP id r9-20020a92c5a9000000b00365a9fd1a7amr178874ilt.26.1709148139247; Wed, 28 Feb 2024 11:22:19 -0800 (PST) Received: from localhost (144.57.222.35.bc.googleusercontent.com. [35.222.57.144]) by smtp.gmail.com with UTF8SMTPSA id x3-20020a92d643000000b003638f9a9debsm10233ilp.75.2024.02.28.11.22.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Feb 2024 11:22:18 -0800 (PST) Date: Wed, 28 Feb 2024 19:22:18 +0000 From: Matthias Kaehlcke To: Javier Carrasco Cc: Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Helen Koike , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Catalin Marinas , Will Deacon , Russell King , linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 8/8] usb: misc: onboard_hub: add support for XMOS XVF3500 Message-ID: References: <20240228-onboard_xvf3500-v5-0-76b805fd3fe6@wolfvision.net> <20240228-onboard_xvf3500-v5-8-76b805fd3fe6@wolfvision.net> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240228-onboard_xvf3500-v5-8-76b805fd3fe6@wolfvision.net> On Wed, Feb 28, 2024 at 02:51:35PM +0100, Javier Carrasco wrote: > The XMOS XVF3500 VocalFusion Voice Processor[1] is a low-latency, 32-bit > multicore controller for voice processing. > > This device requires a specific power sequence, which consists of > enabling the regulators that control the 3V3 and 1V0 device supplies, > and a reset de-assertion after a delay of at least 100ns. Such power > sequence is already supported by the onboard_hub driver, and it can be > reused for non-hub USB devices as well. Please update the commit message, the onboard_hub driver no longer exists as such with the other patches of this series. > Once in normal operation, the XVF3500 registers itself as a USB device, > and it does not require any device-specific operations in the driver. > > [1] https://www.xmos.com/xvf3500/ > > Signed-off-by: Javier Carrasco Acked-by: Matthias Kaehlcke > --- > drivers/usb/misc/onboard_usb_dev.c | 2 ++ > drivers/usb/misc/onboard_usb_dev.h | 8 ++++++++ > 2 files changed, 10 insertions(+) > > diff --git a/drivers/usb/misc/onboard_usb_dev.c b/drivers/usb/misc/onboard_usb_dev.c > index df0ed172c7ec..50f84c5278a2 100644 > --- a/drivers/usb/misc/onboard_usb_dev.c > +++ b/drivers/usb/misc/onboard_usb_dev.c > @@ -405,6 +405,7 @@ static struct platform_driver onboard_dev_driver = { > #define VENDOR_ID_REALTEK 0x0bda > #define VENDOR_ID_TI 0x0451 > #define VENDOR_ID_VIA 0x2109 > +#define VENDOR_ID_XMOS 0x20B1 > > /* > * Returns the onboard_dev platform device that is associated with the USB > @@ -497,6 +498,7 @@ static const struct usb_device_id onboard_dev_id_table[] = { > { USB_DEVICE(VENDOR_ID_TI, 0x8142) }, /* TI USB8041 2.0 */ > { USB_DEVICE(VENDOR_ID_VIA, 0x0817) }, /* VIA VL817 3.1 */ > { USB_DEVICE(VENDOR_ID_VIA, 0x2817) }, /* VIA VL817 2.0 */ > + { USB_DEVICE(VENDOR_ID_XMOS, 0x0013) }, /* XVF3500 */ nit: be a bit more specific? e.g. XVF3500 Voice Processor, or XMOS XVF3500 The other entries were implicitly hubs since this was the 'onboard_hub' driver. It wouldn't be a bad idea to add 'hub' to these entries in the patch that 'renames' the driver.