From: Matthias Kaehlcke <mka@chromium.org>
To: Macpaul Lin <macpaul.lin@mediatek.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Bear Wang <bear.wang@mediatek.com>,
Pablo Sun <pablo.sun@mediatek.com>,
Macpaul Lin <macpaul@gmail.com>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
Yow-shin Liou <yow-shin.liou@mediatek.com>,
MediaTek Chromebook Upstream
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
Chen-Yu Tsai <wenst@chromium.org>
Subject: Re: [PATCH 2/2] usb: misc: onboard_usb_hub: Add support for TI TUSB8020B
Date: Tue, 27 Feb 2024 18:38:03 +0000 [thread overview]
Message-ID: <Zd4sCyPNNjzB5Gre@google.com> (raw)
In-Reply-To: <20240227090228.22156-2-macpaul.lin@mediatek.com>
On Tue, Feb 27, 2024 at 05:02:28PM +0800, Macpaul Lin wrote:
> The TI TUSB8020B is a 2-port USB 3.0 hub. Add support for
> this hub in the driver in order to bring up reset, and supply
> dependencies.
>
> Power-up: Issue a GPIO reset (GRSTz) 3ms after VDD and VDD33 stabilize.
>
> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
Generally this looks good to me, but it should probably wait for
"usb: misc: onboard_dev: use device supply names" [1] to land and
use a device specific supply name instead of 'vdd'.
[1] https://lore.kernel.org/linux-usb/20240220-onboard_xvf3500-v4-6-dc1617cc5dd4@wolfvision.net/
next prev parent reply other threads:[~2024-02-27 18:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 9:02 [PATCH 1/2] dt-bindings: usb: Add binding for TI USB8020B hub controller Macpaul Lin
2024-02-27 9:02 ` [PATCH 2/2] usb: misc: onboard_usb_hub: Add support for TI TUSB8020B Macpaul Lin
2024-02-27 13:05 ` AngeloGioacchino Del Regno
2024-02-27 18:38 ` Matthias Kaehlcke [this message]
2024-02-27 18:07 ` [PATCH 1/2] dt-bindings: usb: Add binding for TI USB8020B hub controller Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zd4sCyPNNjzB5Gre@google.com \
--to=mka@chromium.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bear.wang@mediatek.com \
--cc=chunfeng.yun@mediatek.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=macpaul.lin@mediatek.com \
--cc=macpaul@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=pablo.sun@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=wenst@chromium.org \
--cc=yow-shin.liou@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).