From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f179.google.com (mail-il1-f179.google.com [209.85.166.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 338412D60B for ; Tue, 27 Feb 2024 18:38:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709059087; cv=none; b=Kf+G4rFDRDrFjjbdXZC+lDjqD/klZORBPdsrGxx+Y8a7QBul0ESCzqUOk12jvqQ+JyCv0IoZe/YsVcXVf4GA/RVgPg3O88FXqbgyaF4Jz3mxcLnmd0JzOhzuhIkp9Dh98aUDv0/3HFk/zXHMcMRFO71eRUrJLBLT2Y/+qqOedGY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709059087; c=relaxed/simple; bh=kESpsdO4FlnESQiL59fX61xhGswvPE38dgcnrNXEDQU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qJ9TSt3W6CWOJQmy2wQ+Twg5svwSsdfnHbXzrGpEfVt64AEngKC31mDbyzy+mDSQTFZrZXOvSpDzjxbhab6oBlXlgSRgLQ3pmZ012ygCtH3TRsDDJZnOGCvy/RGG5YnRweUzAmD1/mhvhqFnhm0gaKHLFQlivIZ1IyUW1uaf+nw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=bJJp9EJt; arc=none smtp.client-ip=209.85.166.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="bJJp9EJt" Received: by mail-il1-f179.google.com with SMTP id e9e14a558f8ab-365169e0938so213285ab.0 for ; Tue, 27 Feb 2024 10:38:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1709059084; x=1709663884; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zaG4Gr4Kx+0i0zsq6oXYlyOK6u158LHOb5Hpg9y9dtA=; b=bJJp9EJt0C9GtT/FF6xYbLoDj0BaS1oxph3hsJXy87XlarRb1sV1RO3UV1NfAFSGm6 yx0snscqczTNlqXsGty1Rz4EjSAYneiG0geLEGPGY4Kh0wzswLQXZVtpXojUXmKiKqtd twXpwSNJzrpEFB5J9fTV7MRmL9XNW4THXHvfU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709059084; x=1709663884; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zaG4Gr4Kx+0i0zsq6oXYlyOK6u158LHOb5Hpg9y9dtA=; b=bDc4rud49fMUUWLwm9AAWdUqvpN9waW8TL5fZNfrhLUUR9UfuZPlVPBhDFfBo1rHod yo2LvsFsatomXDfTZ5N0zyylpypAuBYypgglwlUrbK0BiBDMMkilE0VsKECLa8RlD4Za 0QNuzMa6uqacxBgtQ32O8zCs4J4hrrGPt+utLRJX7oHB5AOwPpd2K4GOvkt369gBrI8+ IH2UTPpapWLnwg7q23V0Ze/drXViCofBwOKGVF9IkFtXNAOT0ARpD/XIBS9yRhA5/AWW 7HR0hBB4zcUroPNEM2OV9jn4D1PvSV6muIP6ulCoH2oWizpE4FA1YC1AG1tcpEDCNR6Q YHtQ== X-Forwarded-Encrypted: i=1; AJvYcCUz3VKodWFR+jN4UCIcHFSDfjz02/1NmoZq29zakCZH6IypfR7y98huVTtVSey3PfFoRDAqN/NKQlTxzN43yk2OzfhdRA1jRGNN8A== X-Gm-Message-State: AOJu0Yxx1jLDYvDJKbdafuG7Z2l2+pfrENvlW507GpvY5jPzwEoY73G4 VItKoyE8766AY7APFVcuLjTRfaLxmovqBkz4ZIDbAmQANteSwndIB0YJcys2Kw== X-Google-Smtp-Source: AGHT+IEeZR7+1yyy7wcg6Jz8cOZdq5xTguaXhSCIcOHuTDOZFBcHwqro5Caz+F2LmDujB9cHZH+DyQ== X-Received: by 2002:a92:cb0b:0:b0:365:616a:72da with SMTP id s11-20020a92cb0b000000b00365616a72damr143131ilo.7.1709059084386; Tue, 27 Feb 2024 10:38:04 -0800 (PST) Received: from localhost (147.220.222.35.bc.googleusercontent.com. [35.222.220.147]) by smtp.gmail.com with UTF8SMTPSA id f5-20020a056e0212a500b00363ea1209basm2294457ilr.11.2024.02.27.10.38.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Feb 2024 10:38:03 -0800 (PST) Date: Tue, 27 Feb 2024 18:38:03 +0000 From: Matthias Kaehlcke To: Macpaul Lin Cc: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Bear Wang , Pablo Sun , Macpaul Lin , Chunfeng Yun , Yow-shin Liou , MediaTek Chromebook Upstream , Chen-Yu Tsai Subject: Re: [PATCH 2/2] usb: misc: onboard_usb_hub: Add support for TI TUSB8020B Message-ID: References: <20240227090228.22156-1-macpaul.lin@mediatek.com> <20240227090228.22156-2-macpaul.lin@mediatek.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240227090228.22156-2-macpaul.lin@mediatek.com> On Tue, Feb 27, 2024 at 05:02:28PM +0800, Macpaul Lin wrote: > The TI TUSB8020B is a 2-port USB 3.0 hub. Add support for > this hub in the driver in order to bring up reset, and supply > dependencies. > > Power-up: Issue a GPIO reset (GRSTz) 3ms after VDD and VDD33 stabilize. > > Signed-off-by: Macpaul Lin Generally this looks good to me, but it should probably wait for "usb: misc: onboard_dev: use device supply names" [1] to land and use a device specific supply name instead of 'vdd'. [1] https://lore.kernel.org/linux-usb/20240220-onboard_xvf3500-v4-6-dc1617cc5dd4@wolfvision.net/