devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jisheng Zhang <jszhang@kernel.org>
To: Emil Renner Berthing <emil.renner.berthing@canonical.com>,
	Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org
Subject: commit f34fd6ee1be8 breaks current dwapb gpio DT users
Date: Sat, 17 Feb 2024 22:15:31 +0800	[thread overview]
Message-ID: <ZdC_g3U4l0CJIWzh@xhacker> (raw)

Hi Emil, Linus,

commit f34fd6ee1be8 ("gpio: dwapb: Use generic request, free and
set_config") breaks all current dwapb gpio DT users, for example, getting
cd-gpios will always fail as -EPROBE_DEFER. Before the commit,
dwapb_gpio_set_config() returns -ENOTSUPP for !PIN_CONFIG_INPUT_DEBOUNCE
then gpio_set_config_with_argument_optional() will happily ignore
-ENOTSUPP. After the commit, dwapb_gpio_set_config() will return
-EPROBE_DEFER unless the gpio-ranges are set in DT.

The key problem here is: almost all dwapb gpio DT users don't set
the gpio-ranges DT property, so I guess current dwapb gpio DT users
have this problem and the commit also breaks old DT compatbility.
So could we getback to previous behavior?

Thanks in advance

             reply	other threads:[~2024-02-17 14:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-17 14:15 Jisheng Zhang [this message]
2024-02-17 17:44 ` commit f34fd6ee1be8 breaks current dwapb gpio DT users Emil Renner Berthing
2024-02-18  2:20   ` Jisheng Zhang
2024-02-19 13:46   ` Linus Walleij
2024-02-19 15:27     ` Emil Renner Berthing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZdC_g3U4l0CJIWzh@xhacker \
    --to=jszhang@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=emil.renner.berthing@canonical.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).