From: Abdel Alkuor <alkuor@gmail.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: "Lee Jones" <lee@kernel.org>, "Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Lukas Bulwahn" <lukas.bulwahn@gmail.com>,
"Jean-Jacques Hiblot" <jjhiblot@traphandler.com>,
"ChiYuan Huang" <cy_huang@richtek.com>,
"André Apitzsch" <git@apitzsch.eu>,
"Jacek Anaszewski" <jacek.anaszewski@gmail.com>,
"ChiaEn Wu" <chiaen_wu@richtek.com>,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] leds: Add NCP5623 multi-led driver
Date: Sat, 17 Feb 2024 16:49:28 -0500 [thread overview]
Message-ID: <ZdEp6LuUBI1oMf0z@abdel> (raw)
In-Reply-To: <Zcsz7x1rXgYP3e7b@duo.ucw.cz>
On Tue, Feb 13, 2024 at 10:18:39AM +0100, Pavel Machek wrote:
Hi Pavel,
> > +What: /sys/class/leds/<led>/dim_step
>
> You are reinventing hardware_pattern trigger. NAK.
>
> I suggest you add basic support first, then look at hardware pattern
> trigger and add that support in separate patch.
>
This makes a lot of sense and simplifies the driver.
I'd like to add the hardware pattern as part of this patch as it is already
implemented previously but I needed to do some clean up :)
Thanks,
Abdel
next prev parent reply other threads:[~2024-02-17 21:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-03 17:58 [PATCH 1/2] dt: bindings: leds: Add NCP5623 multi-LED Controller Abdel Alkuor
2024-02-03 17:58 ` [PATCH 2/2] leds: Add NCP5623 multi-led driver Abdel Alkuor
2024-02-08 13:01 ` Lee Jones
2024-02-11 12:29 ` Abdel Alkuor
2024-02-23 16:20 ` Lee Jones
2024-02-13 9:18 ` Pavel Machek
2024-02-17 21:49 ` Abdel Alkuor [this message]
2024-02-05 8:39 ` [PATCH 1/2] dt: bindings: leds: Add NCP5623 multi-LED Controller Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZdEp6LuUBI1oMf0z@abdel \
--to=alkuor@gmail.com \
--cc=chiaen_wu@richtek.com \
--cc=conor+dt@kernel.org \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=git@apitzsch.eu \
--cc=jacek.anaszewski@gmail.com \
--cc=jjhiblot@traphandler.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).