From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A95A6A8CE; Tue, 20 Feb 2024 14:11:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708438293; cv=none; b=piJMRtCKSexmSfeUMZq/eSjbceGA3AIlRjL/n9MYOIho0I94+jia+IKV9C0/NBhMRfgqfxnFoWIjr4rcqr3DORQhvKifeXOr/8ylDpivpGJbR3moiId1gpAb0PCPP+4FrcEkhbTNe+nSZsIK/G7HcoQc4y7VQrvEny79/7VQDd4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708438293; c=relaxed/simple; bh=0GcoN0t+2Coj9NK+07WItqUPu3W/l0ZctvKLNd6QzVw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RU2Bo88XT6sDHIT/BdeZGzjnthQnsUEQlB6T6XxFD0uuUqt00YktFVlF3rAiQB8VbC9kg0MbIoQlDhLOCOl39JLFPaHN2DfBiUXex2Hj/mjB+87+3L1JyI+fiRG6hwgav5IyP69lh6DnMy+bWLVr7pVLjQEi9KQsW426F1zhqnQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org; spf=fail smtp.mailfrom=kernel.org; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=kernel.org X-IronPort-AV: E=McAfee;i="6600,9927,10989"; a="6359315" X-IronPort-AV: E=Sophos;i="6.06,172,1705392000"; d="scan'208";a="6359315" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Feb 2024 06:11:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10989"; a="913082505" X-IronPort-AV: E=Sophos;i="6.06,172,1705392000"; d="scan'208";a="913082505" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Feb 2024 06:11:25 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rcQq9-000000066Jp-384v; Tue, 20 Feb 2024 16:11:21 +0200 Date: Tue, 20 Feb 2024 16:11:21 +0200 From: Andy Shevchenko To: Dumitru Ceclan Cc: linus.walleij@linaro.org, brgl@bgdev.pl, linux-gpio@vger.kernel.org, Lars-Peter Clausen , Jonathan Cameron , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Walle , Arnd Bergmann , ChiaEn Wu , Niklas Schnelle , Leonard =?iso-8859-1?Q?G=F6hrs?= , Mike Looijmans , Haibo Chen , Hugo Villeneuve , David Lechner , Ceclan Dumitru , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v13 2/3] iio: adc: ad_sigma_delta: Add optional irq selection Message-ID: References: <20240220094344.17556-1-mitrutzceclan@gmail.com> <20240220094344.17556-2-mitrutzceclan@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240220094344.17556-2-mitrutzceclan@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Tue, Feb 20, 2024 at 11:43:39AM +0200, Dumitru Ceclan wrote: > Add optional irq_num attribute to ad_sigma_delta_info structure for > selecting the used interrupt line for adc's conversion completion. ... > + if (!info->irq_num) > + sigma_delta->irq_num = spi->irq; > + else > + sigma_delta->irq_num = info->irq_num; Why not positive check? -- With Best Regards, Andy Shevchenko