From: Herbert Xu <herbert@gondor.apana.org.au>
To: Akhil R <akhilrajeev@nvidia.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
Jon Hunter <jonathanh@nvidia.com>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"will@kernel.org" <will@kernel.org>,
Mikko Perttunen <mperttunen@nvidia.com>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"krzk@kernel.org" <krzk@kernel.org>
Subject: Re: [PATCH v5 3/5] crypto: tegra: Add Tegra Security Engine driver
Date: Thu, 29 Feb 2024 17:44:50 +0800 [thread overview]
Message-ID: <ZeBSEviAw/JVpICl@gondor.apana.org.au> (raw)
In-Reply-To: <SJ1PR12MB63392983F30CA57CBCB69B93C05F2@SJ1PR12MB6339.namprd12.prod.outlook.com>
On Thu, Feb 29, 2024 at 09:20:48AM +0000, Akhil R wrote:
>
> Do we have any other concerns with the driver currently, which I can address
> in the next revision?
The sha export/import code looks good now. Does it pass all the
self-tests, including extra fuzzing?
The same export/import issue still exists with cmac so please fix
that.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2024-02-29 9:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 17:25 [PATCH v5 0/5] Add Tegra Security Engine driver Akhil R
2024-02-19 17:25 ` [PATCH v5 1/5] dt-bindings: crypto: Add Tegra Security Engine Akhil R
2024-02-19 17:25 ` [PATCH v5 2/5] gpu: host1x: Add Tegra SE to SID table Akhil R
2024-02-19 17:25 ` [PATCH v5 3/5] crypto: tegra: Add Tegra Security Engine driver Akhil R
2024-02-29 9:20 ` Akhil R
2024-02-29 9:44 ` Herbert Xu [this message]
2024-03-02 2:44 ` Akhil R
2024-02-19 17:25 ` [PATCH v5 4/5] arm64: defconfig: Enable Tegra Security Engine Akhil R
2024-02-19 17:25 ` [PATCH v5 5/5] arm64: tegra: Add Tegra Security Engine DT nodes Akhil R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZeBSEviAw/JVpICl@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=akhilrajeev@nvidia.com \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=krzk@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).