From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67B9D1118E for ; Fri, 1 Mar 2024 17:52:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709315571; cv=none; b=ufKELNWIC4YJF1zei8K83tFJ1Ojl4v5s6SlaTcg1wz+HDgdXpUzbeRxL2tOHWhmnAOuLrHebdvn6kmgwdZprW0g3djaLxHlJYbtPP59KUuuYjwgjreO50WxTvpiELU+NmENfOAB2mwoOqjhMWoNPdRPlCZOnb3LZ5tj4XpB8Ws8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709315571; c=relaxed/simple; bh=3V5Q+O2FXLZ0kss8N5yxXqgak8c3+ovvwNMUBWbWNj4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hdMQP8Nr+DLEYxxR5gNbdkrPnMM9QABlZCRmmp/MiDBoiwbaCZVw09HeFaDaHxCGTe8Sy1nlXfq6FdkIlQ2BWM3gbz7gxZ4Bl1SjzTJAs2CrVCmx/UUaiHtV4dVXpuzTpUg1nU1ja6rPl4pjum8jFxX8IVXcRPKfEnufKxdg/jI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=aBrYJYOL; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="aBrYJYOL" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-a44888b123dso180944066b.0 for ; Fri, 01 Mar 2024 09:52:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709315568; x=1709920368; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=BgknfKXa1rmDkpK0kJohefljfX90MMnzKKOyQbPtzxM=; b=aBrYJYOLzcAV09Va+PoC83XfWGVD+znyejc92mpH9onszjUvCQ8AOinu8rPedFWtNh GCPfGvSMK5iJ7IV/hKe+SWLgHB187AOb2mfuATL+e9WmvSD6kj70kjfk5pE2lnqov4Ge ivSa4zarPyOnlBX4/J9UXyXk9Gf8o9wXv1Os8MEwI+6r3TWR7RxFjfWjcJtmEJw9pYWm mBnYuq23XVZnnDjjtBuAhSLFLH6ZlMl//QHMX03KatzeJ1IB6PS3XEbetyQTpo1A/rVM SfspA7U9P05tS5ep3h+aGKIPTR0q+HyGUKjJoTUw4VMo4nfO4AfJe9JlfKt6b1ugEKLT u7hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709315568; x=1709920368; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BgknfKXa1rmDkpK0kJohefljfX90MMnzKKOyQbPtzxM=; b=D2WCUQaMXkjQwYasNZXuL6BcZNeVyX4dkP/Eg9HjLz0CkOcJRQ1lYSflZDpQZt2q1o EG5mugtaSVE/cnISLliJCtSa77IKpREmo7KugF0jSmclhVjJ5YcgojtblJgF1Www1Gcq vPzEGd+gwM6ohLKWG5z3NfltJfAInsf7i+yZNkrermhqB98+CO44UEyqUIPSNSTf0cmN D8KSFUzaQbquzyFVmYyOHYWl2oD2mOZlYrmofoLkYT/xUmSG9EsVyFsXNkf7w9fDLWPf LLOZ/2OV1SSQcLoiVkwrMcgKLClu++IBprRkzUDrmCO0bGl1WRZfBVe6LZ9gEjPkrtMc dHuw== X-Forwarded-Encrypted: i=1; AJvYcCW4t24wTMB7go8F2jxsQTjKW9/HxNNSslTE3XDiq93Q6H9r4UDWey4iiSJ7PTq9BSZUWSclztRtJqRcIzmxF5m3PgZxUd3CO6eT8Q== X-Gm-Message-State: AOJu0Yy8oIS7ywvyEMhwn719DSFiPsiu2tCvRerXkIHMFV4ypA7+q3GF MYHpiyag5F2XEWxSbGm9zy2ydPtE81/tW/tANxtrMDXIZSQVHODf6njHTLmyQb0= X-Google-Smtp-Source: AGHT+IFWlVuicjYknAdk37iSyCWyl6bDc1xmcdzkVqJy/EqPKHmtbxzit8FJhzeWVCTnKwKbxFK0/A== X-Received: by 2002:a17:906:b811:b0:a3e:53d9:c7d5 with SMTP id dv17-20020a170906b81100b00a3e53d9c7d5mr1794154ejb.36.1709315567593; Fri, 01 Mar 2024 09:52:47 -0800 (PST) Received: from linaro.org ([188.24.162.93]) by smtp.gmail.com with ESMTPSA id vq2-20020a170907a4c200b00a43a12c6311sm1895924ejc.166.2024.03.01.09.52.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:52:47 -0800 (PST) Date: Fri, 1 Mar 2024 19:52:45 +0200 From: Abel Vesa To: Krzysztof Kozlowski Cc: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kuogee Hsieh , Bjorn Andersson , Konrad Dybcio , Johan Hovold , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/3] dt-bindings: display: msm: dp-controller: document X1E80100 compatible Message-ID: References: <20240222-x1e80100-display-refactor-connector-v2-0-bd4197dfceab@linaro.org> <20240222-x1e80100-display-refactor-connector-v2-1-bd4197dfceab@linaro.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 24-02-27 16:45:25, Krzysztof Kozlowski wrote: > On 22/02/2024 16:55, Abel Vesa wrote: > > Add the X1E80100 to the list of compatibles and document the is-edp > > flag. The controllers are expected to operate in DP mode by default, > > and this flag can be used to select eDP mode. > > > > Signed-off-by: Abel Vesa > > --- > > Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > index ae53cbfb2193..ed11852e403d 100644 > > --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > @@ -27,6 +27,7 @@ properties: > > - qcom,sdm845-dp > > - qcom,sm8350-dp > > - qcom,sm8650-dp > > + - qcom,x1e80100-dp > > - items: > > - enum: > > - qcom,sm8150-dp > > @@ -73,6 +74,11 @@ properties: > > - description: phy 0 parent > > - description: phy 1 parent > > > > + is-edp: > > + $ref: /schemas/types.yaml#/definitions/flag > > + description: > > + Tells the controller to switch to eDP mode > > > DP controller cannot be edp, so property "is-edp" is confusing. Probably > you want to choose some phy mode, so you should rather use "phy-mode" > property. I am sure we've been here... phy-mode in controller node or in the phy node? > > Anyway, if you define completely new property without vendor prefix, > that's a generic property, so you need to put it in some common schema > for all Display Controllers, not only Qualcomm. I can re-spin with qcom,is-edp if that's better. > > > Best regards, > Krzysztof >