From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5333B5A0F8 for ; Wed, 13 Mar 2024 16:49:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710348592; cv=none; b=qm4p5GncXa6NHWZ32P6utOrS30nOhSrKCiVpLGpgjvd4y6Ql0NdXbRixAWDUSZ+GOqSIP/DLBPlV6bsWG8QxG4KLBTy3WaBs2tnsG0mRJqHo5aVfPFYhnSz0+GY1Fve7KQmcpak0ICxNUvo+pFgBVzokk/n4ZEh77qxTinoQPQA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710348592; c=relaxed/simple; bh=hPL3zw5JCqO9Uf0fSyTYE74YPTyUk0Giy5TIIbo6qF4=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CpDacv9EENX4XE7RYDZPdNQnoWLnlgFobtKXxyhu/W3lk3b2gL31bS4FbCRZ04z2JZwzrACBRvI2lAOKHLBX+a59imYFT6R9hGG96Z04wBfODyrj4EAB+J2LB0qZF46uYBB1ezzzkP0ymrMuWMBtqHSQKdxTVBR8VVkDEEKfA8Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=XyIvhhVH; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="XyIvhhVH" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-a46682e71a9so4178066b.3 for ; Wed, 13 Mar 2024 09:49:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1710348589; x=1710953389; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=QPkIANYlnqpJGOaQz5GtJSLehMlH+HibJAm6EUdPbkE=; b=XyIvhhVHlKZYnacQWGKlDtD3CMP6ZTq6capZFpjAY18Bcr8SCaEdTKWnL8aPI/NMn4 yBLrKZOtaMRoRRMT31YTrY1kIDgpppyKPF0HDCGeGgFgNANk/1UGjvBkmUBfYxIh7o2B 4V8wmTWqq1ibX8iDzyxyu3q1eqD5OyZ7scSSvkS3dk3UG2rOXp+N+Trmc4yNMf/FLmzc pE3feMENX4iueUAOP8WUmVUMX8sjvM7FoSL1h/a82D51MiAX6f0nAVcZP7GT+ktkc08F w3rWI3rRqwUfnN7DYNnicnXJyGj9p+G2mMlb0bG5PPfwKdj2tzNanajJcFXWOgmpyyz1 BywA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710348589; x=1710953389; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QPkIANYlnqpJGOaQz5GtJSLehMlH+HibJAm6EUdPbkE=; b=DyH52iklfKhnf2EcbaAWWBqu9tUBmnOY3yEY4e3wI1rRxGh5UAs8q0jnsBKcZw9R1f YFj6SFsDz+RZDyCxXXr8bFkfFeGTJoOd+PJKFqeqoij2nnn3Vf+FWZEuIuR5KdriSNlL YY9w3+W5BzTt2sviXPXWcl3PgfQBBVkAzG+bnKQv59SnZy9bHR0rcf0UR0Mmcn3Sx6Pl 9pyj4SZK8zgNiIwZlznhNRRe66TvbGcV4zN9iALPQezIws1+w7at4Cn2knNxfG0L85eQ lqbgJSeaKacq9iJZ/pKmAV2hNKqZKiWXv7HDv+xG8T/4JtGCnAhO4PZFY16VZ++DRntD L3ig== X-Forwarded-Encrypted: i=1; AJvYcCXflKHWAk2hyvp3qXA6KlmW7ky/u0cT2BVfdRkHiEekTfc8YprkAuIbjxVLi7QyevJKciorHmXqmU2avBJkJxERdYA/kRaVFvbM0A== X-Gm-Message-State: AOJu0Yzy0aW+8Teeb5bCs6eNxFpx+nQUw3mya4FjHm/uoXVv3F1uOcHF 483NDAI3Pbd7zRv7k6N7jEgTbura+sv1TEGw4an0WDn4yqUaNHOh/YyHZ1T/xbE= X-Google-Smtp-Source: AGHT+IGqIboO89JDdz68otiTxC7R5thbY+dJhwJvuyQri1Y0mW+DslANVakowZJW0e4mX3PczuljcA== X-Received: by 2002:a17:907:a644:b0:a46:134c:ae8c with SMTP id vu4-20020a170907a64400b00a46134cae8cmr9631602ejc.50.1710348588653; Wed, 13 Mar 2024 09:49:48 -0700 (PDT) Received: from localhost (host-82-56-173-172.retail.telecomitalia.it. [82.56.173.172]) by smtp.gmail.com with ESMTPSA id bn23-20020a170906c0d700b00a462e4d7216sm2787595ejb.76.2024.03.13.09.49.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Mar 2024 09:49:48 -0700 (PDT) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Wed, 13 Mar 2024 17:49:47 +0100 To: Florian Fainelli Cc: Andrea della Porta , Vinod Koul , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Ray Jui , Scott Branden , Broadcom internal kernel review list , Saenz Julienne , dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dave.stevenson@raspberrypi.com, Phil Elwell , Maxime Ripard , Stefan Wahren , Dom Cobley Subject: Re: [PATCH v2 01/15] dmaengine: bcm2835: Fix several spellos Message-ID: Mail-Followup-To: Florian Fainelli , Andrea della Porta , Vinod Koul , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Ray Jui , Scott Branden , Broadcom internal kernel review list , Saenz Julienne , dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dave.stevenson@raspberrypi.com, Phil Elwell , Maxime Ripard , Stefan Wahren , Dom Cobley References: <831fee14-387a-41d9-8dfc-e3ba09a140b1@broadcom.com> <886b0def-7884-4780-8b7f-e29bf3d9ce7d@broadcom.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <886b0def-7884-4780-8b7f-e29bf3d9ce7d@broadcom.com> On 09:38 Wed 13 Mar , Florian Fainelli wrote: > On 3/13/24 08:26, Andrea della Porta wrote: > > On 08:00 Wed 13 Mar , Florian Fainelli wrote: > > > > > > > > > On 3/13/2024 7:08 AM, Andrea della Porta wrote: > > > > Fixed Codespell reported warnings about spelling and coding convention > > > > violations, among which there are also a couple potential operator > > > > precedence issue in macroes. > > and s/macroes/macros/ right, sorry about that... > > > > > > > > > Signed-off-by: Andrea della Porta > > > > > > There are no spelling errors being fixed in this commit, this is purely > > > stylistic and conforming to the Linux coding style guidelines. > > > > - /* detect a size missmatch */ > > - if (buf_len && (d->size != buf_len)) > > + /* detect a size mismatch */ > > + if (buf_len && d->size != buf_len) > > > > Isn't 'missmatch' a spelling error? Maybe I can drop the word 'several', since it's > > indeed only one... > > Can we agree this was easy to miss when 99% of the changes are stylistic? > The summary is that the commit subject and the message are not describing > what this patch is about. > -- > Florian > I agree with you that I could've added '...and coding style fixes' to the subject (while also dropping 'several'). The comment seems fine enough though. Maybe you're suggesting to separate the patches into two, one dealing with spelling errors and the other with coding conventions? Many thanks, Andrea