From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CC512BB18 for ; Fri, 29 Mar 2024 16:32:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711729966; cv=none; b=uiZYutST/aXMi4rmv+bkxcirxMCt4kmb/RQdCOl43sXwo/6y2XXmnwM4LfyHv7M6RHvYlCUsjJi+us7sOO4yUHXbX8YEwNYu9NtrRoPaLOq/hJO5sLfSjiCaHCNYFPKFyOUxVNyGQpEQQaICEkVdBbay2n4KGJFKrSfpSA+fz3U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711729966; c=relaxed/simple; bh=E3HGZbY6E3H/SomNIQGH3/DUr3KviIz8/9DkXlQJ8E4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jL2V2jHXU/2227B2p1nxSV3BX64A6b5DW+ZM1kmvVO4gycMdsqzljCPH/o/iKs0udVFvkxP0oq3aebTydXgV6QOM7bd04yA67X6MthDRE8mDrl/04n2F09Dz5XH/9dJmPIN3tejM1sikRlq5Epjp33xF2AG88eJLhY6zeVZKy1Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=hBbaHKKl; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hBbaHKKl" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-a4644bde1d4so272671966b.3 for ; Fri, 29 Mar 2024 09:32:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711729962; x=1712334762; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=N2QgqTKjYeMV4wupX3c1M3yXu+BukxhArfbC4mqtySY=; b=hBbaHKKl9h+4ibmGMTVbY3VO5ZIE4I4Mc66qMgKryVSILDsEdikWqmZfeACfICBnV/ 3KGtanmaPnNmJoAJAHUe0XB3tNKkLEIxZl90HMxhudNVNp2i6w3QT9zqTSR+TYaRu1FN XlP5gV9BwX7qOauZ7Drq/zQs+NUuXtldtl27ALwr/sO1ywm1X6rFOEZtr3kpkJ6Us3WN jnaX0zevuk38JLQpIcnOi3Uw9sGTGDc7uTjyjp9OIaRbZ8IHLhbl3UET4PZUgrOgCDo5 JTItjFGfQILhXq/B9/fhKFTIXaNQEORER/iYubpcHFoeubM8+zseioKwd98DL80jIZZK sn3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711729962; x=1712334762; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=N2QgqTKjYeMV4wupX3c1M3yXu+BukxhArfbC4mqtySY=; b=RO7DUiQ+b/a2VzXLw5HDVdk9yZmv3fcNWsLtHRDEejAWD5kBy5/yupKmZBBo2rSxKL 53/KgBH8o76l9oUiX57DkapOI6Andh0QzVmzQx5brMA9n9HrjIbhO6WOokIXw1OvD8zS gLziDo/ZuGvIt7UGa4esBLTXAp2mLme7ZbR3fC/warDzJVUgRGZc0AzqCnB5lkZkaoMG sbmTPE+xywZmermPtpK3cWOOeSoPhAI8b4sr7RYMMmLJ2Vw2i1ygZHDMw040j2rF9iAa gWOv1MrejLy7mb2q/Db0ikbORx/y42vFt/eVuDeDA2Zin6FX9MTTf/ZZwMdqTyjIRG5A EpIg== X-Forwarded-Encrypted: i=1; AJvYcCUEh7RQKLVwTRCgnElMLALqBgurqBew0JM7ua6lJXPOEHjeSK/uV4zMA6zYwj1hwnTpwvFCr2IsWqTkN108m4mWVSGz4cswddl6Qg== X-Gm-Message-State: AOJu0Yzev4JC6xM1Z4qzaSAEq20nkchU04MCnj5LwlR/xBwlr0SvospA IB3DQ3wI4s32FKslibvxslQ/PArxf5Njk7k1/GLktEnhWihJrmOcgeJ1AZzHTfE= X-Google-Smtp-Source: AGHT+IGu63POJ6YHNg71abi2Y6v6vkpEJuMdYhaSnyay7s2ilQzvpFifN7/DQE4ir9OfMsCUJbqRRw== X-Received: by 2002:a17:906:39c6:b0:a4e:26a4:bc36 with SMTP id i6-20020a17090639c600b00a4e26a4bc36mr1698829eje.7.1711729962342; Fri, 29 Mar 2024 09:32:42 -0700 (PDT) Received: from linaro.org ([79.114.172.194]) by smtp.gmail.com with ESMTPSA id dl5-20020a170907944500b00a4e28b2639asm1607642ejc.209.2024.03.29.09.32.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Mar 2024 09:32:41 -0700 (PDT) Date: Fri, 29 Mar 2024 18:32:40 +0200 From: Abel Vesa To: Neil Armstrong Cc: Stephen Boyd , Matthias Brugger , Bjorn Andersson , Konrad Dybcio , Dmitry Baryshkov , AngeloGioacchino Del Regno , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Srini Kandagatla , Johan Hovold , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH RESEND v6 3/5] spmi: pmic-arb: Make the APID init a version operation Message-ID: References: <20240326-spmi-multi-master-support-v6-0-1c87d8306c5b@linaro.org> <20240326-spmi-multi-master-support-v6-3-1c87d8306c5b@linaro.org> <9af9cfd1-38c7-4f38-a652-fd046f427f98@linaro.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9af9cfd1-38c7-4f38-a652-fd046f427f98@linaro.org> On 24-03-28 09:51:49, Neil Armstrong wrote: > On 26/03/2024 17:28, Abel Vesa wrote: > > Rather than using conditionals in probe function, add the APID init > > as a version specific operation. Due to v7, which supports multiple > > buses, pass on the bus index to be used for sorting out the apid base > > and count. > > > > Signed-off-by: Abel Vesa > > --- > > drivers/spmi/spmi-pmic-arb.c | 199 +++++++++++++++++++++++++++---------------- > > 1 file changed, 124 insertions(+), 75 deletions(-) > > > > diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c > > index 9ed1180fe31f..38fed8a585fe 100644 > > --- a/drivers/spmi/spmi-pmic-arb.c > > +++ b/drivers/spmi/spmi-pmic-arb.c > > @@ -183,6 +183,7 @@ struct spmi_pmic_arb { > > * struct pmic_arb_ver_ops - version dependent functionality. > > * > > * @ver_str: version string. > > + * @init_apid: finds the apid base and count > > * @ppid_to_apid: finds the apid for a given ppid. > > * @non_data_cmd: on v1 issues an spmi non-data command. > > * on v2 no HW support, returns -EOPNOTSUPP. > > @@ -202,6 +203,7 @@ struct spmi_pmic_arb { > > */ > > struct pmic_arb_ver_ops { > > const char *ver_str; > > + int (*init_apid)(struct spmi_pmic_arb *pmic_arb, int index); > > int (*ppid_to_apid)(struct spmi_pmic_arb *pmic_arb, u16 ppid); > > /* spmi commands (read_cmd, write_cmd, cmd) functionality */ > > int (*offset)(struct spmi_pmic_arb *pmic_arb, u8 sid, u16 addr, > > @@ -942,6 +944,38 @@ static int qpnpint_irq_domain_alloc(struct irq_domain *domain, > > return 0; > > } > > +static int pmic_arb_init_apid_min_max(struct spmi_pmic_arb *pmic_arb) > > +{ > > + /* > > + * Initialize max_apid/min_apid to the opposite bounds, during > > + * the irq domain translation, we are sure to update these > > + */ > > + pmic_arb->max_apid = 0; > > + pmic_arb->min_apid = pmic_arb->max_periphs - 1; > > + > > + return 0; > > +} > > + > > +static int pmic_arb_init_apid_v1(struct spmi_pmic_arb *pmic_arb, int index) > > +{ > > + u32 *mapping_table; > > + > > + if (index) { > > + dev_err(&pmic_arb->spmic->dev, "Unsupported buses count %d detected\n", > > + index); > > + return -EINVAL; > > + } > > + > > + mapping_table = devm_kcalloc(&pmic_arb->spmic->dev, pmic_arb->max_periphs, > > + sizeof(*mapping_table), GFP_KERNEL); > > + if (!mapping_table) > > + return -ENOMEM; > > + > > + pmic_arb->mapping_table = mapping_table; > > Can you specify in the spmi_pmic_arb->mapping_table struct documentation the mapping_table > is only used in v1 ? or even better rename it to mapping_table_v1 > Actually the mapping_table is used on version 1 through 3.