From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: rmfrfs@gmail.com, robh@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
Fabio Estevam <festevam@denx.de>
Subject: Re: [PATCH] media: dt-bindings: ovti,ov2680: Document clock/data-lanes
Date: Tue, 2 Apr 2024 08:30:31 +0000 [thread overview]
Message-ID: <ZgvCJ5F6KlhVGRPC@kekkonen.localdomain> (raw)
In-Reply-To: <CAOMZO5BGYhnhOrBRS9zBeYYJFHXnQkqZCAV2wGtdpmiA3HZTqA@mail.gmail.com>
Hi Fabio,
On Mon, Apr 01, 2024 at 12:03:15PM -0300, Fabio Estevam wrote:
> Hi Sakari,
>
> On Wed, Mar 27, 2024 at 7:30 PM Sakari Ailus
> <sakari.ailus@linux.intel.com> wrote:
>
> > > In this case, the correct fix would be to remove 'clock-lanes' and
> > > 'data-lanes' from imx7s-warp.dts.
> >
> > Agreed.
>
> I tried removing 'clock-lanes' and 'data-lanes', but it did not work:
>
> ov2680 1-0036: error -EINVAL: only a 1-lane CSI2 config is supported
> ov2680 1-0036: probe with driver ov2680 failed with error -22
If it's a problem with the driver, you should fix the driver instead of
working around it in DT. Just remove the check.
>
> I will send a v2 that documents 'clock-lanes', 'data-lanes', and
> 'link-frequencies'.
--
Regards,
Sakari Ailus
next prev parent reply other threads:[~2024-04-02 8:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 23:10 [PATCH] media: dt-bindings: ovti,ov2680: Document clock/data-lanes Fabio Estevam
2024-03-27 8:07 ` Krzysztof Kozlowski
2024-03-27 9:57 ` Sakari Ailus
2024-03-27 14:50 ` Fabio Estevam
2024-03-27 22:30 ` Sakari Ailus
2024-04-01 15:03 ` Fabio Estevam
2024-04-02 8:30 ` Sakari Ailus [this message]
2024-04-03 14:32 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgvCJ5F6KlhVGRPC@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@denx.de \
--cc=festevam@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-media@vger.kernel.org \
--cc=rmfrfs@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox