From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B4B31327ED for ; Tue, 2 Apr 2024 15:48:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712072921; cv=none; b=Oue4OHz1gELnMREUiX7b0FH/2JT23KxkFn/0WtjDyqqzqmPIoxKvw06mmrrxLCy4uMLoGEAFEUxuWjDBOnUcpuuGAGIy3Y5goaL8t1/JsFtd+vKUa4/x3Yp3WK09ZPUjpCOQluP33Q405w+lg3W+L+6S6IZLi2Y8gzjEU5Wlkbw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712072921; c=relaxed/simple; bh=piAKnhg8FS4n7pS0Dn6A+pN5uvt8YR0IVYBuMyFEm8A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=D10yoaGnVBS1/m6BYEr03zGvHQ5hmqRdtEAY5IZhC/erd/BhGOu1DIa+WYiZiMcUMxXREUozmbNuKYDkDwvgcpHiFrJAUwuNUCoas3lFSORSbq70Qa8WenS/cyadALMKyWf81jTYH+ZOYNl46O6DcpKJjtJOXHj+xsQz3GtBUX4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rrgMi-0005Ya-Eu; Tue, 02 Apr 2024 17:48:00 +0200 Received: from [2a0a:edc0:2:b01:1d::c5] (helo=pty.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rrgMg-00A0j3-Hg; Tue, 02 Apr 2024 17:47:58 +0200 Received: from ore by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rrgMg-00Asbo-1Q; Tue, 02 Apr 2024 17:47:58 +0200 Date: Tue, 2 Apr 2024 17:47:58 +0200 From: Oleksij Rempel To: Rob Herring Cc: Kory Maincent , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan Corbet , Luis Chamberlain , Russ Weight , Greg Kroah-Hartman , "Rafael J. Wysocki" , Krzysztof Kozlowski , Conor Dooley , Mark Brown , Frank Rowand , Andrew Lunn , Heiner Kallweit , Russell King , Thomas Petazzoni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, devicetree@vger.kernel.org, Dent Project Subject: Re: [PATCH net-next v6 11/17] dt-bindings: net: pse-pd: Add another way of describing several PSE PIs Message-ID: References: <20240326-feature_poe-v6-0-c1011b6ea1cb@bootlin.com> <20240326-feature_poe-v6-11-c1011b6ea1cb@bootlin.com> <20240402132637.GA3744978-robh@kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240402132637.GA3744978-robh@kernel.org> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org On Tue, Apr 02, 2024 at 08:26:37AM -0500, Rob Herring wrote: > > + pairsets: > > + $ref: /schemas/types.yaml#/definitions/phandle-array > > + description: > > + List of phandles, each pointing to the power supply for the > > + corresponding pairset named in 'pairset-names'. This property > > + aligns with IEEE 802.3-2022, Section 33.2.3 and 145.2.4. > > + PSE Pinout Alternatives (as per IEEE 802.3-2022 Table 145\u20133) > > + |-----------|---------------|---------------|---------------|---------------| > > + | Conductor | Alternative A | Alternative A | Alternative B | Alternative B | > > + | | (MDI-X) | (MDI) | (X) | (S) | > > + |-----------|---------------|---------------|---------------|---------------| > > + | 1 | Negative VPSE | Positive VPSE | \u2014 | \u2014 | > > + | 2 | Negative VPSE | Positive VPSE | \u2014 | \u2014 | > > + | 3 | Positive VPSE | Negative VPSE | \u2014 | \u2014 | > > + | 4 | \u2014 | \u2014 | Negative VPSE | Positive VPSE | > > + | 5 | \u2014 | \u2014 | Negative VPSE | Positive VPSE | > > + | 6 | Positive VPSE | Negative VPSE | \u2014 | \u2014 | > > + | 7 | \u2014 | \u2014 | Positive VPSE | Negative VPSE | > > + | 8 | \u2014 | \u2014 | Positive VPSE | Negative VPSE | > > + minItems: 1 > > + maxItems: 2 > > "pairsets" does not follow the normal design pattern of foos, foo-names, > and #foo-cells. You could add #foo-cells I suppose, but what would cells > convey? I don't think it's a good fit for what you need. > > The other oddity is the number of entries and the names are fixed. That > is usually defined per consumer. > > As each entry is just a power rail, why can't the regulator binding be > used here? I'm not against describing it consequent with regulator till the wire end, but right now I have no idea how it should be described by using regulator bindings. There are maximum 2 rails going in to PSE PI on one side and 4 rails with at least 5 combinations supported by standard on other side. Instead of inventing anything new, I suggested to describe supported output combinations by using IEEE 802.3 standard. Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |