* [PATCH v4 0/2] Add JH7110 MIPI DPHY TX support
@ 2024-03-01 1:24 Shengyang Chen
2024-03-01 1:24 ` [PATCH v4 1/2] dt-bindings: phy: Add starfive,jh7110-dphy-tx Shengyang Chen
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Shengyang Chen @ 2024-03-01 1:24 UTC (permalink / raw)
To: devicetree, linux-phy
Cc: vkoul, kishon, robh+dt, krzysztof.kozlowski+dt, conor+dt, p.zabel,
minda.chen, changhuang.liang, rogerq, geert+renesas, keith.zhao,
shengyang.chen, linux-kernel
This patchset adds mipi dphy tx support for the StarFive JH7110 SoC.
It is used to transfer DSI data. The series has been tested on
the VisionFive 2 board.
change since v3:
- Rebased on tag v6.8-rc6.
patch 2:
- Lower case for hex value.
- Replace bit shifts operation with macro definitions.
- Drop delay in stf_dphy_hw_reset().
- Change variable declarations order in stf_dphy_configure().
v3: https://patchwork.kernel.org/project/linux-phy/cover/20240206061921.107372-1-shengyang.chen@starfivetech.com/
change since v2:
- Rebased on tag v6.8-rc3.
patch 2:
- Drop regulator operation.
v2: https://patchwork.kernel.org/project/linux-phy/cover/20240109071246.24065-1-shengyang.chen@starfivetech.com/
changes since v1:
- Rebased on tag v6.7.
patch 1:
- Drop 'dphy_'prefix.
- Drop DSI reset.
- Drop unnecessary resets.
patch 2:
- Changed the commit message.
- Use dev_err_probe() and PTR_ERR() in probing.
- Drop DSI reset operation.
- Drop unnecessary resets operation.
- Add configs in array for full support of the module
- Changed 'void *io_addr' to 'void __iomem *io_addr'.
v1: https://patchwork.kernel.org/project/linux-phy/cover/20231117130421.79261-1-shengyang.chen@starfivetech.com/
Shengyang Chen (2):
dt-bindings: phy: Add starfive,jh7110-dphy-tx
phy: starfive: Add mipi dphy tx support
.../bindings/phy/starfive,jh7110-dphy-tx.yaml | 68 ++
MAINTAINERS | 7 +
drivers/phy/starfive/Kconfig | 10 +
drivers/phy/starfive/Makefile | 1 +
drivers/phy/starfive/phy-jh7110-dphy-tx.c | 702 ++++++++++++++++++
5 files changed, 788 insertions(+)
create mode 100644 Documentation/devicetree/bindings/phy/starfive,jh7110-dphy-tx.yaml
create mode 100644 drivers/phy/starfive/phy-jh7110-dphy-tx.c
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v4 1/2] dt-bindings: phy: Add starfive,jh7110-dphy-tx 2024-03-01 1:24 [PATCH v4 0/2] Add JH7110 MIPI DPHY TX support Shengyang Chen @ 2024-03-01 1:24 ` Shengyang Chen 2024-03-01 1:24 ` [PATCH v4 2/2] phy: starfive: Add mipi dphy tx support Shengyang Chen 2024-03-18 3:33 ` [PATCH v4 0/2] Add JH7110 MIPI DPHY TX support Shengyang Chen 2 siblings, 0 replies; 6+ messages in thread From: Shengyang Chen @ 2024-03-01 1:24 UTC (permalink / raw) To: devicetree, linux-phy Cc: vkoul, kishon, robh+dt, krzysztof.kozlowski+dt, conor+dt, p.zabel, minda.chen, changhuang.liang, rogerq, geert+renesas, keith.zhao, shengyang.chen, linux-kernel StarFive SoCs like the jh7110 use a MIPI D-PHY TX controller based on a M31 IP. Add a binding for it. Signed-off-by: Shengyang Chen <shengyang.chen@starfivetech.com> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- .../bindings/phy/starfive,jh7110-dphy-tx.yaml | 68 +++++++++++++++++++ 1 file changed, 68 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/starfive,jh7110-dphy-tx.yaml diff --git a/Documentation/devicetree/bindings/phy/starfive,jh7110-dphy-tx.yaml b/Documentation/devicetree/bindings/phy/starfive,jh7110-dphy-tx.yaml new file mode 100644 index 000000000000..4a06a2642b4a --- /dev/null +++ b/Documentation/devicetree/bindings/phy/starfive,jh7110-dphy-tx.yaml @@ -0,0 +1,68 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/phy/starfive,jh7110-dphy-tx.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Starfive SoC MIPI D-PHY Tx Controller + +maintainers: + - Keith Zhao <keith.zhao@starfivetech.com> + - Shengyang Chen <shengyang.chen@starfivetech.com> + +description: + The Starfive SoC uses the MIPI DSI D-PHY based on M31 IP to transfer + DSI data. + +properties: + compatible: + const: starfive,jh7110-dphy-tx + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + clock-names: + items: + - const: txesc + + resets: + items: + - description: MIPITX_DPHY_SYS reset + + reset-names: + items: + - const: sys + + power-domains: + maxItems: 1 + + "#phy-cells": + const: 0 + +required: + - compatible + - reg + - clocks + - clock-names + - resets + - reset-names + - power-domains + - "#phy-cells" + +additionalProperties: false + +examples: + - | + phy@295e0000 { + compatible = "starfive,jh7110-dphy-tx"; + reg = <0x295e0000 0x10000>; + clocks = <&voutcrg 14>; + clock-names = "txesc"; + resets = <&syscrg 10>; + reset-names = "sys"; + power-domains = <&aon_syscon 0>; + #phy-cells = <0>; + }; -- 2.17.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v4 2/2] phy: starfive: Add mipi dphy tx support 2024-03-01 1:24 [PATCH v4 0/2] Add JH7110 MIPI DPHY TX support Shengyang Chen 2024-03-01 1:24 ` [PATCH v4 1/2] dt-bindings: phy: Add starfive,jh7110-dphy-tx Shengyang Chen @ 2024-03-01 1:24 ` Shengyang Chen 2024-04-05 16:31 ` Vinod Koul 2024-03-18 3:33 ` [PATCH v4 0/2] Add JH7110 MIPI DPHY TX support Shengyang Chen 2 siblings, 1 reply; 6+ messages in thread From: Shengyang Chen @ 2024-03-01 1:24 UTC (permalink / raw) To: devicetree, linux-phy Cc: vkoul, kishon, robh+dt, krzysztof.kozlowski+dt, conor+dt, p.zabel, minda.chen, changhuang.liang, rogerq, geert+renesas, keith.zhao, shengyang.chen, linux-kernel Add mipi dphy tx support for the StarFive JH7110 SoC. It is a module which is used to receive data from DSI driver and transfer data to DSI interface like mipi screen. Signed-off-by: Shengyang Chen <shengyang.chen@starfivetech.com> Reviewed-by: Changhuang Liang <changhuang.liang@starfivetech.com> --- MAINTAINERS | 7 + drivers/phy/starfive/Kconfig | 10 + drivers/phy/starfive/Makefile | 1 + drivers/phy/starfive/phy-jh7110-dphy-tx.c | 702 ++++++++++++++++++++++ 4 files changed, 720 insertions(+) create mode 100644 drivers/phy/starfive/phy-jh7110-dphy-tx.c diff --git a/MAINTAINERS b/MAINTAINERS index ddbe6c82610f..13219c6504a9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -20871,6 +20871,13 @@ S: Supported F: Documentation/devicetree/bindings/phy/starfive,jh7110-dphy-rx.yaml F: drivers/phy/starfive/phy-jh7110-dphy-rx.c +STARFIVE JH7110 DPHY TX DRIVER +M: Keith Zhao <keith.zhao@starfivetech.com> +M: Shengyang Chen <shengyang.chen@starfivetech.com> +S: Supported +F: Documentation/devicetree/bindings/phy/starfive,jh7110-dphy-tx.yaml +F: drivers/phy/starfive/phy-jh7110-dphy-tx.c + STARFIVE JH7110 MMC/SD/SDIO DRIVER M: William Qiu <william.qiu@starfivetech.com> S: Supported diff --git a/drivers/phy/starfive/Kconfig b/drivers/phy/starfive/Kconfig index 9508e2143011..d0cdd7cb4a13 100644 --- a/drivers/phy/starfive/Kconfig +++ b/drivers/phy/starfive/Kconfig @@ -15,6 +15,16 @@ config PHY_STARFIVE_JH7110_DPHY_RX system. If M is selected, the module will be called phy-jh7110-dphy-rx.ko. +config PHY_STARFIVE_JH7110_DPHY_TX + tristate "StarFive JH7110 D-PHY TX Support" + depends on HAS_IOMEM + select GENERIC_PHY + select GENERIC_PHY_MIPI_DPHY + help + Choose this option if you have a StarFive D-PHY TX in your + system. If M is selected, the module will be called + phy-jh7110-dphy-tx.ko. + config PHY_STARFIVE_JH7110_PCIE tristate "Starfive JH7110 PCIE 2.0/USB 3.0 PHY support" depends on HAS_IOMEM diff --git a/drivers/phy/starfive/Makefile b/drivers/phy/starfive/Makefile index b391018b7c47..eedc4a6fec15 100644 --- a/drivers/phy/starfive/Makefile +++ b/drivers/phy/starfive/Makefile @@ -1,4 +1,5 @@ # SPDX-License-Identifier: GPL-2.0 obj-$(CONFIG_PHY_STARFIVE_JH7110_DPHY_RX) += phy-jh7110-dphy-rx.o +obj-$(CONFIG_PHY_STARFIVE_JH7110_DPHY_TX) += phy-jh7110-dphy-tx.o obj-$(CONFIG_PHY_STARFIVE_JH7110_PCIE) += phy-jh7110-pcie.o obj-$(CONFIG_PHY_STARFIVE_JH7110_USB) += phy-jh7110-usb.o diff --git a/drivers/phy/starfive/phy-jh7110-dphy-tx.c b/drivers/phy/starfive/phy-jh7110-dphy-tx.c new file mode 100644 index 000000000000..df30cd424ba7 --- /dev/null +++ b/drivers/phy/starfive/phy-jh7110-dphy-tx.c @@ -0,0 +1,702 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * DPHY TX driver for the StarFive JH7110 SoC + * + * Copyright (C) 2023 StarFive Technology Co., Ltd. + * Author: Keith Zhao <keith.zhao@starfivetech.com> + * Author: Shengyang Chen <shengyang.chen@starfivetech.com> + */ + +#include <linux/clk.h> +#include <linux/io.h> +#include <linux/mfd/syscon.h> +#include <linux/module.h> +#include <linux/of.h> +#include <linux/of_device.h> +#include <linux/phy/phy.h> +#include <linux/phy/phy-mipi-dphy.h> +#include <linux/platform_device.h> +#include <linux/pm_runtime.h> +#include <linux/reset.h> + +#define STF_DPHY_APBIFSAIF_SYSCFG(x) (x) + +#define STF_DPHY_AON_POWER_READY_N_ACTIVE 0 +#define STF_DPHY_AON_POWER_READY_N_SHIFT 0x0U +#define STF_DPHY_AON_POWER_READY_N_MASK BIT(0) +#define STF_DPHY_CFG_L0_SWAP_SEL_SHIFT 0xcU +#define STF_DPHY_CFG_L0_SWAP_SEL_MASK GENMASK(14, 12) +#define STF_DPHY_CFG_L1_SWAP_SEL_SHIFT 0xfU +#define STF_DPHY_CFG_L1_SWAP_SEL_MASK GENMASK(17, 15) +#define STF_DPHY_CFG_L2_SWAP_SEL_SHIFT 0x12U +#define STF_DPHY_CFG_L2_SWAP_SEL_MASK GENMASK(20, 18) +#define STF_DPHY_CFG_L3_SWAP_SEL_SHIFT 0x15U +#define STF_DPHY_CFG_L3_SWAP_SEL_MASK GENMASK(23, 21) +#define STF_DPHY_CFG_L4_SWAP_SEL_SHIFT 0x18U +#define STF_DPHY_CFG_L4_SWAP_SEL_MASK GENMASK(26, 24) +#define STF_DPHY_RGS_CDTX_PLL_UNLOCK_SHIFT 0x12U +#define STF_DPHY_RGS_CDTX_PLL_UNLOCK_MASK BIT(18) +#define STF_DPHY_RG_CDTX_L0N_HSTX_RES_SHIFT 0x13U +#define STF_DPHY_RG_CDTX_L0N_HSTX_RES_MASK GENMASK(23, 19) +#define STF_DPHY_RG_CDTX_L0P_HSTX_RES_SHIFT 0x18U +#define STF_DPHY_RG_CDTX_L0P_HSTX_RES_MASK GENMASK(28, 24) + +#define STF_DPHY_RG_CDTX_L1P_HSTX_RES_SHIFT 0x5U +#define STF_DPHY_RG_CDTX_L1P_HSTX_RES_MASK GENMASK(9, 5) +#define STF_DPHY_RG_CDTX_L2N_HSTX_RES_SHIFT 0xaU +#define STF_DPHY_RG_CDTX_L2N_HSTX_RES_MASK GENMASK(14, 10) +#define STF_DPHY_RG_CDTX_L2P_HSTX_RES_SHIFT 0xfU +#define STF_DPHY_RG_CDTX_L2P_HSTX_RES_MASK GENMASK(19, 15) +#define STF_DPHY_RG_CDTX_L3N_HSTX_RES_SHIFT 0x14U +#define STF_DPHY_RG_CDTX_L3N_HSTX_RES_MASK GENMASK(24, 20) +#define STF_DPHY_RG_CDTX_L3P_HSTX_RES_SHIFT 0x19U +#define STF_DPHY_RG_CDTX_L3P_HSTX_RES_MASK GENMASK(29, 25) + +#define STF_DPHY_RG_CDTX_L4N_HSTX_RES_SHIFT 0x0U +#define STF_DPHY_RG_CDTX_L4N_HSTX_RES_MASK GENMASK(4, 0) +#define STF_DPHY_RG_CDTX_L4P_HSTX_RES_SHIFT 0x5U +#define STF_DPHY_RG_CDTX_L4P_HSTX_RES_MASK GENMASK(9, 5) +#define STF_DPHY_RG_CDTX_PLL_FBK_FRA_SHIFT 0x0U +#define STF_DPHY_RG_CDTX_PLL_FBK_FRA_MASK GENMASK(23, 0) + +#define STF_DPHY_RG_CDTX_PLL_FBK_INT_SHIFT 0x0U +#define STF_DPHY_RG_CDTX_PLL_FBK_INT_MASK GENMASK(8, 0) +#define STF_DPHY_RG_CDTX_PLL_FM_EN_SHIFT 0x9U +#define STF_DPHY_RG_CDTX_PLL_FM_EN_MASK BIT(9) +#define STF_DPHY_RG_CDTX_PLL_LDO_STB_X2_EN_SHIFT 0xaU +#define STF_DPHY_RG_CDTX_PLL_LDO_STB_X2_EN_MASK BIT(10) +#define STF_DPHY_RG_CDTX_PLL_PRE_DIV_SHIFT 0xbU +#define STF_DPHY_RG_CDTX_PLL_PRE_DIV_MASK GENMASK(12, 11) + +#define STF_DPHY_RG_CDTX_PLL_SSC_EN_SHIFT 0x12U +#define STF_DPHY_RG_CDTX_PLL_SSC_EN_MASK 0x40000U + +#define STF_DPHY_RG_CLANE_HS_CLK_POST_TIME_SHIFT 0x0U +#define STF_DPHY_RG_CLANE_HS_CLK_POST_TIME_MASK GENMASK(7, 0) +#define STF_DPHY_RG_CLANE_HS_CLK_PRE_TIME_SHIFT 0x8U +#define STF_DPHY_RG_CLANE_HS_CLK_PRE_TIME_MASK GENMASK(15, 8) +#define STF_DPHY_RG_CLANE_HS_PRE_TIME_SHIFT 0x10U +#define STF_DPHY_RG_CLANE_HS_PRE_TIME_MASK GENMASK(23, 16) +#define STF_DPHY_RG_CLANE_HS_TRAIL_TIME_SHIFT 0x18U +#define STF_DPHY_RG_CLANE_HS_TRAIL_TIME_MASK GENMASK(31, 24) + +#define STF_DPHY_RG_CLANE_HS_ZERO_TIME_SHIFT 0x0U +#define STF_DPHY_RG_CLANE_HS_ZERO_TIME_MASK GENMASK(7, 0) +#define STF_DPHY_RG_DLANE_HS_PRE_TIME_SHIFT 0x8U +#define STF_DPHY_RG_DLANE_HS_PRE_TIME_MASK GENMASK(15, 8) +#define STF_DPHY_RG_DLANE_HS_TRAIL_TIME_SHIFT 0x10U +#define STF_DPHY_RG_DLANE_HS_TRAIL_TIME_MASK GENMASK(23, 16) +#define STF_DPHY_RG_DLANE_HS_ZERO_TIME_SHIFT 0x18U +#define STF_DPHY_RG_DLANE_HS_ZERO_TIME_MASK GENMASK(31, 24) + +#define STF_DPHY_RG_EXTD_CYCLE_SEL_SHIFT 0x0U +#define STF_DPHY_RG_EXTD_CYCLE_SEL_MASK GENMASK(2, 0) +#define STF_DPHY_SCFG_C_HS_PRE_ZERO_TIME_SHIFT 0x0U +#define STF_DPHY_SCFG_C_HS_PRE_ZERO_TIME_MASK GENMASK(31, 0) + +#define STF_DPHY_SCFG_DSI_TXREADY_ESC_SEL_SHIFT 0x1U +#define STF_DPHY_SCFG_DSI_TXREADY_ESC_SEL_MASK GENMASK(2, 1) +#define STF_DPHY_SCFG_PPI_C_READY_SEL_SHIFT 0x3U +#define STF_DPHY_SCFG_PPI_C_READY_SEL_MASK GENMASK(4, 3) + +#define STF_DPHY_REFCLK_IN_SEL_SHIFT 0x1aU +#define STF_DPHY_REFCLK_IN_SEL_MASK GENMASK(28, 26) +#define STF_DPHY_RESETB_SHIFT 0x1dU +#define STF_DPHY_RESETB_MASK BIT(29) + +#define STF_DPHY_REFCLK_12M 1 +#define STF_DPHY_BITRATE_ALIGN 10000000 + +#define STF_MAP_LANES_NUM 5 + +#define STF_DPHY_LSHIFT_16(x) ((x) << 16) +#define STF_DPHY_LSHIFT_8(x) ((x) << 8) + +struct m31_dphy_config { + int ref_clk; + unsigned long bitrate; + u32 pll_prev_div; + u32 pll_fbk_int; + u32 pll_fbk_fra; + u32 extd_cycle_sel; + u32 dlane_hs_pre_time; + u32 dlane_hs_zero_time; + u32 dlane_hs_trail_time; + u32 clane_hs_pre_time; + u32 clane_hs_zero_time; + u32 clane_hs_trail_time; + u32 clane_hs_clk_pre_time; + u32 clane_hs_clk_post_time; +}; + +static const struct m31_dphy_config m31_dphy_configs[] = { + {12000000, 160000000, 0x0, 0x6a, + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, + 0x3, 0xa, 0x17, 0x11, 0x5, 0x2b, 0xd, 0x7, 0x3d}, + {12000000, 170000000, 0x0, 0x71, + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, + 0x3, 0xb, 0x18, 0x11, 0x5, 0x2e, 0xd, 0x7, 0x3d}, + {12000000, 180000000, 0x0, 0x78, + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, + 0x3, 0xb, 0x19, 0x12, 0x6, 0x30, 0xe, 0x7, 0x3e}, + {12000000, 190000000, 0x0, 0x7e, + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, + 0x3, 0xc, 0x1a, 0x12, 0x6, 0x33, 0xe, 0x7, 0x3e}, + {12000000, 200000000, 0x0, 0x85, + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, + 0x3, 0xc, 0x1b, 0x13, 0x7, 0x35, 0xf, 0x7, 0x3f}, + {12000000, 320000000, 0x0, 0x6a, + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, + 0x2, 0x8, 0x14, 0xf, 0x5, 0x2b, 0xd, 0x3, 0x23}, + {12000000, 330000000, 0x0, 0x6e, + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, + 0x2, 0x8, 0x15, 0xf, 0x5, 0x2d, 0xd, 0x3, 0x23}, + {12000000, 340000000, 0x0, 0x71, + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, + 0x2, 0x9, 0x15, 0xf, 0x5, 0x2e, 0xd, 0x3, 0x23}, + {12000000, 350000000, 0x0, 0x74, + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, + 0x2, 0x9, 0x15, 0x10, 0x6, 0x2f, 0xe, 0x3, 0x24}, + {12000000, 360000000, 0x0, 0x78, + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, + 0x2, 0x9, 0x16, 0x10, 0x6, 0x30, 0xe, 0x3, 0x24}, + {12000000, 370000000, 0x0, 0x7b, + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, + 0x2, 0x9, 0x17, 0x10, 0x6, 0x32, 0xe, 0x3, 0x24}, + {12000000, 380000000, 0x0, 0x7e, + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, + 0x2, 0xa, 0x17, 0x10, 0x6, 0x33, 0xe, 0x3, 0x24}, + {12000000, 390000000, 0x0, 0x82, + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, 0x2, + 0xa, 0x17, 0x11, 0x6, 0x35, 0xf, 0x3, 0x25}, + {12000000, 400000000, 0x0, 0x85, + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, + 0x2, 0xa, 0x18, 0x11, 0x7, 0x35, 0xf, 0x3, 0x25}, + {12000000, 410000000, 0x0, 0x88, + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, + 0x2, 0xa, 0x19, 0x11, 0x7, 0x37, 0xf, 0x3, 0x25}, + {12000000, 420000000, 0x0, 0x8c, + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, + 0x2, 0xa, 0x19, 0x12, 0x7, 0x38, 0x10, 0x3, 0x26}, + {12000000, 430000000, 0x0, 0x8f, + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, + 0x2, 0xb, 0x19, 0x12, 0x7, 0x39, 0x10, 0x3, 0x26}, + {12000000, 440000000, 0x0, 0x92, + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, + 0x2, 0xb, 0x1a, 0x12, 0x7, 0x3b, 0x10, 0x3, 0x26}, + {12000000, 450000000, 0x0, 0x96, + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, + 0x2, 0xb, 0x1b, 0x12, 0x8, 0x3c, 0x10, 0x3, 0x26}, + {12000000, 460000000, 0x0, 0x99, + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, + 0x2, 0xb, 0x1b, 0x13, 0x8, 0x3d, 0x11, 0x3, 0x27}, + {12000000, 470000000, 0x0, 0x9c, + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, + 0x2, 0xc, 0x1b, 0x13, 0x8, 0x3e, 0x11, 0x3, 0x27}, + {12000000, 480000000, 0x0, 0xa0, + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, + 0x2, 0xc, 0x1c, 0x13, 0x8, 0x40, 0x11, 0x3, 0x27}, + {12000000, 490000000, 0x0, 0xa3, + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, + 0x2, 0xc, 0x1d, 0x14, 0x8, 0x42, 0x12, 0x3, 0x28}, + {12000000, 500000000, 0x0, 0xa6, + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, + 0x2, 0xc, 0x1d, 0x14, 0x9, 0x42, 0x12, 0x3, 0x28}, + {12000000, 510000000, 0x0, 0xaa, + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, + 0x2, 0xc, 0x1e, 0x14, 0x9, 0x44, 0x12, 0x3, 0x28}, + {12000000, 520000000, 0x0, 0xad, + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, + 0x2, 0xd, 0x1e, 0x15, 0x9, 0x45, 0x13, 0x3, 0x29}, + {12000000, 530000000, 0x0, 0xb0, + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, + 0x2, 0xd, 0x1e, 0x15, 0x9, 0x47, 0x13, 0x3, 0x29}, + {12000000, 540000000, 0x0, 0xb4, + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, + 0x2, 0xd, 0x1f, 0x15, 0x9, 0x48, 0x13, 0x3, 0x29}, + {12000000, 550000000, 0x0, 0xb7, + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, + 0x2, 0xd, 0x20, 0x16, 0x9, 0x4a, 0x14, 0x3, 0x2a}, + {12000000, 560000000, 0x0, 0xba, + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, + 0x2, 0xe, 0x20, 0x16, 0xa, 0x4a, 0x14, 0x3, 0x2a}, + {12000000, 570000000, 0x0, 0xbe, + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, + 0x2, 0xe, 0x20, 0x16, 0xa, 0x4c, 0x14, 0x3, 0x2a}, + {12000000, 580000000, 0x0, 0xc1, + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, + 0x2, 0xe, 0x21, 0x16, 0xa, 0x4d, 0x14, 0x3, 0x2a}, + {12000000, 590000000, 0x0, 0xc4, + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, + 0x2, 0xe, 0x22, 0x17, 0xa, 0x4f, 0x15, 0x3, 0x2b}, + {12000000, 600000000, 0x0, 0xc8, + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, + 0x2, 0xe, 0x23, 0x17, 0xa, 0x50, 0x15, 0x3, 0x2b}, + {12000000, 610000000, 0x0, 0xcb, + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, + 0x2, 0xf, 0x22, 0x17, 0xb, 0x50, 0x15, 0x3, 0x2b}, + {12000000, 620000000, 0x0, 0xce, + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, + 0x2, 0xf, 0x23, 0x18, 0xb, 0x52, 0x16, 0x3, 0x2c}, + {12000000, 630000000, 0x0, 0x69, + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, + 0x1, 0x7, 0x12, 0xd, 0x5, 0x2a, 0xc, 0x1, 0x15}, + {12000000, 640000000, 0x0, 0x6a, + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, + 0x1, 0x7, 0x13, 0xe, 0x5, 0x2b, 0xd, 0x1, 0x16}, + {12000000, 650000000, 0x0, 0x6c, + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, + 0x1, 0x7, 0x13, 0xe, 0x5, 0x2c, 0xd, 0x1, 0x16}, + {12000000, 660000000, 0x0, 0x6e, + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, + 0x1, 0x7, 0x13, 0xe, 0x5, 0x2d, 0xd, 0x1, 0x16}, + {12000000, 670000000, 0x0, 0x6f, + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, + 0x1, 0x8, 0x13, 0xe, 0x5, 0x2d, 0xd, 0x1, 0x16}, + {12000000, 680000000, 0x0, 0x71, + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, + 0x1, 0x8, 0x13, 0xe, 0x5, 0x2e, 0xd, 0x1, 0x16}, + {12000000, 690000000, 0x0, 0x73, + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, + 0x1, 0x8, 0x14, 0xe, 0x6, 0x2e, 0xd, 0x1, 0x16}, + {12000000, 700000000, 0x0, 0x74, + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, + 0x1, 0x8, 0x14, 0xf, 0x6, 0x2f, 0xe, 0x1, 0x16}, + {12000000, 710000000, 0x0, 0x76, + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, + 0x1, 0x8, 0x14, 0xf, 0x6, 0x2f, 0xe, 0x1, 0x17}, + {12000000, 720000000, 0x0, 0x78, + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, + 0x1, 0x8, 0x15, 0xf, 0x6, 0x30, 0xe, 0x1, 0x17}, + {12000000, 730000000, 0x0, 0x79, + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, + 0x1, 0x8, 0x15, 0xf, 0x6, 0x31, 0xe, 0x1, 0x17}, + {12000000, 740000000, 0x0, 0x7b, + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, + 0x1, 0x8, 0x15, 0xf, 0x6, 0x32, 0xe, 0x1, 0x17}, + {12000000, 750000000, 0x0, 0x7d, + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, + 0x1, 0x8, 0x16, 0xf, 0x6, 0x32, 0xe, 0x1, 0x17}, + {12000000, 760000000, 0x0, 0x7e, + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, + 0x1, 0x9, 0x15, 0xf, 0x6, 0x33, 0xe, 0x1, 0x17}, + {12000000, 770000000, 0x0, 0x80, + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, + 0x1, 0x9, 0x15, 0x10, 0x6, 0x34, 0xf, 0x1, 0x18}, + {12000000, 780000000, 0x0, 0x82, + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, + 0x1, 0x9, 0x16, 0x10, 0x6, 0x35, 0xf, 0x1, 0x18,}, + {12000000, 790000000, 0x0, 0x83, + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, + 0x1, 0x9, 0x16, 0x10, 0x7, 0x34, 0xf, 0x1, 0x18}, + {12000000, 800000000, 0x0, 0x85, + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, + 0x1, 0x9, 0x17, 0x10, 0x7, 0x35, 0xf, 0x1, 0x18}, + {12000000, 810000000, 0x0, 0x87, + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, + 0x1, 0x9, 0x17, 0x10, 0x7, 0x36, 0xf, 0x1, 0x18}, + {12000000, 820000000, 0x0, 0x88, + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, + 0x1, 0x9, 0x17, 0x10, 0x7, 0x37, 0xf, 0x1, 0x18}, + {12000000, 830000000, 0x0, 0x8a, + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, + 0x1, 0x9, 0x18, 0x10, 0x7, 0x37, 0xf, 0x1, 0x18}, + {12000000, 840000000, 0x0, 0x8c, + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, + 0x1, 0x9, 0x18, 0x11, 0x7, 0x38, 0x10, 0x1, 0x19}, + {12000000, 850000000, 0x0, 0x8d, + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, + 0x1, 0xa, 0x17, 0x11, 0x7, 0x39, 0x10, 0x1, 0x19}, + {12000000, 860000000, 0x0, 0x8f, + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, + 0x1, 0xa, 0x18, 0x11, 0x7, 0x39, 0x10, 0x1, 0x19}, + {12000000, 870000000, 0x0, 0x91, + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, + 0x1, 0xa, 0x18, 0x11, 0x7, 0x3a, 0x10, 0x1, 0x19}, + {12000000, 880000000, 0x0, 0x92, + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, + 0x1, 0xa, 0x18, 0x11, 0x7, 0x3b, 0x10, 0x1, 0x19}, + {12000000, 890000000, 0x0, 0x94, + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, + 0x1, 0xa, 0x19, 0x11, 0x7, 0x3c, 0x10, 0x1, 0x19}, + {12000000, 900000000, 0x0, 0x96, + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, + 0x1, 0xa, 0x19, 0x12, 0x8, 0x3c, 0x10, 0x1, 0x19}, + {12000000, 910000000, 0x0, 0x97, + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, + 0x1, 0xa, 0x19, 0x12, 0x8, 0x3c, 0x11, 0x1, 0x1a}, + {12000000, 920000000, 0x0, 0x99, + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, + 0x1, 0xa, 0x1a, 0x12, 0x8, 0x3d, 0x11, 0x1, 0x1a}, + {12000000, 930000000, 0x0, 0x9b, + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, + 0x1, 0xa, 0x1a, 0x12, 0x8, 0x3e, 0x11, 0x1, 0x1a}, + {12000000, 940000000, 0x0, 0x9c, + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, + 0x1, 0xb, 0x1a, 0x12, 0x8, 0x3e, 0x11, 0x1, 0x1a}, + {12000000, 950000000, 0x0, 0x9e, + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, + 0x1, 0xb, 0x1a, 0x12, 0x8, 0x3f, 0x11, 0x1, 0x1a}, + {12000000, 960000000, 0x0, 0xa0, + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, + 0x1, 0xb, 0x1a, 0x12, 0x8, 0x40, 0x11, 0x1, 0x1a}, + {12000000, 970000000, 0x0, 0xa1, + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, + 0x1, 0xb, 0x1b, 0x13, 0x8, 0x41, 0x12, 0x1, 0x1b}, + {12000000, 980000000, 0x0, 0xa3, + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, + 0x1, 0xb, 0x1b, 0x13, 0x8, 0x42, 0x12, 0x1, 0x1b}, + {12000000, 990000000, 0x0, 0xa5, + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, + 0x1, 0xb, 0x1b, 0x13, 0x8, 0x42, 0x12, 0x1, 0x1b}, + {12000000, 1000000000, 0x0, 0xa6, + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, + 0x1, 0xb, 0x1c, 0x13, 0x9, 0x42, 0x12, 0x1, 0x1b}, +}; + +struct stf_dphy_info { + /** + * @maps: + * + * Physical lanes and logic lanes mapping table. + * + * The default order is: + * [data lane 0, data lane 1, data lane 2, date lane 3, clk lane] + */ + u8 maps[STF_MAP_LANES_NUM]; +}; + +struct stf_dphy { + struct device *dev; + void __iomem *topsys; + struct clk *txesc_clk; + struct reset_control *sys_rst; + + struct phy_configure_opts_mipi_dphy config; + + struct phy *phy; + const struct stf_dphy_info *info; +}; + +static inline u32 stf_dphy_get_reg(void __iomem *io_addr, u32 addr, u32 shift, u32 mask) +{ + u32 tmp; + + tmp = readl(io_addr); + tmp = (tmp & mask) >> shift; + return tmp; +} + +static inline void stf_dphy_set_reg(void __iomem *io_addr, u32 addr, u32 data, u32 shift, u32 mask) +{ + u32 tmp; + + tmp = readl(io_addr + addr); + tmp &= ~mask; + tmp |= (data << shift) & mask; + writel(tmp, (io_addr + addr)); +} + +static int is_pll_locked(struct stf_dphy *dphy) +{ + int tmp = stf_dphy_get_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(8), + STF_DPHY_RGS_CDTX_PLL_UNLOCK_SHIFT, + STF_DPHY_RGS_CDTX_PLL_UNLOCK_MASK); + return !tmp; +} + +static void stf_dphy_hw_reset(struct stf_dphy *dphy, int assert) +{ + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(100), + !assert, STF_DPHY_RESETB_SHIFT, STF_DPHY_RESETB_MASK); + + if (!assert) { + while ((!is_pll_locked(dphy))) + ; + dev_err(dphy->dev, "MIPI dphy-tx # PLL Locked\n"); + } +} + +static int stf_dphy_configure(struct phy *phy, union phy_configure_opts *opts) +{ + struct stf_dphy *dphy = phy_get_drvdata(phy); + const struct stf_dphy_info *info = dphy->info; + u32 bitrate = opts->mipi_dphy.hs_clk_rate; + const struct m31_dphy_config *p; + unsigned long alignment; + int i; + + bitrate = opts->mipi_dphy.hs_clk_rate; + + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(8), 0x10, + STF_DPHY_RG_CDTX_L0N_HSTX_RES_SHIFT, STF_DPHY_RG_CDTX_L0N_HSTX_RES_MASK); + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(12), 0x10, + STF_DPHY_RG_CDTX_L0N_HSTX_RES_SHIFT, STF_DPHY_RG_CDTX_L0N_HSTX_RES_MASK); + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(12), 0x10, + STF_DPHY_RG_CDTX_L2N_HSTX_RES_SHIFT, STF_DPHY_RG_CDTX_L2N_HSTX_RES_MASK); + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(12), 0x10, + STF_DPHY_RG_CDTX_L3N_HSTX_RES_SHIFT, STF_DPHY_RG_CDTX_L3N_HSTX_RES_MASK); + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(16), 0x10, + STF_DPHY_RG_CDTX_L4N_HSTX_RES_SHIFT, STF_DPHY_RG_CDTX_L4N_HSTX_RES_MASK); + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(8), 0x10, + STF_DPHY_RG_CDTX_L0P_HSTX_RES_SHIFT, STF_DPHY_RG_CDTX_L0P_HSTX_RES_MASK); + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(12), 0x10, + STF_DPHY_RG_CDTX_L1P_HSTX_RES_SHIFT, STF_DPHY_RG_CDTX_L1P_HSTX_RES_MASK); + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(12), 0x10, + STF_DPHY_RG_CDTX_L2P_HSTX_RES_SHIFT, STF_DPHY_RG_CDTX_L2P_HSTX_RES_MASK); + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(12), 0x10, + STF_DPHY_RG_CDTX_L3P_HSTX_RES_SHIFT, STF_DPHY_RG_CDTX_L3P_HSTX_RES_MASK); + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(16), 0x10, + STF_DPHY_RG_CDTX_L4P_HSTX_RES_SHIFT, STF_DPHY_RG_CDTX_L4P_HSTX_RES_MASK); + + alignment = STF_DPHY_BITRATE_ALIGN; + if (bitrate % alignment) + bitrate += alignment - (bitrate % alignment); + + p = m31_dphy_configs; + for (i = 0; i < ARRAY_SIZE(m31_dphy_configs); i++, p++) { + if (p->bitrate == bitrate) { + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(100), + STF_DPHY_REFCLK_12M, STF_DPHY_REFCLK_IN_SEL_SHIFT, + STF_DPHY_REFCLK_IN_SEL_MASK); + + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(0), + STF_DPHY_AON_POWER_READY_N_ACTIVE, + STF_DPHY_AON_POWER_READY_N_SHIFT, + STF_DPHY_AON_POWER_READY_N_MASK); + + /*Lane setting*/ + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(0), info->maps[0], + STF_DPHY_CFG_L0_SWAP_SEL_SHIFT, + STF_DPHY_CFG_L0_SWAP_SEL_MASK); + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(0), info->maps[1], + STF_DPHY_CFG_L1_SWAP_SEL_SHIFT, + STF_DPHY_CFG_L1_SWAP_SEL_MASK); + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(0), info->maps[2], + STF_DPHY_CFG_L2_SWAP_SEL_SHIFT, + STF_DPHY_CFG_L2_SWAP_SEL_MASK); + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(0), info->maps[3], + STF_DPHY_CFG_L3_SWAP_SEL_SHIFT, + STF_DPHY_CFG_L3_SWAP_SEL_MASK); + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(0), info->maps[4], + STF_DPHY_CFG_L4_SWAP_SEL_SHIFT, + STF_DPHY_CFG_L4_SWAP_SEL_MASK); + /*PLL setting*/ + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(28), 0x0, + STF_DPHY_RG_CDTX_PLL_SSC_EN_SHIFT, + STF_DPHY_RG_CDTX_PLL_SSC_EN_MASK); + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(24), 0x1, + STF_DPHY_RG_CDTX_PLL_LDO_STB_X2_EN_SHIFT, + STF_DPHY_RG_CDTX_PLL_LDO_STB_X2_EN_MASK); + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(24), 0x1, + STF_DPHY_RG_CDTX_PLL_FM_EN_SHIFT, + STF_DPHY_RG_CDTX_PLL_FM_EN_MASK); + + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(24), + p->pll_prev_div, STF_DPHY_RG_CDTX_PLL_PRE_DIV_SHIFT, + STF_DPHY_RG_CDTX_PLL_PRE_DIV_MASK); + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(24), + p->pll_fbk_int, STF_DPHY_RG_CDTX_PLL_FBK_INT_SHIFT, + STF_DPHY_RG_CDTX_PLL_FBK_INT_MASK); + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(20), + p->pll_fbk_fra, STF_DPHY_RG_CDTX_PLL_FBK_FRA_SHIFT, + STF_DPHY_RG_CDTX_PLL_FBK_FRA_MASK); + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(40), + p->extd_cycle_sel, STF_DPHY_RG_EXTD_CYCLE_SEL_SHIFT, + STF_DPHY_RG_EXTD_CYCLE_SEL_MASK); + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(36), + p->dlane_hs_pre_time, + STF_DPHY_RG_DLANE_HS_PRE_TIME_SHIFT, + STF_DPHY_RG_DLANE_HS_PRE_TIME_MASK); + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(36), + p->dlane_hs_pre_time, + STF_DPHY_RG_DLANE_HS_PRE_TIME_SHIFT, + STF_DPHY_RG_DLANE_HS_PRE_TIME_MASK); + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(36), + p->dlane_hs_zero_time, + STF_DPHY_RG_DLANE_HS_ZERO_TIME_SHIFT, + STF_DPHY_RG_DLANE_HS_ZERO_TIME_MASK); + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(36), + p->dlane_hs_trail_time, + STF_DPHY_RG_DLANE_HS_TRAIL_TIME_SHIFT, + STF_DPHY_RG_DLANE_HS_TRAIL_TIME_MASK); + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(32), + p->clane_hs_pre_time, + STF_DPHY_RG_CLANE_HS_PRE_TIME_SHIFT, + STF_DPHY_RG_CLANE_HS_PRE_TIME_MASK); + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(36), + p->clane_hs_zero_time, + STF_DPHY_RG_CLANE_HS_ZERO_TIME_SHIFT, + STF_DPHY_RG_CLANE_HS_ZERO_TIME_MASK); + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(32), + p->clane_hs_trail_time, + STF_DPHY_RG_CLANE_HS_TRAIL_TIME_SHIFT, + STF_DPHY_RG_CLANE_HS_TRAIL_TIME_MASK); + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(32), + p->clane_hs_clk_pre_time, + STF_DPHY_RG_CLANE_HS_CLK_PRE_TIME_SHIFT, + STF_DPHY_RG_CLANE_HS_CLK_PRE_TIME_MASK); + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(32), + p->clane_hs_clk_post_time, + STF_DPHY_RG_CLANE_HS_CLK_POST_TIME_SHIFT, + STF_DPHY_RG_CLANE_HS_CLK_POST_TIME_MASK); + + break; + } + } + + return 0; +} + +static int stf_dphy_init(struct phy *phy) +{ + struct stf_dphy *dphy = phy_get_drvdata(phy); + int ret; + + stf_dphy_hw_reset(dphy, 0); + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(48), 0, + STF_DPHY_SCFG_PPI_C_READY_SEL_SHIFT, STF_DPHY_SCFG_PPI_C_READY_SEL_MASK); + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(48), 0, + STF_DPHY_SCFG_DSI_TXREADY_ESC_SEL_SHIFT, + STF_DPHY_SCFG_DSI_TXREADY_ESC_SEL_MASK); + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(44), 0x30, + STF_DPHY_SCFG_C_HS_PRE_ZERO_TIME_SHIFT, + STF_DPHY_SCFG_C_HS_PRE_ZERO_TIME_MASK); + + ret = clk_prepare_enable(dphy->txesc_clk); + if (ret) { + dev_err(dphy->dev, "Failed to prepare/enable txesc_clk\n"); + return ret; + } + + ret = reset_control_deassert(dphy->sys_rst); + if (ret) { + dev_err(dphy->dev, "Failed to deassert sys_rst\n"); + return ret; + } + + return 0; +} + +static int stf_dphy_exit(struct phy *phy) +{ + struct stf_dphy *dphy = phy_get_drvdata(phy); + int ret; + + ret = reset_control_assert(dphy->sys_rst); + if (ret) { + dev_err(dphy->dev, "Failed to assert sys_rst\n"); + return ret; + } + + clk_disable_unprepare(dphy->txesc_clk); + + stf_dphy_hw_reset(dphy, 1); + + return 0; +} + +static int stf_dphy_power_on(struct phy *phy) +{ + struct stf_dphy *dphy = phy_get_drvdata(phy); + + return pm_runtime_resume_and_get(dphy->dev); +} + +static int stf_dphy_validate(struct phy *phy, enum phy_mode mode, int submode, + union phy_configure_opts *opts) +{ + if (mode != PHY_MODE_MIPI_DPHY) + return -EINVAL; + + return 0; +} + +static int stf_dphy_power_off(struct phy *phy) +{ + struct stf_dphy *dphy = phy_get_drvdata(phy); + + return pm_runtime_put_sync(dphy->dev); +} + +static const struct phy_ops stf_dphy_ops = { + .power_on = stf_dphy_power_on, + .power_off = stf_dphy_power_off, + .init = stf_dphy_init, + .exit = stf_dphy_exit, + .configure = stf_dphy_configure, + .validate = stf_dphy_validate, + .owner = THIS_MODULE, +}; + +static int stf_dphy_probe(struct platform_device *pdev) +{ + struct phy_provider *phy_provider; + struct stf_dphy *dphy; + + dphy = devm_kzalloc(&pdev->dev, sizeof(*dphy), GFP_KERNEL); + if (!dphy) + return -ENOMEM; + + dphy->info = of_device_get_match_data(&pdev->dev); + + dphy->dev = &pdev->dev; + dev_set_drvdata(&pdev->dev, dphy); + + dphy->topsys = devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(dphy->topsys)) + return PTR_ERR(dphy->topsys); + + pm_runtime_enable(&pdev->dev); + + dphy->txesc_clk = devm_clk_get(&pdev->dev, "txesc"); + if (IS_ERR(dphy->txesc_clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(dphy->txesc_clk), + "Failed to get txesc clock\n"); + + dphy->sys_rst = devm_reset_control_get_exclusive(&pdev->dev, "sys"); + if (IS_ERR(dphy->sys_rst)) + return dev_err_probe(&pdev->dev, PTR_ERR(dphy->sys_rst), + "Failed to get sys reset\n"); + + dphy->phy = devm_phy_create(&pdev->dev, NULL, &stf_dphy_ops); + if (IS_ERR(dphy->phy)) + return dev_err_probe(&pdev->dev, PTR_ERR(dphy->phy), + "Failed to create phy\n"); + + phy_set_drvdata(dphy->phy, dphy); + + phy_provider = devm_of_phy_provider_register(&pdev->dev, of_phy_simple_xlate); + if (IS_ERR(phy_provider)) + return dev_err_probe(&pdev->dev, PTR_ERR(phy_provider), + "Failed to register phy\n"); + + return 0; +} + +static const struct stf_dphy_info starfive_dphy_info = { + .maps = {0, 1, 2, 3, 4}, +}; + +static const struct of_device_id stf_dphy_dt_ids[] = { + { + .compatible = "starfive,jh7110-dphy-tx", + .data = &starfive_dphy_info, + }, + { /* sentinel */ }, +}; +MODULE_DEVICE_TABLE(of, stf_dphy_dt_ids); + +static struct platform_driver stf_dphy_driver = { + .driver = { + .name = "starfive-dphy-tx", + .of_match_table = stf_dphy_dt_ids, + }, + .probe = stf_dphy_probe, +}; +module_platform_driver(stf_dphy_driver); + +MODULE_AUTHOR("Keith Zhao <keith.zhao@starfivetech.com>"); +MODULE_AUTHOR("Shengyang Chen <shengyang.chen@starfivetech.com>"); +MODULE_DESCRIPTION("StarFive JH7110 DPHY TX driver"); +MODULE_LICENSE("GPL"); -- 2.17.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v4 2/2] phy: starfive: Add mipi dphy tx support 2024-03-01 1:24 ` [PATCH v4 2/2] phy: starfive: Add mipi dphy tx support Shengyang Chen @ 2024-04-05 16:31 ` Vinod Koul 2024-04-09 6:30 ` Shengyang Chen 0 siblings, 1 reply; 6+ messages in thread From: Vinod Koul @ 2024-04-05 16:31 UTC (permalink / raw) To: Shengyang Chen Cc: devicetree, linux-phy, kishon, robh+dt, krzysztof.kozlowski+dt, conor+dt, p.zabel, minda.chen, changhuang.liang, rogerq, geert+renesas, keith.zhao, linux-kernel On 01-03-24, 09:24, Shengyang Chen wrote: > Add mipi dphy tx support for the StarFive JH7110 SoC. > It is a module which is used to receive data from DSI > driver and transfer data to DSI interface like mipi screen. > > Signed-off-by: Shengyang Chen <shengyang.chen@starfivetech.com> > Reviewed-by: Changhuang Liang <changhuang.liang@starfivetech.com> > --- > MAINTAINERS | 7 + > drivers/phy/starfive/Kconfig | 10 + > drivers/phy/starfive/Makefile | 1 + > drivers/phy/starfive/phy-jh7110-dphy-tx.c | 702 ++++++++++++++++++++++ > 4 files changed, 720 insertions(+) > create mode 100644 drivers/phy/starfive/phy-jh7110-dphy-tx.c > > diff --git a/MAINTAINERS b/MAINTAINERS > index ddbe6c82610f..13219c6504a9 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -20871,6 +20871,13 @@ S: Supported > F: Documentation/devicetree/bindings/phy/starfive,jh7110-dphy-rx.yaml > F: drivers/phy/starfive/phy-jh7110-dphy-rx.c > > +STARFIVE JH7110 DPHY TX DRIVER > +M: Keith Zhao <keith.zhao@starfivetech.com> > +M: Shengyang Chen <shengyang.chen@starfivetech.com> > +S: Supported > +F: Documentation/devicetree/bindings/phy/starfive,jh7110-dphy-tx.yaml > +F: drivers/phy/starfive/phy-jh7110-dphy-tx.c > + > STARFIVE JH7110 MMC/SD/SDIO DRIVER > M: William Qiu <william.qiu@starfivetech.com> > S: Supported > diff --git a/drivers/phy/starfive/Kconfig b/drivers/phy/starfive/Kconfig > index 9508e2143011..d0cdd7cb4a13 100644 > --- a/drivers/phy/starfive/Kconfig > +++ b/drivers/phy/starfive/Kconfig > @@ -15,6 +15,16 @@ config PHY_STARFIVE_JH7110_DPHY_RX > system. If M is selected, the module will be called > phy-jh7110-dphy-rx.ko. > > +config PHY_STARFIVE_JH7110_DPHY_TX > + tristate "StarFive JH7110 D-PHY TX Support" > + depends on HAS_IOMEM > + select GENERIC_PHY > + select GENERIC_PHY_MIPI_DPHY > + help > + Choose this option if you have a StarFive D-PHY TX in your > + system. If M is selected, the module will be called > + phy-jh7110-dphy-tx.ko. > + > config PHY_STARFIVE_JH7110_PCIE > tristate "Starfive JH7110 PCIE 2.0/USB 3.0 PHY support" > depends on HAS_IOMEM > diff --git a/drivers/phy/starfive/Makefile b/drivers/phy/starfive/Makefile > index b391018b7c47..eedc4a6fec15 100644 > --- a/drivers/phy/starfive/Makefile > +++ b/drivers/phy/starfive/Makefile > @@ -1,4 +1,5 @@ > # SPDX-License-Identifier: GPL-2.0 > obj-$(CONFIG_PHY_STARFIVE_JH7110_DPHY_RX) += phy-jh7110-dphy-rx.o > +obj-$(CONFIG_PHY_STARFIVE_JH7110_DPHY_TX) += phy-jh7110-dphy-tx.o > obj-$(CONFIG_PHY_STARFIVE_JH7110_PCIE) += phy-jh7110-pcie.o > obj-$(CONFIG_PHY_STARFIVE_JH7110_USB) += phy-jh7110-usb.o > diff --git a/drivers/phy/starfive/phy-jh7110-dphy-tx.c b/drivers/phy/starfive/phy-jh7110-dphy-tx.c > new file mode 100644 > index 000000000000..df30cd424ba7 > --- /dev/null > +++ b/drivers/phy/starfive/phy-jh7110-dphy-tx.c > @@ -0,0 +1,702 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * DPHY TX driver for the StarFive JH7110 SoC > + * > + * Copyright (C) 2023 StarFive Technology Co., Ltd. > + * Author: Keith Zhao <keith.zhao@starfivetech.com> > + * Author: Shengyang Chen <shengyang.chen@starfivetech.com> > + */ > + > +#include <linux/clk.h> > +#include <linux/io.h> > +#include <linux/mfd/syscon.h> > +#include <linux/module.h> > +#include <linux/of.h> > +#include <linux/of_device.h> > +#include <linux/phy/phy.h> > +#include <linux/phy/phy-mipi-dphy.h> > +#include <linux/platform_device.h> > +#include <linux/pm_runtime.h> > +#include <linux/reset.h> > + > +#define STF_DPHY_APBIFSAIF_SYSCFG(x) (x) > + > +#define STF_DPHY_AON_POWER_READY_N_ACTIVE 0 > +#define STF_DPHY_AON_POWER_READY_N_SHIFT 0x0U > +#define STF_DPHY_AON_POWER_READY_N_MASK BIT(0) > +#define STF_DPHY_CFG_L0_SWAP_SEL_SHIFT 0xcU > +#define STF_DPHY_CFG_L0_SWAP_SEL_MASK GENMASK(14, 12) > +#define STF_DPHY_CFG_L1_SWAP_SEL_SHIFT 0xfU > +#define STF_DPHY_CFG_L1_SWAP_SEL_MASK GENMASK(17, 15) > +#define STF_DPHY_CFG_L2_SWAP_SEL_SHIFT 0x12U > +#define STF_DPHY_CFG_L2_SWAP_SEL_MASK GENMASK(20, 18) > +#define STF_DPHY_CFG_L3_SWAP_SEL_SHIFT 0x15U > +#define STF_DPHY_CFG_L3_SWAP_SEL_MASK GENMASK(23, 21) > +#define STF_DPHY_CFG_L4_SWAP_SEL_SHIFT 0x18U > +#define STF_DPHY_CFG_L4_SWAP_SEL_MASK GENMASK(26, 24) > +#define STF_DPHY_RGS_CDTX_PLL_UNLOCK_SHIFT 0x12U > +#define STF_DPHY_RGS_CDTX_PLL_UNLOCK_MASK BIT(18) > +#define STF_DPHY_RG_CDTX_L0N_HSTX_RES_SHIFT 0x13U > +#define STF_DPHY_RG_CDTX_L0N_HSTX_RES_MASK GENMASK(23, 19) > +#define STF_DPHY_RG_CDTX_L0P_HSTX_RES_SHIFT 0x18U > +#define STF_DPHY_RG_CDTX_L0P_HSTX_RES_MASK GENMASK(28, 24) > + > +#define STF_DPHY_RG_CDTX_L1P_HSTX_RES_SHIFT 0x5U > +#define STF_DPHY_RG_CDTX_L1P_HSTX_RES_MASK GENMASK(9, 5) > +#define STF_DPHY_RG_CDTX_L2N_HSTX_RES_SHIFT 0xaU > +#define STF_DPHY_RG_CDTX_L2N_HSTX_RES_MASK GENMASK(14, 10) > +#define STF_DPHY_RG_CDTX_L2P_HSTX_RES_SHIFT 0xfU > +#define STF_DPHY_RG_CDTX_L2P_HSTX_RES_MASK GENMASK(19, 15) > +#define STF_DPHY_RG_CDTX_L3N_HSTX_RES_SHIFT 0x14U > +#define STF_DPHY_RG_CDTX_L3N_HSTX_RES_MASK GENMASK(24, 20) > +#define STF_DPHY_RG_CDTX_L3P_HSTX_RES_SHIFT 0x19U > +#define STF_DPHY_RG_CDTX_L3P_HSTX_RES_MASK GENMASK(29, 25) can you get rid of the shift defines. Please use FEILD_PREP and FIELD_GET which uses the bitmasks you have defined about (you can drop _MASK from above) > + > +#define STF_DPHY_RG_CDTX_L4N_HSTX_RES_SHIFT 0x0U > +#define STF_DPHY_RG_CDTX_L4N_HSTX_RES_MASK GENMASK(4, 0) > +#define STF_DPHY_RG_CDTX_L4P_HSTX_RES_SHIFT 0x5U > +#define STF_DPHY_RG_CDTX_L4P_HSTX_RES_MASK GENMASK(9, 5) > +#define STF_DPHY_RG_CDTX_PLL_FBK_FRA_SHIFT 0x0U > +#define STF_DPHY_RG_CDTX_PLL_FBK_FRA_MASK GENMASK(23, 0) > + > +#define STF_DPHY_RG_CDTX_PLL_FBK_INT_SHIFT 0x0U > +#define STF_DPHY_RG_CDTX_PLL_FBK_INT_MASK GENMASK(8, 0) > +#define STF_DPHY_RG_CDTX_PLL_FM_EN_SHIFT 0x9U > +#define STF_DPHY_RG_CDTX_PLL_FM_EN_MASK BIT(9) > +#define STF_DPHY_RG_CDTX_PLL_LDO_STB_X2_EN_SHIFT 0xaU > +#define STF_DPHY_RG_CDTX_PLL_LDO_STB_X2_EN_MASK BIT(10) > +#define STF_DPHY_RG_CDTX_PLL_PRE_DIV_SHIFT 0xbU > +#define STF_DPHY_RG_CDTX_PLL_PRE_DIV_MASK GENMASK(12, 11) > + > +#define STF_DPHY_RG_CDTX_PLL_SSC_EN_SHIFT 0x12U > +#define STF_DPHY_RG_CDTX_PLL_SSC_EN_MASK 0x40000U > + > +#define STF_DPHY_RG_CLANE_HS_CLK_POST_TIME_SHIFT 0x0U > +#define STF_DPHY_RG_CLANE_HS_CLK_POST_TIME_MASK GENMASK(7, 0) > +#define STF_DPHY_RG_CLANE_HS_CLK_PRE_TIME_SHIFT 0x8U > +#define STF_DPHY_RG_CLANE_HS_CLK_PRE_TIME_MASK GENMASK(15, 8) > +#define STF_DPHY_RG_CLANE_HS_PRE_TIME_SHIFT 0x10U > +#define STF_DPHY_RG_CLANE_HS_PRE_TIME_MASK GENMASK(23, 16) > +#define STF_DPHY_RG_CLANE_HS_TRAIL_TIME_SHIFT 0x18U > +#define STF_DPHY_RG_CLANE_HS_TRAIL_TIME_MASK GENMASK(31, 24) > + > +#define STF_DPHY_RG_CLANE_HS_ZERO_TIME_SHIFT 0x0U > +#define STF_DPHY_RG_CLANE_HS_ZERO_TIME_MASK GENMASK(7, 0) > +#define STF_DPHY_RG_DLANE_HS_PRE_TIME_SHIFT 0x8U > +#define STF_DPHY_RG_DLANE_HS_PRE_TIME_MASK GENMASK(15, 8) > +#define STF_DPHY_RG_DLANE_HS_TRAIL_TIME_SHIFT 0x10U > +#define STF_DPHY_RG_DLANE_HS_TRAIL_TIME_MASK GENMASK(23, 16) > +#define STF_DPHY_RG_DLANE_HS_ZERO_TIME_SHIFT 0x18U > +#define STF_DPHY_RG_DLANE_HS_ZERO_TIME_MASK GENMASK(31, 24) > + > +#define STF_DPHY_RG_EXTD_CYCLE_SEL_SHIFT 0x0U > +#define STF_DPHY_RG_EXTD_CYCLE_SEL_MASK GENMASK(2, 0) > +#define STF_DPHY_SCFG_C_HS_PRE_ZERO_TIME_SHIFT 0x0U > +#define STF_DPHY_SCFG_C_HS_PRE_ZERO_TIME_MASK GENMASK(31, 0) > + > +#define STF_DPHY_SCFG_DSI_TXREADY_ESC_SEL_SHIFT 0x1U > +#define STF_DPHY_SCFG_DSI_TXREADY_ESC_SEL_MASK GENMASK(2, 1) > +#define STF_DPHY_SCFG_PPI_C_READY_SEL_SHIFT 0x3U > +#define STF_DPHY_SCFG_PPI_C_READY_SEL_MASK GENMASK(4, 3) > + > +#define STF_DPHY_REFCLK_IN_SEL_SHIFT 0x1aU > +#define STF_DPHY_REFCLK_IN_SEL_MASK GENMASK(28, 26) > +#define STF_DPHY_RESETB_SHIFT 0x1dU > +#define STF_DPHY_RESETB_MASK BIT(29) > + > +#define STF_DPHY_REFCLK_12M 1 > +#define STF_DPHY_BITRATE_ALIGN 10000000 > + > +#define STF_MAP_LANES_NUM 5 > + > +#define STF_DPHY_LSHIFT_16(x) ((x) << 16) > +#define STF_DPHY_LSHIFT_8(x) ((x) << 8) these two should be dropped > + > +struct m31_dphy_config { > + int ref_clk; why is this signed? > + unsigned long bitrate; > + u32 pll_prev_div; > + u32 pll_fbk_int; > + u32 pll_fbk_fra; > + u32 extd_cycle_sel; > + u32 dlane_hs_pre_time; > + u32 dlane_hs_zero_time; > + u32 dlane_hs_trail_time; > + u32 clane_hs_pre_time; > + u32 clane_hs_zero_time; > + u32 clane_hs_trail_time; > + u32 clane_hs_clk_pre_time; > + u32 clane_hs_clk_post_time; > +}; > + > +static const struct m31_dphy_config m31_dphy_configs[] = { > + {12000000, 160000000, 0x0, 0x6a, > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > + 0x3, 0xa, 0x17, 0x11, 0x5, 0x2b, 0xd, 0x7, 0x3d}, you can add this in a single line, that would be more readable... > + {12000000, 170000000, 0x0, 0x71, > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > + 0x3, 0xb, 0x18, 0x11, 0x5, 0x2e, 0xd, 0x7, 0x3d}, > + {12000000, 180000000, 0x0, 0x78, > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, > + 0x3, 0xb, 0x19, 0x12, 0x6, 0x30, 0xe, 0x7, 0x3e}, > + {12000000, 190000000, 0x0, 0x7e, > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > + 0x3, 0xc, 0x1a, 0x12, 0x6, 0x33, 0xe, 0x7, 0x3e}, > + {12000000, 200000000, 0x0, 0x85, > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > + 0x3, 0xc, 0x1b, 0x13, 0x7, 0x35, 0xf, 0x7, 0x3f}, > + {12000000, 320000000, 0x0, 0x6a, > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > + 0x2, 0x8, 0x14, 0xf, 0x5, 0x2b, 0xd, 0x3, 0x23}, > + {12000000, 330000000, 0x0, 0x6e, > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, > + 0x2, 0x8, 0x15, 0xf, 0x5, 0x2d, 0xd, 0x3, 0x23}, > + {12000000, 340000000, 0x0, 0x71, > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > + 0x2, 0x9, 0x15, 0xf, 0x5, 0x2e, 0xd, 0x3, 0x23}, > + {12000000, 350000000, 0x0, 0x74, > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > + 0x2, 0x9, 0x15, 0x10, 0x6, 0x2f, 0xe, 0x3, 0x24}, > + {12000000, 360000000, 0x0, 0x78, > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, > + 0x2, 0x9, 0x16, 0x10, 0x6, 0x30, 0xe, 0x3, 0x24}, > + {12000000, 370000000, 0x0, 0x7b, > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > + 0x2, 0x9, 0x17, 0x10, 0x6, 0x32, 0xe, 0x3, 0x24}, > + {12000000, 380000000, 0x0, 0x7e, > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > + 0x2, 0xa, 0x17, 0x10, 0x6, 0x33, 0xe, 0x3, 0x24}, > + {12000000, 390000000, 0x0, 0x82, > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, 0x2, > + 0xa, 0x17, 0x11, 0x6, 0x35, 0xf, 0x3, 0x25}, > + {12000000, 400000000, 0x0, 0x85, > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > + 0x2, 0xa, 0x18, 0x11, 0x7, 0x35, 0xf, 0x3, 0x25}, > + {12000000, 410000000, 0x0, 0x88, > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > + 0x2, 0xa, 0x19, 0x11, 0x7, 0x37, 0xf, 0x3, 0x25}, > + {12000000, 420000000, 0x0, 0x8c, > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, > + 0x2, 0xa, 0x19, 0x12, 0x7, 0x38, 0x10, 0x3, 0x26}, > + {12000000, 430000000, 0x0, 0x8f, > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > + 0x2, 0xb, 0x19, 0x12, 0x7, 0x39, 0x10, 0x3, 0x26}, > + {12000000, 440000000, 0x0, 0x92, > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > + 0x2, 0xb, 0x1a, 0x12, 0x7, 0x3b, 0x10, 0x3, 0x26}, > + {12000000, 450000000, 0x0, 0x96, > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, > + 0x2, 0xb, 0x1b, 0x12, 0x8, 0x3c, 0x10, 0x3, 0x26}, > + {12000000, 460000000, 0x0, 0x99, > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > + 0x2, 0xb, 0x1b, 0x13, 0x8, 0x3d, 0x11, 0x3, 0x27}, > + {12000000, 470000000, 0x0, 0x9c, > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > + 0x2, 0xc, 0x1b, 0x13, 0x8, 0x3e, 0x11, 0x3, 0x27}, > + {12000000, 480000000, 0x0, 0xa0, > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, > + 0x2, 0xc, 0x1c, 0x13, 0x8, 0x40, 0x11, 0x3, 0x27}, > + {12000000, 490000000, 0x0, 0xa3, > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > + 0x2, 0xc, 0x1d, 0x14, 0x8, 0x42, 0x12, 0x3, 0x28}, > + {12000000, 500000000, 0x0, 0xa6, > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > + 0x2, 0xc, 0x1d, 0x14, 0x9, 0x42, 0x12, 0x3, 0x28}, > + {12000000, 510000000, 0x0, 0xaa, > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, > + 0x2, 0xc, 0x1e, 0x14, 0x9, 0x44, 0x12, 0x3, 0x28}, > + {12000000, 520000000, 0x0, 0xad, > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > + 0x2, 0xd, 0x1e, 0x15, 0x9, 0x45, 0x13, 0x3, 0x29}, > + {12000000, 530000000, 0x0, 0xb0, > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > + 0x2, 0xd, 0x1e, 0x15, 0x9, 0x47, 0x13, 0x3, 0x29}, > + {12000000, 540000000, 0x0, 0xb4, > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, > + 0x2, 0xd, 0x1f, 0x15, 0x9, 0x48, 0x13, 0x3, 0x29}, > + {12000000, 550000000, 0x0, 0xb7, > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > + 0x2, 0xd, 0x20, 0x16, 0x9, 0x4a, 0x14, 0x3, 0x2a}, > + {12000000, 560000000, 0x0, 0xba, > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > + 0x2, 0xe, 0x20, 0x16, 0xa, 0x4a, 0x14, 0x3, 0x2a}, > + {12000000, 570000000, 0x0, 0xbe, > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, > + 0x2, 0xe, 0x20, 0x16, 0xa, 0x4c, 0x14, 0x3, 0x2a}, > + {12000000, 580000000, 0x0, 0xc1, > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > + 0x2, 0xe, 0x21, 0x16, 0xa, 0x4d, 0x14, 0x3, 0x2a}, > + {12000000, 590000000, 0x0, 0xc4, > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > + 0x2, 0xe, 0x22, 0x17, 0xa, 0x4f, 0x15, 0x3, 0x2b}, > + {12000000, 600000000, 0x0, 0xc8, > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, > + 0x2, 0xe, 0x23, 0x17, 0xa, 0x50, 0x15, 0x3, 0x2b}, > + {12000000, 610000000, 0x0, 0xcb, > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > + 0x2, 0xf, 0x22, 0x17, 0xb, 0x50, 0x15, 0x3, 0x2b}, > + {12000000, 620000000, 0x0, 0xce, > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > + 0x2, 0xf, 0x23, 0x18, 0xb, 0x52, 0x16, 0x3, 0x2c}, > + {12000000, 630000000, 0x0, 0x69, > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, > + 0x1, 0x7, 0x12, 0xd, 0x5, 0x2a, 0xc, 0x1, 0x15}, > + {12000000, 640000000, 0x0, 0x6a, > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > + 0x1, 0x7, 0x13, 0xe, 0x5, 0x2b, 0xd, 0x1, 0x16}, > + {12000000, 650000000, 0x0, 0x6c, > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > + 0x1, 0x7, 0x13, 0xe, 0x5, 0x2c, 0xd, 0x1, 0x16}, > + {12000000, 660000000, 0x0, 0x6e, > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, > + 0x1, 0x7, 0x13, 0xe, 0x5, 0x2d, 0xd, 0x1, 0x16}, > + {12000000, 670000000, 0x0, 0x6f, > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > + 0x1, 0x8, 0x13, 0xe, 0x5, 0x2d, 0xd, 0x1, 0x16}, > + {12000000, 680000000, 0x0, 0x71, > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > + 0x1, 0x8, 0x13, 0xe, 0x5, 0x2e, 0xd, 0x1, 0x16}, > + {12000000, 690000000, 0x0, 0x73, > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, > + 0x1, 0x8, 0x14, 0xe, 0x6, 0x2e, 0xd, 0x1, 0x16}, > + {12000000, 700000000, 0x0, 0x74, > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > + 0x1, 0x8, 0x14, 0xf, 0x6, 0x2f, 0xe, 0x1, 0x16}, > + {12000000, 710000000, 0x0, 0x76, > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > + 0x1, 0x8, 0x14, 0xf, 0x6, 0x2f, 0xe, 0x1, 0x17}, > + {12000000, 720000000, 0x0, 0x78, > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, > + 0x1, 0x8, 0x15, 0xf, 0x6, 0x30, 0xe, 0x1, 0x17}, > + {12000000, 730000000, 0x0, 0x79, > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > + 0x1, 0x8, 0x15, 0xf, 0x6, 0x31, 0xe, 0x1, 0x17}, > + {12000000, 740000000, 0x0, 0x7b, > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > + 0x1, 0x8, 0x15, 0xf, 0x6, 0x32, 0xe, 0x1, 0x17}, > + {12000000, 750000000, 0x0, 0x7d, > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, > + 0x1, 0x8, 0x16, 0xf, 0x6, 0x32, 0xe, 0x1, 0x17}, > + {12000000, 760000000, 0x0, 0x7e, > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > + 0x1, 0x9, 0x15, 0xf, 0x6, 0x33, 0xe, 0x1, 0x17}, > + {12000000, 770000000, 0x0, 0x80, > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > + 0x1, 0x9, 0x15, 0x10, 0x6, 0x34, 0xf, 0x1, 0x18}, > + {12000000, 780000000, 0x0, 0x82, > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, > + 0x1, 0x9, 0x16, 0x10, 0x6, 0x35, 0xf, 0x1, 0x18,}, > + {12000000, 790000000, 0x0, 0x83, > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > + 0x1, 0x9, 0x16, 0x10, 0x7, 0x34, 0xf, 0x1, 0x18}, > + {12000000, 800000000, 0x0, 0x85, > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > + 0x1, 0x9, 0x17, 0x10, 0x7, 0x35, 0xf, 0x1, 0x18}, > + {12000000, 810000000, 0x0, 0x87, > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, > + 0x1, 0x9, 0x17, 0x10, 0x7, 0x36, 0xf, 0x1, 0x18}, > + {12000000, 820000000, 0x0, 0x88, > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > + 0x1, 0x9, 0x17, 0x10, 0x7, 0x37, 0xf, 0x1, 0x18}, > + {12000000, 830000000, 0x0, 0x8a, > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > + 0x1, 0x9, 0x18, 0x10, 0x7, 0x37, 0xf, 0x1, 0x18}, > + {12000000, 840000000, 0x0, 0x8c, > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, > + 0x1, 0x9, 0x18, 0x11, 0x7, 0x38, 0x10, 0x1, 0x19}, > + {12000000, 850000000, 0x0, 0x8d, > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > + 0x1, 0xa, 0x17, 0x11, 0x7, 0x39, 0x10, 0x1, 0x19}, > + {12000000, 860000000, 0x0, 0x8f, > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > + 0x1, 0xa, 0x18, 0x11, 0x7, 0x39, 0x10, 0x1, 0x19}, > + {12000000, 870000000, 0x0, 0x91, > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, > + 0x1, 0xa, 0x18, 0x11, 0x7, 0x3a, 0x10, 0x1, 0x19}, > + {12000000, 880000000, 0x0, 0x92, > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > + 0x1, 0xa, 0x18, 0x11, 0x7, 0x3b, 0x10, 0x1, 0x19}, > + {12000000, 890000000, 0x0, 0x94, > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > + 0x1, 0xa, 0x19, 0x11, 0x7, 0x3c, 0x10, 0x1, 0x19}, > + {12000000, 900000000, 0x0, 0x96, > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, > + 0x1, 0xa, 0x19, 0x12, 0x8, 0x3c, 0x10, 0x1, 0x19}, > + {12000000, 910000000, 0x0, 0x97, > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > + 0x1, 0xa, 0x19, 0x12, 0x8, 0x3c, 0x11, 0x1, 0x1a}, > + {12000000, 920000000, 0x0, 0x99, > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > + 0x1, 0xa, 0x1a, 0x12, 0x8, 0x3d, 0x11, 0x1, 0x1a}, > + {12000000, 930000000, 0x0, 0x9b, > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, > + 0x1, 0xa, 0x1a, 0x12, 0x8, 0x3e, 0x11, 0x1, 0x1a}, > + {12000000, 940000000, 0x0, 0x9c, > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > + 0x1, 0xb, 0x1a, 0x12, 0x8, 0x3e, 0x11, 0x1, 0x1a}, > + {12000000, 950000000, 0x0, 0x9e, > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > + 0x1, 0xb, 0x1a, 0x12, 0x8, 0x3f, 0x11, 0x1, 0x1a}, > + {12000000, 960000000, 0x0, 0xa0, > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, > + 0x1, 0xb, 0x1a, 0x12, 0x8, 0x40, 0x11, 0x1, 0x1a}, > + {12000000, 970000000, 0x0, 0xa1, > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > + 0x1, 0xb, 0x1b, 0x13, 0x8, 0x41, 0x12, 0x1, 0x1b}, > + {12000000, 980000000, 0x0, 0xa3, > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > + 0x1, 0xb, 0x1b, 0x13, 0x8, 0x42, 0x12, 0x1, 0x1b}, > + {12000000, 990000000, 0x0, 0xa5, > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, > + 0x1, 0xb, 0x1b, 0x13, 0x8, 0x42, 0x12, 0x1, 0x1b}, > + {12000000, 1000000000, 0x0, 0xa6, > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > + 0x1, 0xb, 0x1c, 0x13, 0x9, 0x42, 0x12, 0x1, 0x1b}, > +}; > + > +struct stf_dphy_info { > + /** > + * @maps: > + * > + * Physical lanes and logic lanes mapping table. > + * > + * The default order is: > + * [data lane 0, data lane 1, data lane 2, date lane 3, clk lane] > + */ > + u8 maps[STF_MAP_LANES_NUM]; > +}; > + > +struct stf_dphy { > + struct device *dev; > + void __iomem *topsys; > + struct clk *txesc_clk; > + struct reset_control *sys_rst; > + > + struct phy_configure_opts_mipi_dphy config; > + > + struct phy *phy; > + const struct stf_dphy_info *info; > +}; > + > +static inline u32 stf_dphy_get_reg(void __iomem *io_addr, u32 addr, u32 shift, u32 mask) > +{ > + u32 tmp; > + > + tmp = readl(io_addr); > + tmp = (tmp & mask) >> shift; > + return tmp; > +} > + > +static inline void stf_dphy_set_reg(void __iomem *io_addr, u32 addr, u32 data, u32 shift, u32 mask) > +{ > + u32 tmp; > + > + tmp = readl(io_addr + addr); > + tmp &= ~mask; > + tmp |= (data << shift) & mask; > + writel(tmp, (io_addr + addr)); > +} > + > +static int is_pll_locked(struct stf_dphy *dphy) > +{ > + int tmp = stf_dphy_get_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(8), > + STF_DPHY_RGS_CDTX_PLL_UNLOCK_SHIFT, > + STF_DPHY_RGS_CDTX_PLL_UNLOCK_MASK); > + return !tmp; why inverted value? > +} > + > +static void stf_dphy_hw_reset(struct stf_dphy *dphy, int assert) > +{ > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(100), > + !assert, STF_DPHY_RESETB_SHIFT, STF_DPHY_RESETB_MASK); > + > + if (!assert) { > + while ((!is_pll_locked(dphy))) > + ; This is infinite, that is not acceptable. Please have a decent timeout for this... > + dev_err(dphy->dev, "MIPI dphy-tx # PLL Locked\n"); > + } > +} > + > +static int stf_dphy_configure(struct phy *phy, union phy_configure_opts *opts) > +{ > + struct stf_dphy *dphy = phy_get_drvdata(phy); > + const struct stf_dphy_info *info = dphy->info; > + u32 bitrate = opts->mipi_dphy.hs_clk_rate; > + const struct m31_dphy_config *p; > + unsigned long alignment; > + int i; > + > + bitrate = opts->mipi_dphy.hs_clk_rate; > + > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(8), 0x10, > + STF_DPHY_RG_CDTX_L0N_HSTX_RES_SHIFT, STF_DPHY_RG_CDTX_L0N_HSTX_RES_MASK); > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(12), 0x10, > + STF_DPHY_RG_CDTX_L0N_HSTX_RES_SHIFT, STF_DPHY_RG_CDTX_L0N_HSTX_RES_MASK); > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(12), 0x10, > + STF_DPHY_RG_CDTX_L2N_HSTX_RES_SHIFT, STF_DPHY_RG_CDTX_L2N_HSTX_RES_MASK); > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(12), 0x10, > + STF_DPHY_RG_CDTX_L3N_HSTX_RES_SHIFT, STF_DPHY_RG_CDTX_L3N_HSTX_RES_MASK); > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(16), 0x10, > + STF_DPHY_RG_CDTX_L4N_HSTX_RES_SHIFT, STF_DPHY_RG_CDTX_L4N_HSTX_RES_MASK); > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(8), 0x10, > + STF_DPHY_RG_CDTX_L0P_HSTX_RES_SHIFT, STF_DPHY_RG_CDTX_L0P_HSTX_RES_MASK); > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(12), 0x10, > + STF_DPHY_RG_CDTX_L1P_HSTX_RES_SHIFT, STF_DPHY_RG_CDTX_L1P_HSTX_RES_MASK); > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(12), 0x10, > + STF_DPHY_RG_CDTX_L2P_HSTX_RES_SHIFT, STF_DPHY_RG_CDTX_L2P_HSTX_RES_MASK); > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(12), 0x10, > + STF_DPHY_RG_CDTX_L3P_HSTX_RES_SHIFT, STF_DPHY_RG_CDTX_L3P_HSTX_RES_MASK); > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(16), 0x10, > + STF_DPHY_RG_CDTX_L4P_HSTX_RES_SHIFT, STF_DPHY_RG_CDTX_L4P_HSTX_RES_MASK); > + > + alignment = STF_DPHY_BITRATE_ALIGN; > + if (bitrate % alignment) > + bitrate += alignment - (bitrate % alignment); > + > + p = m31_dphy_configs; > + for (i = 0; i < ARRAY_SIZE(m31_dphy_configs); i++, p++) { > + if (p->bitrate == bitrate) { > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(100), > + STF_DPHY_REFCLK_12M, STF_DPHY_REFCLK_IN_SEL_SHIFT, > + STF_DPHY_REFCLK_IN_SEL_MASK); > + > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(0), > + STF_DPHY_AON_POWER_READY_N_ACTIVE, > + STF_DPHY_AON_POWER_READY_N_SHIFT, > + STF_DPHY_AON_POWER_READY_N_MASK); > + > + /*Lane setting*/ > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(0), info->maps[0], > + STF_DPHY_CFG_L0_SWAP_SEL_SHIFT, > + STF_DPHY_CFG_L0_SWAP_SEL_MASK); > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(0), info->maps[1], > + STF_DPHY_CFG_L1_SWAP_SEL_SHIFT, > + STF_DPHY_CFG_L1_SWAP_SEL_MASK); > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(0), info->maps[2], > + STF_DPHY_CFG_L2_SWAP_SEL_SHIFT, > + STF_DPHY_CFG_L2_SWAP_SEL_MASK); > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(0), info->maps[3], > + STF_DPHY_CFG_L3_SWAP_SEL_SHIFT, > + STF_DPHY_CFG_L3_SWAP_SEL_MASK); > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(0), info->maps[4], > + STF_DPHY_CFG_L4_SWAP_SEL_SHIFT, > + STF_DPHY_CFG_L4_SWAP_SEL_MASK); > + /*PLL setting*/ > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(28), 0x0, > + STF_DPHY_RG_CDTX_PLL_SSC_EN_SHIFT, > + STF_DPHY_RG_CDTX_PLL_SSC_EN_MASK); > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(24), 0x1, > + STF_DPHY_RG_CDTX_PLL_LDO_STB_X2_EN_SHIFT, > + STF_DPHY_RG_CDTX_PLL_LDO_STB_X2_EN_MASK); > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(24), 0x1, > + STF_DPHY_RG_CDTX_PLL_FM_EN_SHIFT, > + STF_DPHY_RG_CDTX_PLL_FM_EN_MASK); > + > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(24), > + p->pll_prev_div, STF_DPHY_RG_CDTX_PLL_PRE_DIV_SHIFT, > + STF_DPHY_RG_CDTX_PLL_PRE_DIV_MASK); > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(24), > + p->pll_fbk_int, STF_DPHY_RG_CDTX_PLL_FBK_INT_SHIFT, > + STF_DPHY_RG_CDTX_PLL_FBK_INT_MASK); > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(20), > + p->pll_fbk_fra, STF_DPHY_RG_CDTX_PLL_FBK_FRA_SHIFT, > + STF_DPHY_RG_CDTX_PLL_FBK_FRA_MASK); > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(40), > + p->extd_cycle_sel, STF_DPHY_RG_EXTD_CYCLE_SEL_SHIFT, > + STF_DPHY_RG_EXTD_CYCLE_SEL_MASK); > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(36), > + p->dlane_hs_pre_time, > + STF_DPHY_RG_DLANE_HS_PRE_TIME_SHIFT, > + STF_DPHY_RG_DLANE_HS_PRE_TIME_MASK); > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(36), > + p->dlane_hs_pre_time, > + STF_DPHY_RG_DLANE_HS_PRE_TIME_SHIFT, > + STF_DPHY_RG_DLANE_HS_PRE_TIME_MASK); > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(36), > + p->dlane_hs_zero_time, > + STF_DPHY_RG_DLANE_HS_ZERO_TIME_SHIFT, > + STF_DPHY_RG_DLANE_HS_ZERO_TIME_MASK); > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(36), > + p->dlane_hs_trail_time, > + STF_DPHY_RG_DLANE_HS_TRAIL_TIME_SHIFT, > + STF_DPHY_RG_DLANE_HS_TRAIL_TIME_MASK); > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(32), > + p->clane_hs_pre_time, > + STF_DPHY_RG_CLANE_HS_PRE_TIME_SHIFT, > + STF_DPHY_RG_CLANE_HS_PRE_TIME_MASK); > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(36), > + p->clane_hs_zero_time, > + STF_DPHY_RG_CLANE_HS_ZERO_TIME_SHIFT, > + STF_DPHY_RG_CLANE_HS_ZERO_TIME_MASK); > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(32), > + p->clane_hs_trail_time, > + STF_DPHY_RG_CLANE_HS_TRAIL_TIME_SHIFT, > + STF_DPHY_RG_CLANE_HS_TRAIL_TIME_MASK); > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(32), > + p->clane_hs_clk_pre_time, > + STF_DPHY_RG_CLANE_HS_CLK_PRE_TIME_SHIFT, > + STF_DPHY_RG_CLANE_HS_CLK_PRE_TIME_MASK); > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(32), > + p->clane_hs_clk_post_time, > + STF_DPHY_RG_CLANE_HS_CLK_POST_TIME_SHIFT, > + STF_DPHY_RG_CLANE_HS_CLK_POST_TIME_MASK); > + > + break; > + } > + } > + > + return 0; this is the only return. It will always return success, consider making this return void > +} > + > +static int stf_dphy_init(struct phy *phy) > +{ > + struct stf_dphy *dphy = phy_get_drvdata(phy); > + int ret; > + > + stf_dphy_hw_reset(dphy, 0); > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(48), 0, > + STF_DPHY_SCFG_PPI_C_READY_SEL_SHIFT, STF_DPHY_SCFG_PPI_C_READY_SEL_MASK); > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(48), 0, > + STF_DPHY_SCFG_DSI_TXREADY_ESC_SEL_SHIFT, > + STF_DPHY_SCFG_DSI_TXREADY_ESC_SEL_MASK); > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(44), 0x30, > + STF_DPHY_SCFG_C_HS_PRE_ZERO_TIME_SHIFT, > + STF_DPHY_SCFG_C_HS_PRE_ZERO_TIME_MASK); > + > + ret = clk_prepare_enable(dphy->txesc_clk); > + if (ret) { > + dev_err(dphy->dev, "Failed to prepare/enable txesc_clk\n"); > + return ret; > + } > + > + ret = reset_control_deassert(dphy->sys_rst); > + if (ret) { > + dev_err(dphy->dev, "Failed to deassert sys_rst\n"); > + return ret; > + } > + > + return 0; > +} > + > +static int stf_dphy_exit(struct phy *phy) > +{ > + struct stf_dphy *dphy = phy_get_drvdata(phy); > + int ret; > + > + ret = reset_control_assert(dphy->sys_rst); > + if (ret) { > + dev_err(dphy->dev, "Failed to assert sys_rst\n"); > + return ret; > + } > + > + clk_disable_unprepare(dphy->txesc_clk); > + > + stf_dphy_hw_reset(dphy, 1); > + > + return 0; > +} > + > +static int stf_dphy_power_on(struct phy *phy) > +{ > + struct stf_dphy *dphy = phy_get_drvdata(phy); > + > + return pm_runtime_resume_and_get(dphy->dev); > +} > + > +static int stf_dphy_validate(struct phy *phy, enum phy_mode mode, int submode, > + union phy_configure_opts *opts) > +{ > + if (mode != PHY_MODE_MIPI_DPHY) > + return -EINVAL; > + > + return 0; > +} > + > +static int stf_dphy_power_off(struct phy *phy) > +{ > + struct stf_dphy *dphy = phy_get_drvdata(phy); > + > + return pm_runtime_put_sync(dphy->dev); > +} > + > +static const struct phy_ops stf_dphy_ops = { > + .power_on = stf_dphy_power_on, > + .power_off = stf_dphy_power_off, > + .init = stf_dphy_init, > + .exit = stf_dphy_exit, > + .configure = stf_dphy_configure, > + .validate = stf_dphy_validate, > + .owner = THIS_MODULE, > +}; > + > +static int stf_dphy_probe(struct platform_device *pdev) > +{ > + struct phy_provider *phy_provider; > + struct stf_dphy *dphy; > + > + dphy = devm_kzalloc(&pdev->dev, sizeof(*dphy), GFP_KERNEL); > + if (!dphy) > + return -ENOMEM; > + > + dphy->info = of_device_get_match_data(&pdev->dev); > + > + dphy->dev = &pdev->dev; > + dev_set_drvdata(&pdev->dev, dphy); > + > + dphy->topsys = devm_platform_ioremap_resource(pdev, 0); > + if (IS_ERR(dphy->topsys)) > + return PTR_ERR(dphy->topsys); > + > + pm_runtime_enable(&pdev->dev); > + > + dphy->txesc_clk = devm_clk_get(&pdev->dev, "txesc"); > + if (IS_ERR(dphy->txesc_clk)) > + return dev_err_probe(&pdev->dev, PTR_ERR(dphy->txesc_clk), > + "Failed to get txesc clock\n"); > + > + dphy->sys_rst = devm_reset_control_get_exclusive(&pdev->dev, "sys"); > + if (IS_ERR(dphy->sys_rst)) > + return dev_err_probe(&pdev->dev, PTR_ERR(dphy->sys_rst), > + "Failed to get sys reset\n"); > + > + dphy->phy = devm_phy_create(&pdev->dev, NULL, &stf_dphy_ops); > + if (IS_ERR(dphy->phy)) > + return dev_err_probe(&pdev->dev, PTR_ERR(dphy->phy), > + "Failed to create phy\n"); > + > + phy_set_drvdata(dphy->phy, dphy); > + > + phy_provider = devm_of_phy_provider_register(&pdev->dev, of_phy_simple_xlate); > + if (IS_ERR(phy_provider)) > + return dev_err_probe(&pdev->dev, PTR_ERR(phy_provider), > + "Failed to register phy\n"); > + > + return 0; > +} > + > +static const struct stf_dphy_info starfive_dphy_info = { > + .maps = {0, 1, 2, 3, 4}, > +}; > + > +static const struct of_device_id stf_dphy_dt_ids[] = { > + { > + .compatible = "starfive,jh7110-dphy-tx", > + .data = &starfive_dphy_info, > + }, > + { /* sentinel */ }, > +}; > +MODULE_DEVICE_TABLE(of, stf_dphy_dt_ids); > + > +static struct platform_driver stf_dphy_driver = { > + .driver = { > + .name = "starfive-dphy-tx", > + .of_match_table = stf_dphy_dt_ids, > + }, > + .probe = stf_dphy_probe, > +}; > +module_platform_driver(stf_dphy_driver); > + > +MODULE_AUTHOR("Keith Zhao <keith.zhao@starfivetech.com>"); > +MODULE_AUTHOR("Shengyang Chen <shengyang.chen@starfivetech.com>"); > +MODULE_DESCRIPTION("StarFive JH7110 DPHY TX driver"); > +MODULE_LICENSE("GPL"); > -- > 2.17.1 > > > -- > linux-phy mailing list > linux-phy@lists.infradead.org > https://lists.infradead.org/mailman/listinfo/linux-phy -- ~Vinod ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH v4 2/2] phy: starfive: Add mipi dphy tx support 2024-04-05 16:31 ` Vinod Koul @ 2024-04-09 6:30 ` Shengyang Chen 0 siblings, 0 replies; 6+ messages in thread From: Shengyang Chen @ 2024-04-09 6:30 UTC (permalink / raw) To: Vinod Koul Cc: devicetree@vger.kernel.org, linux-phy@lists.infradead.org, kishon@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, p.zabel@pengutronix.de, Minda Chen, Changhuang Liang, rogerq@kernel.org, geert+renesas@glider.be, Keith Zhao, linux-kernel@vger.kernel.org Hi, Vinod Thanks for review and comment. > -----Original Message----- > From: Vinod Koul <vkoul@kernel.org> > Sent: 2024年4月6日 0:32 > To: Shengyang Chen <shengyang.chen@starfivetech.com> > Cc: devicetree@vger.kernel.org; linux-phy@lists.infradead.org; > kishon@kernel.org; robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; > conor+dt@kernel.org; p.zabel@pengutronix.de; Minda Chen > <minda.chen@starfivetech.com>; Changhuang Liang > <changhuang.liang@starfivetech.com>; rogerq@kernel.org; > geert+renesas@glider.be; Keith Zhao <keith.zhao@starfivetech.com>; > linux-kernel@vger.kernel.org > Subject: Re: [PATCH v4 2/2] phy: starfive: Add mipi dphy tx support > > On 01-03-24, 09:24, Shengyang Chen wrote: > > Add mipi dphy tx support for the StarFive JH7110 SoC. > > It is a module which is used to receive data from DSI driver and > > transfer data to DSI interface like mipi screen. > > > > Signed-off-by: Shengyang Chen <shengyang.chen@starfivetech.com> > > Reviewed-by: Changhuang Liang <changhuang.liang@starfivetech.com> > > --- > > MAINTAINERS | 7 + > > drivers/phy/starfive/Kconfig | 10 + > > drivers/phy/starfive/Makefile | 1 + > > drivers/phy/starfive/phy-jh7110-dphy-tx.c | 702 > > ++++++++++++++++++++++ > > 4 files changed, 720 insertions(+) > > create mode 100644 drivers/phy/starfive/phy-jh7110-dphy-tx.c > > > > diff --git a/MAINTAINERS b/MAINTAINERS index > > ddbe6c82610f..13219c6504a9 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -20871,6 +20871,13 @@ S: Supported > > F: Documentation/devicetree/bindings/phy/starfive,jh7110-dphy-rx.yaml > > F: drivers/phy/starfive/phy-jh7110-dphy-rx.c > > > > +STARFIVE JH7110 DPHY TX DRIVER > > +M: Keith Zhao <keith.zhao@starfivetech.com> > > +M: Shengyang Chen <shengyang.chen@starfivetech.com> > > +S: Supported > > +F: Documentation/devicetree/bindings/phy/starfive,jh7110-dphy-tx.yaml > > +F: drivers/phy/starfive/phy-jh7110-dphy-tx.c > > + > > STARFIVE JH7110 MMC/SD/SDIO DRIVER > > M: William Qiu <william.qiu@starfivetech.com> > > S: Supported > > diff --git a/drivers/phy/starfive/Kconfig > > b/drivers/phy/starfive/Kconfig index 9508e2143011..d0cdd7cb4a13 100644 > > --- a/drivers/phy/starfive/Kconfig > > +++ b/drivers/phy/starfive/Kconfig > > @@ -15,6 +15,16 @@ config PHY_STARFIVE_JH7110_DPHY_RX > > system. If M is selected, the module will be called > > phy-jh7110-dphy-rx.ko. > > > > +config PHY_STARFIVE_JH7110_DPHY_TX > > + tristate "StarFive JH7110 D-PHY TX Support" > > + depends on HAS_IOMEM > > + select GENERIC_PHY > > + select GENERIC_PHY_MIPI_DPHY > > + help > > + Choose this option if you have a StarFive D-PHY TX in your > > + system. If M is selected, the module will be called > > + phy-jh7110-dphy-tx.ko. > > + > > config PHY_STARFIVE_JH7110_PCIE > > tristate "Starfive JH7110 PCIE 2.0/USB 3.0 PHY support" > > depends on HAS_IOMEM > > diff --git a/drivers/phy/starfive/Makefile > > b/drivers/phy/starfive/Makefile index b391018b7c47..eedc4a6fec15 > > 100644 > > --- a/drivers/phy/starfive/Makefile > > +++ b/drivers/phy/starfive/Makefile > > @@ -1,4 +1,5 @@ > > # SPDX-License-Identifier: GPL-2.0 > > obj-$(CONFIG_PHY_STARFIVE_JH7110_DPHY_RX) += phy-jh7110-dphy-rx.o > > +obj-$(CONFIG_PHY_STARFIVE_JH7110_DPHY_TX) += phy-jh7110-dphy-tx.o > > obj-$(CONFIG_PHY_STARFIVE_JH7110_PCIE) += phy-jh7110-pcie.o > > obj-$(CONFIG_PHY_STARFIVE_JH7110_USB) += phy-jh7110-usb.o > > diff --git a/drivers/phy/starfive/phy-jh7110-dphy-tx.c > > b/drivers/phy/starfive/phy-jh7110-dphy-tx.c > > new file mode 100644 > > index 000000000000..df30cd424ba7 > > --- /dev/null > > +++ b/drivers/phy/starfive/phy-jh7110-dphy-tx.c > > @@ -0,0 +1,702 @@ > > +// SPDX-License-Identifier: GPL-2.0+ > > +/* > > + * DPHY TX driver for the StarFive JH7110 SoC > > + * > > + * Copyright (C) 2023 StarFive Technology Co., Ltd. > > + * Author: Keith Zhao <keith.zhao@starfivetech.com> > > + * Author: Shengyang Chen <shengyang.chen@starfivetech.com> */ > > + > > +#include <linux/clk.h> > > +#include <linux/io.h> > > +#include <linux/mfd/syscon.h> > > +#include <linux/module.h> > > +#include <linux/of.h> > > +#include <linux/of_device.h> > > +#include <linux/phy/phy.h> > > +#include <linux/phy/phy-mipi-dphy.h> > > +#include <linux/platform_device.h> > > +#include <linux/pm_runtime.h> > > +#include <linux/reset.h> > > + > > +#define STF_DPHY_APBIFSAIF_SYSCFG(x) (x) > > + > > +#define STF_DPHY_AON_POWER_READY_N_ACTIVE 0 > > +#define STF_DPHY_AON_POWER_READY_N_SHIFT 0x0U > > +#define STF_DPHY_AON_POWER_READY_N_MASK BIT(0) > > +#define STF_DPHY_CFG_L0_SWAP_SEL_SHIFT 0xcU > > +#define STF_DPHY_CFG_L0_SWAP_SEL_MASK GENMASK(14, > 12) > > +#define STF_DPHY_CFG_L1_SWAP_SEL_SHIFT 0xfU > > +#define STF_DPHY_CFG_L1_SWAP_SEL_MASK GENMASK(17, > 15) > > +#define STF_DPHY_CFG_L2_SWAP_SEL_SHIFT 0x12U > > +#define STF_DPHY_CFG_L2_SWAP_SEL_MASK GENMASK(20, > 18) > > +#define STF_DPHY_CFG_L3_SWAP_SEL_SHIFT 0x15U > > +#define STF_DPHY_CFG_L3_SWAP_SEL_MASK GENMASK(23, > 21) > > +#define STF_DPHY_CFG_L4_SWAP_SEL_SHIFT 0x18U > > +#define STF_DPHY_CFG_L4_SWAP_SEL_MASK GENMASK(26, > 24) > > +#define STF_DPHY_RGS_CDTX_PLL_UNLOCK_SHIFT 0x12U > > +#define STF_DPHY_RGS_CDTX_PLL_UNLOCK_MASK BIT(18) > > +#define STF_DPHY_RG_CDTX_L0N_HSTX_RES_SHIFT 0x13U > > +#define STF_DPHY_RG_CDTX_L0N_HSTX_RES_MASK GENMASK(23, > 19) > > +#define STF_DPHY_RG_CDTX_L0P_HSTX_RES_SHIFT 0x18U > > +#define STF_DPHY_RG_CDTX_L0P_HSTX_RES_MASK GENMASK(28, > 24) > > + > > +#define STF_DPHY_RG_CDTX_L1P_HSTX_RES_SHIFT 0x5U > > +#define STF_DPHY_RG_CDTX_L1P_HSTX_RES_MASK GENMASK(9, > 5) > > +#define STF_DPHY_RG_CDTX_L2N_HSTX_RES_SHIFT 0xaU > > +#define STF_DPHY_RG_CDTX_L2N_HSTX_RES_MASK GENMASK(14, > 10) > > +#define STF_DPHY_RG_CDTX_L2P_HSTX_RES_SHIFT 0xfU > > +#define STF_DPHY_RG_CDTX_L2P_HSTX_RES_MASK GENMASK(19, > 15) > > +#define STF_DPHY_RG_CDTX_L3N_HSTX_RES_SHIFT 0x14U > > +#define STF_DPHY_RG_CDTX_L3N_HSTX_RES_MASK GENMASK(24, > 20) > > +#define STF_DPHY_RG_CDTX_L3P_HSTX_RES_SHIFT 0x19U > > +#define STF_DPHY_RG_CDTX_L3P_HSTX_RES_MASK GENMASK(29, > 25) > > can you get rid of the shift defines. Please use FEILD_PREP and FIELD_GET which > uses the bitmasks you have defined about (you can drop _MASK from above) > ok, will follow up this issue. Will replace MASK with FIELD_PREP/FIELD_GET > > + > > +#define STF_DPHY_RG_CDTX_L4N_HSTX_RES_SHIFT 0x0U > > +#define STF_DPHY_RG_CDTX_L4N_HSTX_RES_MASK GENMASK(4, > 0) > > +#define STF_DPHY_RG_CDTX_L4P_HSTX_RES_SHIFT 0x5U > > +#define STF_DPHY_RG_CDTX_L4P_HSTX_RES_MASK GENMASK(9, > 5) > > +#define STF_DPHY_RG_CDTX_PLL_FBK_FRA_SHIFT 0x0U > > +#define STF_DPHY_RG_CDTX_PLL_FBK_FRA_MASK GENMASK(23, > 0) > > + > > +#define STF_DPHY_RG_CDTX_PLL_FBK_INT_SHIFT 0x0U > > +#define STF_DPHY_RG_CDTX_PLL_FBK_INT_MASK GENMASK(8, > 0) > > +#define STF_DPHY_RG_CDTX_PLL_FM_EN_SHIFT 0x9U > > +#define STF_DPHY_RG_CDTX_PLL_FM_EN_MASK BIT(9) > > +#define STF_DPHY_RG_CDTX_PLL_LDO_STB_X2_EN_SHIFT 0xaU > > +#define STF_DPHY_RG_CDTX_PLL_LDO_STB_X2_EN_MASK BIT(10) > > +#define STF_DPHY_RG_CDTX_PLL_PRE_DIV_SHIFT 0xbU > > +#define STF_DPHY_RG_CDTX_PLL_PRE_DIV_MASK GENMASK(12, > 11) > > + > > +#define STF_DPHY_RG_CDTX_PLL_SSC_EN_SHIFT 0x12U > > +#define STF_DPHY_RG_CDTX_PLL_SSC_EN_MASK 0x40000U > > + > > +#define STF_DPHY_RG_CLANE_HS_CLK_POST_TIME_SHIFT 0x0U > > +#define STF_DPHY_RG_CLANE_HS_CLK_POST_TIME_MASK GENMASK(7, > 0) > > +#define STF_DPHY_RG_CLANE_HS_CLK_PRE_TIME_SHIFT 0x8U > > +#define STF_DPHY_RG_CLANE_HS_CLK_PRE_TIME_MASK > GENMASK(15, 8) > > +#define STF_DPHY_RG_CLANE_HS_PRE_TIME_SHIFT 0x10U > > +#define STF_DPHY_RG_CLANE_HS_PRE_TIME_MASK GENMASK(23, > 16) > > +#define STF_DPHY_RG_CLANE_HS_TRAIL_TIME_SHIFT 0x18U > > +#define STF_DPHY_RG_CLANE_HS_TRAIL_TIME_MASK > GENMASK(31, 24) > > + > > +#define STF_DPHY_RG_CLANE_HS_ZERO_TIME_SHIFT 0x0U > > +#define STF_DPHY_RG_CLANE_HS_ZERO_TIME_MASK GENMASK(7, > 0) > > +#define STF_DPHY_RG_DLANE_HS_PRE_TIME_SHIFT 0x8U > > +#define STF_DPHY_RG_DLANE_HS_PRE_TIME_MASK GENMASK(15, > 8) > > +#define STF_DPHY_RG_DLANE_HS_TRAIL_TIME_SHIFT 0x10U > > +#define STF_DPHY_RG_DLANE_HS_TRAIL_TIME_MASK > GENMASK(23, 16) > > +#define STF_DPHY_RG_DLANE_HS_ZERO_TIME_SHIFT 0x18U > > +#define STF_DPHY_RG_DLANE_HS_ZERO_TIME_MASK > GENMASK(31, 24) > > + > > +#define STF_DPHY_RG_EXTD_CYCLE_SEL_SHIFT 0x0U > > +#define STF_DPHY_RG_EXTD_CYCLE_SEL_MASK GENMASK(2, 0) > > +#define STF_DPHY_SCFG_C_HS_PRE_ZERO_TIME_SHIFT 0x0U > > +#define STF_DPHY_SCFG_C_HS_PRE_ZERO_TIME_MASK > GENMASK(31, 0) > > + > > +#define STF_DPHY_SCFG_DSI_TXREADY_ESC_SEL_SHIFT 0x1U > > +#define STF_DPHY_SCFG_DSI_TXREADY_ESC_SEL_MASK > GENMASK(2, 1) > > +#define STF_DPHY_SCFG_PPI_C_READY_SEL_SHIFT 0x3U > > +#define STF_DPHY_SCFG_PPI_C_READY_SEL_MASK GENMASK(4, > 3) > > + > > +#define STF_DPHY_REFCLK_IN_SEL_SHIFT 0x1aU > > +#define STF_DPHY_REFCLK_IN_SEL_MASK GENMASK(28, 26) > > +#define STF_DPHY_RESETB_SHIFT 0x1dU > > +#define STF_DPHY_RESETB_MASK BIT(29) > > + > > +#define STF_DPHY_REFCLK_12M 1 > > +#define STF_DPHY_BITRATE_ALIGN 10000000 > > + > > +#define STF_MAP_LANES_NUM 5 > > + > > +#define STF_DPHY_LSHIFT_16(x) ((x) << 16) > > +#define STF_DPHY_LSHIFT_8(x) ((x) << 8) > > these two should be dropped > Ok, will drop in next version > > + > > +struct m31_dphy_config { > > + int ref_clk; > > why is this signed? > Ok, will drop in next version > > + unsigned long bitrate; > > + u32 pll_prev_div; > > + u32 pll_fbk_int; > > + u32 pll_fbk_fra; > > + u32 extd_cycle_sel; > > + u32 dlane_hs_pre_time; > > + u32 dlane_hs_zero_time; > > + u32 dlane_hs_trail_time; > > + u32 clane_hs_pre_time; > > + u32 clane_hs_zero_time; > > + u32 clane_hs_trail_time; > > + u32 clane_hs_clk_pre_time; > > + u32 clane_hs_clk_post_time; > > +}; > > + > > +static const struct m31_dphy_config m31_dphy_configs[] = { > > + {12000000, 160000000, 0x0, 0x6a, > > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > > + 0x3, 0xa, 0x17, 0x11, 0x5, 0x2b, 0xd, 0x7, 0x3d}, > > you can add this in a single line, that would be more readable... > ok, will follow up this issue. > > + {12000000, 170000000, 0x0, 0x71, > > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > > + 0x3, 0xb, 0x18, 0x11, 0x5, 0x2e, 0xd, 0x7, 0x3d}, > > + {12000000, 180000000, 0x0, 0x78, > > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, > > + 0x3, 0xb, 0x19, 0x12, 0x6, 0x30, 0xe, 0x7, 0x3e}, > > + {12000000, 190000000, 0x0, 0x7e, > > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > > + 0x3, 0xc, 0x1a, 0x12, 0x6, 0x33, 0xe, 0x7, 0x3e}, > > + {12000000, 200000000, 0x0, 0x85, > > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > > + 0x3, 0xc, 0x1b, 0x13, 0x7, 0x35, 0xf, 0x7, 0x3f}, > > + {12000000, 320000000, 0x0, 0x6a, > > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > > + 0x2, 0x8, 0x14, 0xf, 0x5, 0x2b, 0xd, 0x3, 0x23}, > > + {12000000, 330000000, 0x0, 0x6e, > > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, > > + 0x2, 0x8, 0x15, 0xf, 0x5, 0x2d, 0xd, 0x3, 0x23}, > > + {12000000, 340000000, 0x0, 0x71, > > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > > + 0x2, 0x9, 0x15, 0xf, 0x5, 0x2e, 0xd, 0x3, 0x23}, > > + {12000000, 350000000, 0x0, 0x74, > > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > > + 0x2, 0x9, 0x15, 0x10, 0x6, 0x2f, 0xe, 0x3, 0x24}, > > + {12000000, 360000000, 0x0, 0x78, > > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, > > + 0x2, 0x9, 0x16, 0x10, 0x6, 0x30, 0xe, 0x3, 0x24}, > > + {12000000, 370000000, 0x0, 0x7b, > > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > > + 0x2, 0x9, 0x17, 0x10, 0x6, 0x32, 0xe, 0x3, 0x24}, > > + {12000000, 380000000, 0x0, 0x7e, > > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > > + 0x2, 0xa, 0x17, 0x10, 0x6, 0x33, 0xe, 0x3, 0x24}, > > + {12000000, 390000000, 0x0, 0x82, > > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, 0x2, > > + 0xa, 0x17, 0x11, 0x6, 0x35, 0xf, 0x3, 0x25}, > > + {12000000, 400000000, 0x0, 0x85, > > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > > + 0x2, 0xa, 0x18, 0x11, 0x7, 0x35, 0xf, 0x3, 0x25}, > > + {12000000, 410000000, 0x0, 0x88, > > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > > + 0x2, 0xa, 0x19, 0x11, 0x7, 0x37, 0xf, 0x3, 0x25}, > > + {12000000, 420000000, 0x0, 0x8c, > > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, > > + 0x2, 0xa, 0x19, 0x12, 0x7, 0x38, 0x10, 0x3, 0x26}, > > + {12000000, 430000000, 0x0, 0x8f, > > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > > + 0x2, 0xb, 0x19, 0x12, 0x7, 0x39, 0x10, 0x3, 0x26}, > > + {12000000, 440000000, 0x0, 0x92, > > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > > + 0x2, 0xb, 0x1a, 0x12, 0x7, 0x3b, 0x10, 0x3, 0x26}, > > + {12000000, 450000000, 0x0, 0x96, > > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, > > + 0x2, 0xb, 0x1b, 0x12, 0x8, 0x3c, 0x10, 0x3, 0x26}, > > + {12000000, 460000000, 0x0, 0x99, > > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > > + 0x2, 0xb, 0x1b, 0x13, 0x8, 0x3d, 0x11, 0x3, 0x27}, > > + {12000000, 470000000, 0x0, 0x9c, > > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > > + 0x2, 0xc, 0x1b, 0x13, 0x8, 0x3e, 0x11, 0x3, 0x27}, > > + {12000000, 480000000, 0x0, 0xa0, > > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, > > + 0x2, 0xc, 0x1c, 0x13, 0x8, 0x40, 0x11, 0x3, 0x27}, > > + {12000000, 490000000, 0x0, 0xa3, > > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > > + 0x2, 0xc, 0x1d, 0x14, 0x8, 0x42, 0x12, 0x3, 0x28}, > > + {12000000, 500000000, 0x0, 0xa6, > > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > > + 0x2, 0xc, 0x1d, 0x14, 0x9, 0x42, 0x12, 0x3, 0x28}, > > + {12000000, 510000000, 0x0, 0xaa, > > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, > > + 0x2, 0xc, 0x1e, 0x14, 0x9, 0x44, 0x12, 0x3, 0x28}, > > + {12000000, 520000000, 0x0, 0xad, > > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > > + 0x2, 0xd, 0x1e, 0x15, 0x9, 0x45, 0x13, 0x3, 0x29}, > > + {12000000, 530000000, 0x0, 0xb0, > > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > > + 0x2, 0xd, 0x1e, 0x15, 0x9, 0x47, 0x13, 0x3, 0x29}, > > + {12000000, 540000000, 0x0, 0xb4, > > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, > > + 0x2, 0xd, 0x1f, 0x15, 0x9, 0x48, 0x13, 0x3, 0x29}, > > + {12000000, 550000000, 0x0, 0xb7, > > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > > + 0x2, 0xd, 0x20, 0x16, 0x9, 0x4a, 0x14, 0x3, 0x2a}, > > + {12000000, 560000000, 0x0, 0xba, > > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > > + 0x2, 0xe, 0x20, 0x16, 0xa, 0x4a, 0x14, 0x3, 0x2a}, > > + {12000000, 570000000, 0x0, 0xbe, > > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, > > + 0x2, 0xe, 0x20, 0x16, 0xa, 0x4c, 0x14, 0x3, 0x2a}, > > + {12000000, 580000000, 0x0, 0xc1, > > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > > + 0x2, 0xe, 0x21, 0x16, 0xa, 0x4d, 0x14, 0x3, 0x2a}, > > + {12000000, 590000000, 0x0, 0xc4, > > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > > + 0x2, 0xe, 0x22, 0x17, 0xa, 0x4f, 0x15, 0x3, 0x2b}, > > + {12000000, 600000000, 0x0, 0xc8, > > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, > > + 0x2, 0xe, 0x23, 0x17, 0xa, 0x50, 0x15, 0x3, 0x2b}, > > + {12000000, 610000000, 0x0, 0xcb, > > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > > + 0x2, 0xf, 0x22, 0x17, 0xb, 0x50, 0x15, 0x3, 0x2b}, > > + {12000000, 620000000, 0x0, 0xce, > > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > > + 0x2, 0xf, 0x23, 0x18, 0xb, 0x52, 0x16, 0x3, 0x2c}, > > + {12000000, 630000000, 0x0, 0x69, > > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, > > + 0x1, 0x7, 0x12, 0xd, 0x5, 0x2a, 0xc, 0x1, 0x15}, > > + {12000000, 640000000, 0x0, 0x6a, > > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > > + 0x1, 0x7, 0x13, 0xe, 0x5, 0x2b, 0xd, 0x1, 0x16}, > > + {12000000, 650000000, 0x0, 0x6c, > > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > > + 0x1, 0x7, 0x13, 0xe, 0x5, 0x2c, 0xd, 0x1, 0x16}, > > + {12000000, 660000000, 0x0, 0x6e, > > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, > > + 0x1, 0x7, 0x13, 0xe, 0x5, 0x2d, 0xd, 0x1, 0x16}, > > + {12000000, 670000000, 0x0, 0x6f, > > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > > + 0x1, 0x8, 0x13, 0xe, 0x5, 0x2d, 0xd, 0x1, 0x16}, > > + {12000000, 680000000, 0x0, 0x71, > > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > > + 0x1, 0x8, 0x13, 0xe, 0x5, 0x2e, 0xd, 0x1, 0x16}, > > + {12000000, 690000000, 0x0, 0x73, > > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, > > + 0x1, 0x8, 0x14, 0xe, 0x6, 0x2e, 0xd, 0x1, 0x16}, > > + {12000000, 700000000, 0x0, 0x74, > > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > > + 0x1, 0x8, 0x14, 0xf, 0x6, 0x2f, 0xe, 0x1, 0x16}, > > + {12000000, 710000000, 0x0, 0x76, > > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > > + 0x1, 0x8, 0x14, 0xf, 0x6, 0x2f, 0xe, 0x1, 0x17}, > > + {12000000, 720000000, 0x0, 0x78, > > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, > > + 0x1, 0x8, 0x15, 0xf, 0x6, 0x30, 0xe, 0x1, 0x17}, > > + {12000000, 730000000, 0x0, 0x79, > > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > > + 0x1, 0x8, 0x15, 0xf, 0x6, 0x31, 0xe, 0x1, 0x17}, > > + {12000000, 740000000, 0x0, 0x7b, > > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > > + 0x1, 0x8, 0x15, 0xf, 0x6, 0x32, 0xe, 0x1, 0x17}, > > + {12000000, 750000000, 0x0, 0x7d, > > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, > > + 0x1, 0x8, 0x16, 0xf, 0x6, 0x32, 0xe, 0x1, 0x17}, > > + {12000000, 760000000, 0x0, 0x7e, > > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > > + 0x1, 0x9, 0x15, 0xf, 0x6, 0x33, 0xe, 0x1, 0x17}, > > + {12000000, 770000000, 0x0, 0x80, > > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > > + 0x1, 0x9, 0x15, 0x10, 0x6, 0x34, 0xf, 0x1, 0x18}, > > + {12000000, 780000000, 0x0, 0x82, > > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, > > + 0x1, 0x9, 0x16, 0x10, 0x6, 0x35, 0xf, 0x1, 0x18,}, > > + {12000000, 790000000, 0x0, 0x83, > > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > > + 0x1, 0x9, 0x16, 0x10, 0x7, 0x34, 0xf, 0x1, 0x18}, > > + {12000000, 800000000, 0x0, 0x85, > > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > > + 0x1, 0x9, 0x17, 0x10, 0x7, 0x35, 0xf, 0x1, 0x18}, > > + {12000000, 810000000, 0x0, 0x87, > > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, > > + 0x1, 0x9, 0x17, 0x10, 0x7, 0x36, 0xf, 0x1, 0x18}, > > + {12000000, 820000000, 0x0, 0x88, > > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > > + 0x1, 0x9, 0x17, 0x10, 0x7, 0x37, 0xf, 0x1, 0x18}, > > + {12000000, 830000000, 0x0, 0x8a, > > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > > + 0x1, 0x9, 0x18, 0x10, 0x7, 0x37, 0xf, 0x1, 0x18}, > > + {12000000, 840000000, 0x0, 0x8c, > > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, > > + 0x1, 0x9, 0x18, 0x11, 0x7, 0x38, 0x10, 0x1, 0x19}, > > + {12000000, 850000000, 0x0, 0x8d, > > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > > + 0x1, 0xa, 0x17, 0x11, 0x7, 0x39, 0x10, 0x1, 0x19}, > > + {12000000, 860000000, 0x0, 0x8f, > > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > > + 0x1, 0xa, 0x18, 0x11, 0x7, 0x39, 0x10, 0x1, 0x19}, > > + {12000000, 870000000, 0x0, 0x91, > > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, > > + 0x1, 0xa, 0x18, 0x11, 0x7, 0x3a, 0x10, 0x1, 0x19}, > > + {12000000, 880000000, 0x0, 0x92, > > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > > + 0x1, 0xa, 0x18, 0x11, 0x7, 0x3b, 0x10, 0x1, 0x19}, > > + {12000000, 890000000, 0x0, 0x94, > > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > > + 0x1, 0xa, 0x19, 0x11, 0x7, 0x3c, 0x10, 0x1, 0x19}, > > + {12000000, 900000000, 0x0, 0x96, > > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, > > + 0x1, 0xa, 0x19, 0x12, 0x8, 0x3c, 0x10, 0x1, 0x19}, > > + {12000000, 910000000, 0x0, 0x97, > > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > > + 0x1, 0xa, 0x19, 0x12, 0x8, 0x3c, 0x11, 0x1, 0x1a}, > > + {12000000, 920000000, 0x0, 0x99, > > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > > + 0x1, 0xa, 0x1a, 0x12, 0x8, 0x3d, 0x11, 0x1, 0x1a}, > > + {12000000, 930000000, 0x0, 0x9b, > > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, > > + 0x1, 0xa, 0x1a, 0x12, 0x8, 0x3e, 0x11, 0x1, 0x1a}, > > + {12000000, 940000000, 0x0, 0x9c, > > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > > + 0x1, 0xb, 0x1a, 0x12, 0x8, 0x3e, 0x11, 0x1, 0x1a}, > > + {12000000, 950000000, 0x0, 0x9e, > > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > > + 0x1, 0xb, 0x1a, 0x12, 0x8, 0x3f, 0x11, 0x1, 0x1a}, > > + {12000000, 960000000, 0x0, 0xa0, > > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, > > + 0x1, 0xb, 0x1a, 0x12, 0x8, 0x40, 0x11, 0x1, 0x1a}, > > + {12000000, 970000000, 0x0, 0xa1, > > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > > + 0x1, 0xb, 0x1b, 0x13, 0x8, 0x41, 0x12, 0x1, 0x1b}, > > + {12000000, 980000000, 0x0, 0xa3, > > + STF_DPHY_LSHIFT_16(0x55) | STF_DPHY_LSHIFT_8(0x55) | 0x55, > > + 0x1, 0xb, 0x1b, 0x13, 0x8, 0x42, 0x12, 0x1, 0x1b}, > > + {12000000, 990000000, 0x0, 0xa5, > > + STF_DPHY_LSHIFT_16(0x0) | STF_DPHY_LSHIFT_8(0x0) | 0x0, > > + 0x1, 0xb, 0x1b, 0x13, 0x8, 0x42, 0x12, 0x1, 0x1b}, > > + {12000000, 1000000000, 0x0, 0xa6, > > + STF_DPHY_LSHIFT_16(0xaa) | STF_DPHY_LSHIFT_8(0xaa) | 0xaa, > > + 0x1, 0xb, 0x1c, 0x13, 0x9, 0x42, 0x12, 0x1, 0x1b}, }; > > + > > +struct stf_dphy_info { > > + /** > > + * @maps: > > + * > > + * Physical lanes and logic lanes mapping table. > > + * > > + * The default order is: > > + * [data lane 0, data lane 1, data lane 2, date lane 3, clk lane] > > + */ > > + u8 maps[STF_MAP_LANES_NUM]; > > +}; > > + > > +struct stf_dphy { > > + struct device *dev; > > + void __iomem *topsys; > > + struct clk *txesc_clk; > > + struct reset_control *sys_rst; > > + > > + struct phy_configure_opts_mipi_dphy config; > > + > > + struct phy *phy; > > + const struct stf_dphy_info *info; > > +}; > > + > > +static inline u32 stf_dphy_get_reg(void __iomem *io_addr, u32 addr, > > +u32 shift, u32 mask) { > > + u32 tmp; > > + > > + tmp = readl(io_addr); > > + tmp = (tmp & mask) >> shift; > > + return tmp; > > +} > > + > > +static inline void stf_dphy_set_reg(void __iomem *io_addr, u32 addr, > > +u32 data, u32 shift, u32 mask) { > > + u32 tmp; > > + > > + tmp = readl(io_addr + addr); > > + tmp &= ~mask; > > + tmp |= (data << shift) & mask; > > + writel(tmp, (io_addr + addr)); > > +} > > + > > +static int is_pll_locked(struct stf_dphy *dphy) { > > + int tmp = stf_dphy_get_reg(dphy->topsys, > STF_DPHY_APBIFSAIF_SYSCFG(8), > > + STF_DPHY_RGS_CDTX_PLL_UNLOCK_SHIFT, > > + STF_DPHY_RGS_CDTX_PLL_UNLOCK_MASK); > > + return !tmp; > > why inverted value? > ok, will fix it > > +} > > + > > +static void stf_dphy_hw_reset(struct stf_dphy *dphy, int assert) { > > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(100), > > + !assert, STF_DPHY_RESETB_SHIFT, STF_DPHY_RESETB_MASK); > > + > > + if (!assert) { > > + while ((!is_pll_locked(dphy))) > > + ; > > This is infinite, that is not acceptable. Please have a decent timeout for this... > ok, will follow up this issue. We may use readl_poll_timeout_atomic() here in next version > > + dev_err(dphy->dev, "MIPI dphy-tx # PLL Locked\n"); > > + } > > +} > > + > > +static int stf_dphy_configure(struct phy *phy, union > > +phy_configure_opts *opts) { > > + struct stf_dphy *dphy = phy_get_drvdata(phy); > > + const struct stf_dphy_info *info = dphy->info; > > + u32 bitrate = opts->mipi_dphy.hs_clk_rate; > > + const struct m31_dphy_config *p; > > + unsigned long alignment; > > + int i; > > + > > + bitrate = opts->mipi_dphy.hs_clk_rate; > > + > > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(8), 0x10, > > + STF_DPHY_RG_CDTX_L0N_HSTX_RES_SHIFT, > STF_DPHY_RG_CDTX_L0N_HSTX_RES_MASK); > > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(12), 0x10, > > + STF_DPHY_RG_CDTX_L0N_HSTX_RES_SHIFT, > STF_DPHY_RG_CDTX_L0N_HSTX_RES_MASK); > > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(12), 0x10, > > + STF_DPHY_RG_CDTX_L2N_HSTX_RES_SHIFT, > STF_DPHY_RG_CDTX_L2N_HSTX_RES_MASK); > > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(12), 0x10, > > + STF_DPHY_RG_CDTX_L3N_HSTX_RES_SHIFT, > STF_DPHY_RG_CDTX_L3N_HSTX_RES_MASK); > > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(16), 0x10, > > + STF_DPHY_RG_CDTX_L4N_HSTX_RES_SHIFT, > STF_DPHY_RG_CDTX_L4N_HSTX_RES_MASK); > > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(8), 0x10, > > + STF_DPHY_RG_CDTX_L0P_HSTX_RES_SHIFT, > STF_DPHY_RG_CDTX_L0P_HSTX_RES_MASK); > > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(12), 0x10, > > + STF_DPHY_RG_CDTX_L1P_HSTX_RES_SHIFT, > STF_DPHY_RG_CDTX_L1P_HSTX_RES_MASK); > > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(12), 0x10, > > + STF_DPHY_RG_CDTX_L2P_HSTX_RES_SHIFT, > STF_DPHY_RG_CDTX_L2P_HSTX_RES_MASK); > > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(12), 0x10, > > + STF_DPHY_RG_CDTX_L3P_HSTX_RES_SHIFT, > STF_DPHY_RG_CDTX_L3P_HSTX_RES_MASK); > > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(16), 0x10, > > + STF_DPHY_RG_CDTX_L4P_HSTX_RES_SHIFT, > > +STF_DPHY_RG_CDTX_L4P_HSTX_RES_MASK); > > + > > + alignment = STF_DPHY_BITRATE_ALIGN; > > + if (bitrate % alignment) > > + bitrate += alignment - (bitrate % alignment); > > + > > + p = m31_dphy_configs; > > + for (i = 0; i < ARRAY_SIZE(m31_dphy_configs); i++, p++) { > > + if (p->bitrate == bitrate) { > > + stf_dphy_set_reg(dphy->topsys, > STF_DPHY_APBIFSAIF_SYSCFG(100), > > + STF_DPHY_REFCLK_12M, > STF_DPHY_REFCLK_IN_SEL_SHIFT, > > + STF_DPHY_REFCLK_IN_SEL_MASK); > > + > > + stf_dphy_set_reg(dphy->topsys, > STF_DPHY_APBIFSAIF_SYSCFG(0), > > + STF_DPHY_AON_POWER_READY_N_ACTIVE, > > + STF_DPHY_AON_POWER_READY_N_SHIFT, > > + STF_DPHY_AON_POWER_READY_N_MASK); > > + > > + /*Lane setting*/ > > + stf_dphy_set_reg(dphy->topsys, > STF_DPHY_APBIFSAIF_SYSCFG(0), info->maps[0], > > + STF_DPHY_CFG_L0_SWAP_SEL_SHIFT, > > + STF_DPHY_CFG_L0_SWAP_SEL_MASK); > > + stf_dphy_set_reg(dphy->topsys, > STF_DPHY_APBIFSAIF_SYSCFG(0), info->maps[1], > > + STF_DPHY_CFG_L1_SWAP_SEL_SHIFT, > > + STF_DPHY_CFG_L1_SWAP_SEL_MASK); > > + stf_dphy_set_reg(dphy->topsys, > STF_DPHY_APBIFSAIF_SYSCFG(0), info->maps[2], > > + STF_DPHY_CFG_L2_SWAP_SEL_SHIFT, > > + STF_DPHY_CFG_L2_SWAP_SEL_MASK); > > + stf_dphy_set_reg(dphy->topsys, > STF_DPHY_APBIFSAIF_SYSCFG(0), info->maps[3], > > + STF_DPHY_CFG_L3_SWAP_SEL_SHIFT, > > + STF_DPHY_CFG_L3_SWAP_SEL_MASK); > > + stf_dphy_set_reg(dphy->topsys, > STF_DPHY_APBIFSAIF_SYSCFG(0), info->maps[4], > > + STF_DPHY_CFG_L4_SWAP_SEL_SHIFT, > > + STF_DPHY_CFG_L4_SWAP_SEL_MASK); > > + /*PLL setting*/ > > + stf_dphy_set_reg(dphy->topsys, > STF_DPHY_APBIFSAIF_SYSCFG(28), 0x0, > > + STF_DPHY_RG_CDTX_PLL_SSC_EN_SHIFT, > > + STF_DPHY_RG_CDTX_PLL_SSC_EN_MASK); > > + stf_dphy_set_reg(dphy->topsys, > STF_DPHY_APBIFSAIF_SYSCFG(24), 0x1, > > + STF_DPHY_RG_CDTX_PLL_LDO_STB_X2_EN_SHIFT, > > + STF_DPHY_RG_CDTX_PLL_LDO_STB_X2_EN_MASK); > > + stf_dphy_set_reg(dphy->topsys, > STF_DPHY_APBIFSAIF_SYSCFG(24), 0x1, > > + STF_DPHY_RG_CDTX_PLL_FM_EN_SHIFT, > > + STF_DPHY_RG_CDTX_PLL_FM_EN_MASK); > > + > > + stf_dphy_set_reg(dphy->topsys, > STF_DPHY_APBIFSAIF_SYSCFG(24), > > + p->pll_prev_div, > STF_DPHY_RG_CDTX_PLL_PRE_DIV_SHIFT, > > + STF_DPHY_RG_CDTX_PLL_PRE_DIV_MASK); > > + stf_dphy_set_reg(dphy->topsys, > STF_DPHY_APBIFSAIF_SYSCFG(24), > > + p->pll_fbk_int, > STF_DPHY_RG_CDTX_PLL_FBK_INT_SHIFT, > > + STF_DPHY_RG_CDTX_PLL_FBK_INT_MASK); > > + stf_dphy_set_reg(dphy->topsys, > STF_DPHY_APBIFSAIF_SYSCFG(20), > > + p->pll_fbk_fra, > STF_DPHY_RG_CDTX_PLL_FBK_FRA_SHIFT, > > + STF_DPHY_RG_CDTX_PLL_FBK_FRA_MASK); > > + stf_dphy_set_reg(dphy->topsys, > STF_DPHY_APBIFSAIF_SYSCFG(40), > > + p->extd_cycle_sel, > STF_DPHY_RG_EXTD_CYCLE_SEL_SHIFT, > > + STF_DPHY_RG_EXTD_CYCLE_SEL_MASK); > > + stf_dphy_set_reg(dphy->topsys, > STF_DPHY_APBIFSAIF_SYSCFG(36), > > + p->dlane_hs_pre_time, > > + STF_DPHY_RG_DLANE_HS_PRE_TIME_SHIFT, > > + STF_DPHY_RG_DLANE_HS_PRE_TIME_MASK); > > + stf_dphy_set_reg(dphy->topsys, > STF_DPHY_APBIFSAIF_SYSCFG(36), > > + p->dlane_hs_pre_time, > > + STF_DPHY_RG_DLANE_HS_PRE_TIME_SHIFT, > > + STF_DPHY_RG_DLANE_HS_PRE_TIME_MASK); > > + stf_dphy_set_reg(dphy->topsys, > STF_DPHY_APBIFSAIF_SYSCFG(36), > > + p->dlane_hs_zero_time, > > + STF_DPHY_RG_DLANE_HS_ZERO_TIME_SHIFT, > > + STF_DPHY_RG_DLANE_HS_ZERO_TIME_MASK); > > + stf_dphy_set_reg(dphy->topsys, > STF_DPHY_APBIFSAIF_SYSCFG(36), > > + p->dlane_hs_trail_time, > > + STF_DPHY_RG_DLANE_HS_TRAIL_TIME_SHIFT, > > + STF_DPHY_RG_DLANE_HS_TRAIL_TIME_MASK); > > + stf_dphy_set_reg(dphy->topsys, > STF_DPHY_APBIFSAIF_SYSCFG(32), > > + p->clane_hs_pre_time, > > + STF_DPHY_RG_CLANE_HS_PRE_TIME_SHIFT, > > + STF_DPHY_RG_CLANE_HS_PRE_TIME_MASK); > > + stf_dphy_set_reg(dphy->topsys, > STF_DPHY_APBIFSAIF_SYSCFG(36), > > + p->clane_hs_zero_time, > > + STF_DPHY_RG_CLANE_HS_ZERO_TIME_SHIFT, > > + STF_DPHY_RG_CLANE_HS_ZERO_TIME_MASK); > > + stf_dphy_set_reg(dphy->topsys, > STF_DPHY_APBIFSAIF_SYSCFG(32), > > + p->clane_hs_trail_time, > > + STF_DPHY_RG_CLANE_HS_TRAIL_TIME_SHIFT, > > + STF_DPHY_RG_CLANE_HS_TRAIL_TIME_MASK); > > + stf_dphy_set_reg(dphy->topsys, > STF_DPHY_APBIFSAIF_SYSCFG(32), > > + p->clane_hs_clk_pre_time, > > + STF_DPHY_RG_CLANE_HS_CLK_PRE_TIME_SHIFT, > > + STF_DPHY_RG_CLANE_HS_CLK_PRE_TIME_MASK); > > + stf_dphy_set_reg(dphy->topsys, > STF_DPHY_APBIFSAIF_SYSCFG(32), > > + p->clane_hs_clk_post_time, > > + STF_DPHY_RG_CLANE_HS_CLK_POST_TIME_SHIFT, > > + STF_DPHY_RG_CLANE_HS_CLK_POST_TIME_MASK); > > + > > + break; > > + } > > + } > > + > > + return 0; > > this is the only return. It will always return success, consider making this return > void > In 'struct phy_ops', the call back '.configure' needs Integer return value. Maybe we can only return 0 here. (T-T) Function prototypes: https://elixir.bootlin.com/linux/v6.9-rc3/source/include/linux/phy/phy.h#L103 struct phy_ops { ... int (*configure)(struct phy *phy, union phy_configure_opts *opts); ... }; > > +} > > + > > +static int stf_dphy_init(struct phy *phy) { > > + struct stf_dphy *dphy = phy_get_drvdata(phy); > > + int ret; > > + > > + stf_dphy_hw_reset(dphy, 0); > > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(48), 0, > > + STF_DPHY_SCFG_PPI_C_READY_SEL_SHIFT, > STF_DPHY_SCFG_PPI_C_READY_SEL_MASK); > > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(48), 0, > > + STF_DPHY_SCFG_DSI_TXREADY_ESC_SEL_SHIFT, > > + STF_DPHY_SCFG_DSI_TXREADY_ESC_SEL_MASK); > > + stf_dphy_set_reg(dphy->topsys, STF_DPHY_APBIFSAIF_SYSCFG(44), 0x30, > > + STF_DPHY_SCFG_C_HS_PRE_ZERO_TIME_SHIFT, > > + STF_DPHY_SCFG_C_HS_PRE_ZERO_TIME_MASK); > > + > > + ret = clk_prepare_enable(dphy->txesc_clk); > > + if (ret) { > > + dev_err(dphy->dev, "Failed to prepare/enable txesc_clk\n"); > > + return ret; > > + } > > + > > + ret = reset_control_deassert(dphy->sys_rst); > > + if (ret) { > > + dev_err(dphy->dev, "Failed to deassert sys_rst\n"); > > + return ret; > > + } > > + > > + return 0; > > +} > > + > > +static int stf_dphy_exit(struct phy *phy) { > > + struct stf_dphy *dphy = phy_get_drvdata(phy); > > + int ret; > > + > > + ret = reset_control_assert(dphy->sys_rst); > > + if (ret) { > > + dev_err(dphy->dev, "Failed to assert sys_rst\n"); > > + return ret; > > + } > > + > > + clk_disable_unprepare(dphy->txesc_clk); > > + > > + stf_dphy_hw_reset(dphy, 1); > > + > > + return 0; > > +} > > + > > +static int stf_dphy_power_on(struct phy *phy) { > > + struct stf_dphy *dphy = phy_get_drvdata(phy); > > + > > + return pm_runtime_resume_and_get(dphy->dev); > > +} > > + > > +static int stf_dphy_validate(struct phy *phy, enum phy_mode mode, int > submode, > > + union phy_configure_opts *opts) { > > + if (mode != PHY_MODE_MIPI_DPHY) > > + return -EINVAL; > > + > > + return 0; > > +} > > + > > +static int stf_dphy_power_off(struct phy *phy) { > > + struct stf_dphy *dphy = phy_get_drvdata(phy); > > + > > + return pm_runtime_put_sync(dphy->dev); } > > + > > +static const struct phy_ops stf_dphy_ops = { > > + .power_on = stf_dphy_power_on, > > + .power_off = stf_dphy_power_off, > > + .init = stf_dphy_init, > > + .exit = stf_dphy_exit, > > + .configure = stf_dphy_configure, > > + .validate = stf_dphy_validate, > > + .owner = THIS_MODULE, > > +}; > > + > > +static int stf_dphy_probe(struct platform_device *pdev) { > > + struct phy_provider *phy_provider; > > + struct stf_dphy *dphy; > > + > > + dphy = devm_kzalloc(&pdev->dev, sizeof(*dphy), GFP_KERNEL); > > + if (!dphy) > > + return -ENOMEM; > > + > > + dphy->info = of_device_get_match_data(&pdev->dev); > > + > > + dphy->dev = &pdev->dev; > > + dev_set_drvdata(&pdev->dev, dphy); > > + > > + dphy->topsys = devm_platform_ioremap_resource(pdev, 0); > > + if (IS_ERR(dphy->topsys)) > > + return PTR_ERR(dphy->topsys); > > + > > + pm_runtime_enable(&pdev->dev); > > + > > + dphy->txesc_clk = devm_clk_get(&pdev->dev, "txesc"); > > + if (IS_ERR(dphy->txesc_clk)) > > + return dev_err_probe(&pdev->dev, PTR_ERR(dphy->txesc_clk), > > + "Failed to get txesc clock\n"); > > + > > + dphy->sys_rst = devm_reset_control_get_exclusive(&pdev->dev, "sys"); > > + if (IS_ERR(dphy->sys_rst)) > > + return dev_err_probe(&pdev->dev, PTR_ERR(dphy->sys_rst), > > + "Failed to get sys reset\n"); > > + > > + dphy->phy = devm_phy_create(&pdev->dev, NULL, &stf_dphy_ops); > > + if (IS_ERR(dphy->phy)) > > + return dev_err_probe(&pdev->dev, PTR_ERR(dphy->phy), > > + "Failed to create phy\n"); > > + > > + phy_set_drvdata(dphy->phy, dphy); > > + > > + phy_provider = devm_of_phy_provider_register(&pdev->dev, > of_phy_simple_xlate); > > + if (IS_ERR(phy_provider)) > > + return dev_err_probe(&pdev->dev, PTR_ERR(phy_provider), > > + "Failed to register phy\n"); > > + > > + return 0; > > +} > > + > > +static const struct stf_dphy_info starfive_dphy_info = { > > + .maps = {0, 1, 2, 3, 4}, > > +}; > > + > > +static const struct of_device_id stf_dphy_dt_ids[] = { > > + { > > + .compatible = "starfive,jh7110-dphy-tx", > > + .data = &starfive_dphy_info, > > + }, > > + { /* sentinel */ }, > > +}; > > +MODULE_DEVICE_TABLE(of, stf_dphy_dt_ids); > > + > > +static struct platform_driver stf_dphy_driver = { > > + .driver = { > > + .name = "starfive-dphy-tx", > > + .of_match_table = stf_dphy_dt_ids, > > + }, > > + .probe = stf_dphy_probe, > > +}; > > +module_platform_driver(stf_dphy_driver); > > + > > +MODULE_AUTHOR("Keith Zhao <keith.zhao@starfivetech.com>"); > > +MODULE_AUTHOR("Shengyang Chen > <shengyang.chen@starfivetech.com>"); > > +MODULE_DESCRIPTION("StarFive JH7110 DPHY TX driver"); > > +MODULE_LICENSE("GPL"); > > -- > > 2.17.1 > > > > > > -- > > linux-phy mailing list > > linux-phy@lists.infradead.org > > https://lists.infradead.org/mailman/listinfo/linux-phy > > -- > ~Vinod thanks. Best Regards, Shengyang ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH v4 0/2] Add JH7110 MIPI DPHY TX support 2024-03-01 1:24 [PATCH v4 0/2] Add JH7110 MIPI DPHY TX support Shengyang Chen 2024-03-01 1:24 ` [PATCH v4 1/2] dt-bindings: phy: Add starfive,jh7110-dphy-tx Shengyang Chen 2024-03-01 1:24 ` [PATCH v4 2/2] phy: starfive: Add mipi dphy tx support Shengyang Chen @ 2024-03-18 3:33 ` Shengyang Chen 2 siblings, 0 replies; 6+ messages in thread From: Shengyang Chen @ 2024-03-18 3:33 UTC (permalink / raw) To: devicetree@vger.kernel.org, linux-phy@lists.infradead.org Cc: vkoul@kernel.org, kishon@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, p.zabel@pengutronix.de, Minda Chen, Changhuang Liang, rogerq@kernel.org, geert+renesas@glider.be, Keith Zhao, linux-kernel@vger.kernel.org > This patchset adds mipi dphy tx support for the StarFive JH7110 SoC. > It is used to transfer DSI data. The series has been tested on the VisionFive 2 > board. > > Hi, Vinod and Kishon Could you please help to review and give me some suggestions for this patch series? Thank you for your time. Best regards, Shengyang ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-04-09 7:02 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-03-01 1:24 [PATCH v4 0/2] Add JH7110 MIPI DPHY TX support Shengyang Chen 2024-03-01 1:24 ` [PATCH v4 1/2] dt-bindings: phy: Add starfive,jh7110-dphy-tx Shengyang Chen 2024-03-01 1:24 ` [PATCH v4 2/2] phy: starfive: Add mipi dphy tx support Shengyang Chen 2024-04-05 16:31 ` Vinod Koul 2024-04-09 6:30 ` Shengyang Chen 2024-03-18 3:33 ` [PATCH v4 0/2] Add JH7110 MIPI DPHY TX support Shengyang Chen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).