From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from abb.hmeau.com (abb.hmeau.com [144.6.53.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E139013EFE6; Thu, 11 Apr 2024 07:39:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=144.6.53.87 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712821196; cv=none; b=h1ymBNU7IH+/Zd7P+rEu8ZkBJ/G6xjjXsX9qASqcd2f3CujyL4FXQ6ZuSLkBKn4YjqjLuhKnfYxUHCNPJND850pk7FRxwqsbQTTkldVWE/5o2JJbGnE4juALMpRy1QG6H5kVah87OrZywMBqwsCX0TKq/5LV9Iemez2f1xjSJtg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712821196; c=relaxed/simple; bh=wDjj/BxrUT9AJhlIJcBur8HkBzHyYmG/dJLyN88edKw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bTSGjUchnquMkDO9YL6APrVbISECG85817F8AsTaeEY+0ZL+ZWzrJ34FZ0y92suxawZ921/DseTp3jMQWLgsKLnLybO93UOweZsgUfX3Mm5Xeqld1xCY0ie2X008FAnhqvi34p0IImqg8t8WeXi7cgSK3gpxIx1vL7+gpgVVUMo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gondor.apana.org.au; spf=pass smtp.mailfrom=gondor.apana.org.au; arc=none smtp.client-ip=144.6.53.87 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gondor.apana.org.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gondor.apana.org.au Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1rup1d-000Fuk-TF; Thu, 11 Apr 2024 15:39:14 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Thu, 11 Apr 2024 15:39:31 +0800 Date: Thu, 11 Apr 2024 15:39:31 +0800 From: Herbert Xu To: Alexey Romanov Cc: "neil.armstrong@linaro.org" , "clabbe@baylibre.com" , "davem@davemloft.net" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "conor+dt@kernel.org" , "khilman@baylibre.com" , "jbrunet@baylibre.com" , "martin.blumenstingl@googlemail.com" , "vadim.fedorenko@linux.dev" , "linux-crypto@vger.kernel.org" , "linux-amlogic@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , kernel Subject: Re: [PATCH v6 11/23] drivers: crypto: meson: introduce hasher Message-ID: References: <20240326153219.2915080-1-avromanov@salutedevices.com> <20240326153219.2915080-12-avromanov@salutedevices.com> <20240410103908.suw6x3pywk73nftp@cab-wsm-0029881.sigma.sbrf.ru> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240410103908.suw6x3pywk73nftp@cab-wsm-0029881.sigma.sbrf.ru> On Wed, Apr 10, 2024 at 10:39:14AM +0000, Alexey Romanov wrote: > Hello Herbert, > > On Fri, Apr 05, 2024 at 02:56:30PM +0800, Herbert Xu wrote: > > On Tue, Mar 26, 2024 at 06:32:07PM +0300, Alexey Romanov wrote: > > > Introduce support for SHA1/SHA224/SHA256 hash algos. > > > Tested via tcrypt and custom tests. > > > > > > Signed-off-by: Alexey Romanov > > > --- > > > drivers/crypto/amlogic/Makefile | 2 +- > > > drivers/crypto/amlogic/amlogic-gxl-core.c | 25 +- > > > drivers/crypto/amlogic/amlogic-gxl-hasher.c | 460 ++++++++++++++++++++ > > > drivers/crypto/amlogic/amlogic-gxl.h | 51 +++ > > > 4 files changed, 536 insertions(+), 2 deletions(-) > > > create mode 100644 drivers/crypto/amlogic/amlogic-gxl-hasher.c > > > > Where are the import/export functions? > > Sorry, I miss understand you. What do you mean by "import/epxort > functions"? The crypto hash API supports partial hashing, which means that you need to be able to hash part of the data, save the state, and then resume it later. If your hardware only supports full hashing then you will need to add a software fallback. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt