devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Fabio Aiuto <fabio.aiuto@engicam.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Mark Brown <broonie@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
	Robin Gong <yibin.gong@nxp.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Matteo Lisi <matteo.lisi@engicam.com>,
	Mirko Ardinghi <mirko.ardinghi@engicam.com>
Subject: Re: [PATCH v3 1/2] regulator: dt-bindings: pca9450: add PMIC_RST_B warm reset property
Date: Fri, 12 Apr 2024 09:21:46 +0200	[thread overview]
Message-ID: <ZhjhCvVNezy9r7P4@engicam> (raw)
In-Reply-To: <e86812b3-a3aa-4bdb-9b32-a0339f0f76b5@kernel.org>

Dear Krzysztof,

Il Thu, Apr 11, 2024 at 09:52:12PM +0200, Krzysztof Kozlowski ha scritto:
> On 11/04/2024 18:58, Fabio Aiuto wrote:
> > Add property to trigger warm reset on PMIC_RST_B assertion
> > 
> 
> That's rather vague and does not tell me much why this is supposed to be
> board level configuration. It sounds more like a debugging feature:
> during development you want to retain memory contents for pstore etc.
> Then I could imagine this should be turned runtime, e.g. via
> sysfs/debugfs, because for example you want to start inspecting a
> customer's device.

thanks, I spent too few time writing this commit log and I apologize
for that. I was thinking about something like:

    The default configuration of the PMIC behavior makes the PMIC
    power cycle most regulators on PMIC_RST_B assertion. This power
    cycling causes the memory contents of OCRAM to be lost.
    Some systems needs some memory that survives reset and
    reboot, therefore add a property to tell PMIC_RST_B is
    wired.

The actual configuration is made at probe time, anyway we need
to override the default behavior of the pmic to get a warm reset
everytime the PMIC_RST_B pin is asserted and this property tells
us that "something is wired to that pin" and "it has to behave
that way on pin assertion". Our use cases do not meet the need
of further runtime configuration change.

Maybe this patchset is a simple starting point...

kindly waiting for you reply before submitting v4.

best regards,

fabio

> 
> Best regards,
> Krzysztof
> 

  reply	other threads:[~2024-04-12  7:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-11 16:57 [PATCH v3 0/2] regulator: pca9450: make warm reset on PMIC_RST_B assertion Fabio Aiuto
2024-04-11 16:58 ` [PATCH v3 1/2] regulator: dt-bindings: pca9450: add PMIC_RST_B warm reset property Fabio Aiuto
2024-04-11 19:52   ` Krzysztof Kozlowski
2024-04-12  7:21     ` Fabio Aiuto [this message]
2024-04-13 10:58       ` Krzysztof Kozlowski
2024-04-13 17:10         ` Fabio Aiuto
2024-04-13 21:40           ` Krzysztof Kozlowski
2024-04-15 10:59             ` Fabio Aiuto
2024-05-02  7:54               ` Krzysztof Kozlowski
2024-05-10 11:03                 ` Fabio Aiuto
2024-04-11 16:58 ` [PATCH v3 2/2] regulator: pca9450: make warm reset on PMIC_RST_B assertion Fabio Aiuto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZhjhCvVNezy9r7P4@engicam \
    --to=fabio.aiuto@engicam.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matteo.lisi@engicam.com \
    --cc=mirko.ardinghi@engicam.com \
    --cc=robh@kernel.org \
    --cc=yibin.gong@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).