From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Zhi Mao <zhi.mao@mediatek.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
Heiko Stuebner <heiko@sntech.de>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Hans de Goede <hdegoede@redhat.com>,
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
Alain Volmat <alain.volmat@foss.st.com>,
Paul Elder <paul.elder@ideasonboard.com>,
Mehdi Djait <mehdi.djait@bootlin.com>,
Bingbu Cao <bingbu.cao@intel.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, shengnan.wang@mediatek.com,
yaya.chang@mediatek.com, yunkec@chromium.org, 10572168@qq.com
Subject: Re: [PATCH 2/2] media: i2c: Add GT97xx VCM driver
Date: Fri, 12 Apr 2024 09:38:51 +0000 [thread overview]
Message-ID: <ZhkBIee2X0UY40yD@kekkonen.localdomain> (raw)
In-Reply-To: <CAHp75VfF0pbrKXjWZg7sTr-T=_CbjP+deFQP-VLCGX8ooahctg@mail.gmail.com>
Hi Andy, Zhi,
On Wed, Apr 10, 2024 at 07:00:02PM +0300, Andy Shevchenko wrote:
> > +static int gt97xx_open(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh)
> > +{
> > + return pm_runtime_resume_and_get(sd->dev);
> > +}
> > +
> > +static int gt97xx_close(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh)
> > +{
> > + return pm_runtime_put(sd->dev);
> > +}
>
> Hmm... Shouldn't v4l2 take care about these (PM calls)?
Ideally yes. We don't have a good mechanism for this at the moment as the
lens isn't part of the image pipeline. Non-data links may be used for this
in the future but that's not implemented yet.
--
Regards,
Sakari Ailus
next prev parent reply other threads:[~2024-04-12 9:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 10:40 [PATCH 0/2] media: i2c: Add support for GT97xx VCM Zhi Mao
2024-04-10 10:40 ` [PATCH 1/2] media: dt-bindings: i2c: add Giantec GT97xx VCM driver Zhi Mao
2024-04-10 11:27 ` Conor Dooley
2024-04-10 11:41 ` Sakari Ailus
2024-04-10 20:52 ` Rob Herring
2024-04-11 2:04 ` Zhi Mao (毛智)
2024-04-11 6:05 ` Krzysztof Kozlowski
2024-04-10 10:40 ` [PATCH 2/2] media: i2c: Add " Zhi Mao
2024-04-10 16:00 ` Andy Shevchenko
2024-04-12 9:38 ` Sakari Ailus [this message]
2024-04-12 13:43 ` Andy Shevchenko
2024-04-15 7:25 ` Sakari Ailus
2024-04-20 1:48 ` Zhi Mao (毛智)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZhkBIee2X0UY40yD@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=10572168@qq.com \
--cc=alain.volmat@foss.st.com \
--cc=andy.shevchenko@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bingbu.cao@intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=heiko@sntech.de \
--cc=hverkuil-cisco@xs4all.nl \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=mehdi.djait@bootlin.com \
--cc=p.zabel@pengutronix.de \
--cc=paul.elder@ideasonboard.com \
--cc=robh@kernel.org \
--cc=shengnan.wang@mediatek.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=yaya.chang@mediatek.com \
--cc=yunkec@chromium.org \
--cc=zhi.mao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox