From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-189.mta0.migadu.com (out-189.mta0.migadu.com [91.218.175.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 624FC225D6 for ; Sun, 14 Apr 2024 07:50:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.189 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713081043; cv=none; b=i0ykElLw05eGaW19kbza+9ERmosgy38LIklzYgUArGEM7edpx7l4bJfsHyc9Jwlln3H4wjDc40YRv7E8jcc4rWuqnQLPJPstnaPXVg5YRVEnDNOUch6ECEEBtcWWCwOV7y5V09PkiAlz3xHa/UJGz8ROwNa6gLnVYQO7jxr7JQU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713081043; c=relaxed/simple; bh=DlrkisTiYTTNhdGDHEA9kXqEXoDP/oRSivtOzUUYqBw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EP4tURU+3UiNYqU1pfORd5cS/dCs17xvcWmo+JzUyBRWP+iH5thPkXH3B6wIO6vVNzcQBAWmFv5UKdovmIWnxteNRaDB06mp1PDV04zKvYO4/0bXoMQ2398umwxnG0yUGi+jxwSGRb2Z/GrURJNsdJaF2F0Hb8kHVh0/ns42SPA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=jookia.org; spf=none smtp.mailfrom=jookia.org; dkim=pass (2048-bit key) header.d=jookia.org header.i=@jookia.org header.b=xjK7upus; arc=none smtp.client-ip=91.218.175.189 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=jookia.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=jookia.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=jookia.org header.i=@jookia.org header.b="xjK7upus" Date: Sun, 14 Apr 2024 17:47:54 +1000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jookia.org; s=key1; t=1713081039; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=J74iIU8vI1GkxvSB3iLi2bj3VeEbcXCRePxliDAEfkk=; b=xjK7upus0wE72MAH3FpYhJbFJRk6k9oXuSSdKMhEtwSqzb6/zbXTJo2x9CGLj5QDMURXyU QSTxWFQFlOU0lVPAV2lywFp9Fb4QDyDYBSAc5GMPyEf7bkc6Lx4ru8psKHeKM/hT8Lc5r7 EzVmjdm9jE7Po51IOJpXx1JRfQjSeRmTJDL1rTpakcWi7+/fNuEz4IXDPdd1xEHMcTN3ma QckSVOPmOHhm/RXElSn9DzKNQjRwe34mm5LnF+aZ4GNVnL6lWuYfGg4rrfWVjozpIDFFo+ uM+qCdeCOi2COxRqod7rE93M/ymk1ls8WQjXyfhic0erPV9FttNplLH9YsKK5A== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: John Watts To: Andre Przywara Cc: Chen-Yu Tsai , Lee Jones , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, Jernej Skrabec , Samuel Holland , Ryan Walklin , Chris Morgan Subject: Re: [PATCH 4/4] regulator: axp20x: AXP717: Add boost regulator Message-ID: References: <20240329235033.25309-1-andre.przywara@arm.com> <20240329235033.25309-5-andre.przywara@arm.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240329235033.25309-5-andre.przywara@arm.com> X-Migadu-Flow: FLOW_OUT On Fri, Mar 29, 2024 at 11:50:33PM +0000, Andre Przywara wrote: > The AXP717 also contains an adjustable boost regulator, to provide the > 5V USB VBUS rail when running on battery. > > Add the regulator description that states the voltage range this > regulator can cover. > > Signed-off-by: Andre Przywara Hi, I checked this against the AXP717 datasheet and it looks correct. John. Reviewed-by: John Watts > --- > drivers/regulator/axp20x-regulator.c | 4 ++++ > include/linux/mfd/axp20x.h | 1 + > 2 files changed, 5 insertions(+) > > diff --git a/drivers/regulator/axp20x-regulator.c b/drivers/regulator/axp20x-regulator.c > index 3907606b091f6..71407c5810941 100644 > --- a/drivers/regulator/axp20x-regulator.c > +++ b/drivers/regulator/axp20x-regulator.c > @@ -143,6 +143,7 @@ > #define AXP717_DCDC3_NUM_VOLTAGES 103 > #define AXP717_DCDC_V_OUT_MASK GENMASK(6, 0) > #define AXP717_LDO_V_OUT_MASK GENMASK(4, 0) > +#define AXP717_BOOST_V_OUT_MASK GENMASK(7, 4) > > #define AXP803_PWR_OUT_DCDC1_MASK BIT_MASK(0) > #define AXP803_PWR_OUT_DCDC2_MASK BIT_MASK(1) > @@ -829,6 +830,9 @@ static const struct regulator_desc axp717_regulators[] = { > AXP_DESC(AXP717, CPUSLDO, "cpusldo", "vin1", 500, 1400, 50, > AXP717_CPUSLDO_CONTROL, AXP717_LDO_V_OUT_MASK, > AXP717_LDO1_OUTPUT_CONTROL, BIT(4)), > + AXP_DESC(AXP717, BOOST, "boost", "vin1", 4550, 5510, 64, > + AXP717_BOOST_CONTROL, AXP717_BOOST_V_OUT_MASK, > + AXP717_MODULE_EN_CONTROL, BIT(4)), > }; > > /* DCDC ranges shared with AXP813 */ > diff --git a/include/linux/mfd/axp20x.h b/include/linux/mfd/axp20x.h > index 4dad54fdf67ee..5e86b976c4caa 100644 > --- a/include/linux/mfd/axp20x.h > +++ b/include/linux/mfd/axp20x.h > @@ -486,6 +486,7 @@ enum { > AXP717_CLDO3, > AXP717_CLDO4, > AXP717_CPUSLDO, > + AXP717_BOOST, > AXP717_REG_ID_MAX, > }; > > -- > 2.35.8 >