From: Fabio Aiuto <fabio.aiuto@engicam.com>
To: Mark Brown <broonie@kernel.org>
Cc: Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Krzysztof Kozlowski <krzk@kernel.org>,
Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Matteo Lisi <matteo.lisi@engicam.com>,
Mirko Ardinghi <mirko.ardinghi@engicam.com>
Subject: Re: [PATCH 2/4] regulator: dt-bindings: pca9450: add pca9451a support
Date: Thu, 18 Apr 2024 09:26:19 +0200 [thread overview]
Message-ID: <ZiDLGzJymI4W+LII@engicam> (raw)
In-Reply-To: <ZiBrbghc510G02tx@finisterre.sirena.org.uk>
Dear Mark,
Il Thu, Apr 18, 2024 at 09:38:06AM +0900, Mark Brown ha scritto:
> On Wed, Apr 17, 2024 at 05:35:26PM +0200, Fabio Aiuto wrote:
> > Update bindings for pca9451a support.
>
> Please do not submit new versions of already applied patches, please
> submit incremental updates to the existing code. Modifying existing
> commits creates problems for other users building on top of those
> commits so it's best practice to only change pubished git commits if
> absolutely essential.
thank you, I was in doubt because I did the whole job based on
shawnguo's repo where the patch isn't applied yet.
Maybe this approach was not good, should I have considered broonie's
repo for this single patch, shouldn't I?
Anyway I'm dropping this patch for a v2.
kr,
fabio
next prev parent reply other threads:[~2024-04-18 7:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 15:35 [PATCH 0/4] arm64: dts: imx93: add i.Core MX93 EDIMM 2.0 board Fabio Aiuto
2024-04-17 15:35 ` [PATCH 1/4] dt-bindings: arm: fsl: add Engicam i.Core MX93 EDIMM 2.0 Starter Kit Fabio Aiuto
2024-04-17 17:08 ` Krzysztof Kozlowski
2024-04-17 15:35 ` [PATCH 2/4] regulator: dt-bindings: pca9450: add pca9451a support Fabio Aiuto
2024-04-17 17:04 ` Krzysztof Kozlowski
2024-04-18 0:38 ` Mark Brown
2024-04-18 7:26 ` Fabio Aiuto [this message]
2024-04-17 15:35 ` [PATCH 3/4] arm64: dts: imx93: add Engicam i.Core MX93 SoM Fabio Aiuto
2024-04-17 15:35 ` [PATCH 4/4] arm64: dts: imx93: Add Engicam i.Core MX93 EDIMM 2.0 Starter Kit Fabio Aiuto
2024-04-17 17:08 ` Krzysztof Kozlowski
2024-04-18 7:28 ` Fabio Aiuto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZiDLGzJymI4W+LII@engicam \
--to=fabio.aiuto@engicam.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matteo.lisi@engicam.com \
--cc=mirko.ardinghi@engicam.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).