From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fgw22-7.mail.saunalahti.fi (fgw22-7.mail.saunalahti.fi [62.142.5.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD3B7502A3 for ; Mon, 22 Apr 2024 07:43:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.142.5.83 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713771794; cv=none; b=UMg4yPmt+kLti3cekgHIzSc5Mjsihz6L8PQ9hgXtr7XNCtX0w8yLJ9XcMs0zDhrJH/VKSScESNk8aa9wwnYo4gAMBnfPyZQbvV3vWGq9ts9B4Y/FgwgVKG1kFbr1xjuURN/0ddcusnnE+MsxvVgO9ooE/iJ/yA+Pma2JCHcZKMw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713771794; c=relaxed/simple; bh=ew5dSgQMfS9IwbBwrIa9E4pKL0iPTREwTY8/gbHfluY=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Q4VmorWdMiEQcoPUzmaLWHIE2DeGx1Qp8FDGFG888gMWmUuk0WXOVCLP96vreyNMeR4TnNZ6HlkOAXv55M0+MNEYXBUsNDJZ0lGUnQb/9dRNpduk7Nx7rSHt5gsUsQiq9qLwjkVKXfTzkC+GaPhCow/Zc7MgZTT9rk7BS/QmUr0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com; spf=fail smtp.mailfrom=gmail.com; arc=none smtp.client-ip=62.142.5.83 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=gmail.com Received: from localhost (88-113-25-208.elisa-laajakaista.fi [88.113.25.208]) by fgw22.mail.saunalahti.fi (Halon) with ESMTP id f64f7c0a-007b-11ef-a9de-005056bdf889; Mon, 22 Apr 2024 10:43:09 +0300 (EEST) From: Andy Shevchenko Date: Mon, 22 Apr 2024 10:43:08 +0300 To: Bjorn Helgaas Cc: Vidya Sagar , "Rafael J . Wysocki" , Len Brown , Will Deacon , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Frank Rowand , Thierry Reding , Jonathan Hunter , Krishna Thota , Manikanta Maddireddy , Vidya Sagar , linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Bjorn Helgaas Subject: Re: [PATCH v7-incomplete 3/3] PCI: Unify ACPI and DT 'preserve config' support Message-ID: References: <20240418174043.3750240-1-vidyas@nvidia.com> <20240421190914.374399-1-helgaas@kernel.org> <20240421190914.374399-4-helgaas@kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240421190914.374399-4-helgaas@kernel.org> Sun, Apr 21, 2024 at 02:09:14PM -0500, Bjorn Helgaas kirjoitti: ... > + if (host_bridge->dev.parent && host_bridge->dev.parent->of_node) > + return of_pci_preserve_config(host_bridge->dev.parent->of_node); If you need fwnode or of_node from struct device, please avoid direct dereference, we have dev_fwnode() of_fwnode_handle() dev_of_node() -- With Best Regards, Andy Shevchenko