From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f181.google.com (mail-yw1-f181.google.com [209.85.128.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64E9416078B for ; Wed, 24 Apr 2024 15:36:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713972985; cv=none; b=MO+6CJchpNPvdm4Phn68jZsh3xeuQWDwLuk92CGMK2H2hrG8joZE402ZMw46BHDsf/b/ym0B+EGWgW0J8qC8ySVIgot4DIn0nWfEYx02aZ0brrYAirjQzTBGfKfvoPpOmv8i9G+HbhW2m9z06jDjDwZFNTTxXsy0FOutS1pkdBw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713972985; c=relaxed/simple; bh=H/kqbfAVoGFvlhHgdIzd+BSw/1qG8jsiW3DecnDx3PQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZYBAcqvH7kiYq1i+Fzj8uoYk8hIV/t0l4+iyKi1C8uGP4WLfEQzKAtbftM/klHbJh7ww0MBIS6oTz7W1UfvXZmy1iCxLG/Isy+RzJ2nMJCYOU2O7KO22bSAJ0VlPirSdHsmuOt4TRpE11VjnWs7ZL/OZYe4A0zxjrsh9M82+69M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b=hCAi05SN; arc=none smtp.client-ip=209.85.128.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="hCAi05SN" Received: by mail-yw1-f181.google.com with SMTP id 00721157ae682-61ab31d63edso258217b3.1 for ; Wed, 24 Apr 2024 08:36:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1713972982; x=1714577782; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=UOeTFyyci3z7BUZ6gEboB6kicq7JHa28+x4pg4U/L9Q=; b=hCAi05SNb+8TkDrnDyAe/wXX0NWLx6OklKVidskMgdFjS4xLcXFYnXphJtg2EvVGX4 u9X0Kh4oFwrnxJhh//qu/zUpiheZkopOxh7stL5laNJmOHuymr459On2lPTDIoZzT2nN Q9vLczF4LkWJ9XrdPRMj4FfAgdaPkFzZK7plip3aXt/V+OL9VP26y4L9JKIrnOOKzqt3 hCuSXfr3hj1EejeYKkpFwspy0AX45CFJE0sUAu9lsbHplvU8O2wC8peZQjUH/m6LYrjG retYszOgjeBcsq/GA+0tDxiExUppmYs57AZRJzGlhGYkuYIjoDaHWJjcZSFiJwpZMxDw 2UfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713972982; x=1714577782; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UOeTFyyci3z7BUZ6gEboB6kicq7JHa28+x4pg4U/L9Q=; b=BET3Dj7usDpZDa8t5oMfnbuRs1ahjA8XWjD3xQ4iNiClbqoi3sFg8Z1QEYD9EvPYGe 0vy127RwJZQ/XEre4F2B+r9IXJ8Zr6fJkwaqkLT5hGz1aBhwBV/5uYpU52xIxbfCYj60 lPcoNHWSkMnzW3CT4q6KNtx3KWMKAmFbY3SVuPmJNQlB7adaCtcgSGiZbeD0QQB0L2zU eTcSmHWMZoNzHBgBpcadlOZrP6VOsmRgvVCKuHxxLi/RIdlVmDgYZoragAJYDvEenT/G NO9iTC1G9Hbf8YmPFMr8W+9EG9aT6QS4jDxqH34fXO9MqxxosGyI/wPpbBlIq4tfeXzL hIqg== X-Forwarded-Encrypted: i=1; AJvYcCVjMML1BbE6qrMQDTtUsJzjMd4Ea6VA3v9lQG1ORXuWX12gm11VC01WoQSq09Cb/Of5P1oGmxUTKSXhd3CdhlDzmrElFzbL7ZfkFg== X-Gm-Message-State: AOJu0Yyu3Rkytk3I/C2ylbd9/ZkrhGNRtoEDevZe5uaXhLUh2QHFayT3 Vwoyp+ieMfFQ5ECdH0yeCYv2Ar7lgf+cOJaD8g63IY0lRwT+2QqkPptM/TlamY4= X-Google-Smtp-Source: AGHT+IGUqY1hEYLyvR7VYD34HR40H5BCTS3NDhpEtJYnVydiqbsmxy3Dkl9KuCGBuZqe3HcyqLC03w== X-Received: by 2002:a0d:cc12:0:b0:618:88d1:f15f with SMTP id o18-20020a0dcc12000000b0061888d1f15fmr73152ywd.0.1713972982354; Wed, 24 Apr 2024 08:36:22 -0700 (PDT) Received: from ghost ([50.146.0.2]) by smtp.gmail.com with ESMTPSA id j82-20020a819255000000b0061ad72dd577sm2417745ywg.112.2024.04.24.08.36.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 08:36:21 -0700 (PDT) Date: Wed, 24 Apr 2024 11:36:19 -0400 From: Charlie Jenkins To: Conor Dooley Cc: Alexandre Ghiti , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Guo Ren , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Conor Dooley , Evan Green , =?iso-8859-1?Q?Cl=E9ment_L=E9ger?= , Jonathan Corbet , Shuah Khan , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Palmer Dabbelt , linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v3 06/17] riscv: Fix extension subset checking Message-ID: References: <20240420-dev-charlie-support_thead_vector_6_9-v3-0-67cff4271d1d@rivosinc.com> <20240420-dev-charlie-support_thead_vector_6_9-v3-6-67cff4271d1d@rivosinc.com> <6c624361-a968-498b-a9fb-ea2aaec70ce8@ghiti.fr> <20240424-wildly-goofy-c81aac6f8cd7@spud> <20240424-gondola-cosmic-b7a02b2a8619@spud> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240424-gondola-cosmic-b7a02b2a8619@spud> On Wed, Apr 24, 2024 at 04:21:05PM +0100, Conor Dooley wrote: > On Wed, Apr 24, 2024 at 11:13:40AM -0400, Charlie Jenkins wrote: > > On Wed, Apr 24, 2024 at 03:51:54PM +0100, Conor Dooley wrote: > > > On Wed, Apr 24, 2024 at 04:22:02PM +0200, Alexandre Ghiti wrote: > > > > Hi Charlie, > > > > > > > > On 21/04/2024 03:04, Charlie Jenkins wrote: > > > > > This loop is supposed to check if ext->subset_ext_ids[j] is valid, rather > > > > > than if ext->subset_ext_ids[i] is valid, before setting the extension > > > > > id ext->subset_ext_ids[j] in isainfo->isa. > > > > > > > > > > Signed-off-by: Charlie Jenkins > > > > > Reviewed-by: Conor Dooley > > > > > Fixes: 0d8295ed975b ("riscv: add ISA extension parsing for scalar crypto") > > > > > --- > > > > > arch/riscv/kernel/cpufeature.c | 2 +- > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > diff --git a/arch/riscv/kernel/cpufeature.c b/arch/riscv/kernel/cpufeature.c > > > > > index 48874aac4871..b537731cadef 100644 > > > > > --- a/arch/riscv/kernel/cpufeature.c > > > > > +++ b/arch/riscv/kernel/cpufeature.c > > > > > @@ -609,7 +609,7 @@ static int __init riscv_fill_hwcap_from_ext_list(unsigned long *isa2hwcap) > > > > > if (ext->subset_ext_size) { > > > > > for (int j = 0; j < ext->subset_ext_size; j++) { > > > > > - if (riscv_isa_extension_check(ext->subset_ext_ids[i])) > > > > > + if (riscv_isa_extension_check(ext->subset_ext_ids[j])) > > > > > set_bit(ext->subset_ext_ids[j], isainfo->isa); > > > > > } > > > > > } > > > > > > > > > > > > > I think this should go into -fixes, let's check with Palmer if he wants to > > > > take this patch only or if you should send the patch on its own. > > > > > > I think splitting out this and patch 1 into a new series targeting fixes > > > would probably make things clearer? > > > > Okay I can do that. I will give it a bit more time before I send this > > series split into two to allow time for the rest of the patches to > > gather comments so I avoid sending too many duplicate patches. > > Ye, I do hope to get back to this series later in the week when I have > time to actually read through all of the patches in detail. > > However, you wouldn't have to resend both parts of the series - you can > just split out the fixes portion and send that, leaving the rest of the > series sitting on the list to gather comments. Oh cool, I will send those two patches out in their own series then. - Charlie