From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A71AC15ADA2 for ; Wed, 24 Apr 2024 15:52:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713973954; cv=none; b=gCF3qGrrzTigseprO76djeeGlNM9QSjGT07xC122TNe8ygPRWVNu2j42isLQQps03yAFJFkxIVF1pQjutxJ8k9xjc36ndq+LH7F9ORYEE88frRF4Ye9jNgKa3YoJaC9GPtMut7t6kzAMdZYfsvGV8MQz8msysFokdZZAcD64fsI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713973954; c=relaxed/simple; bh=oo33Ekn8sNMAj8kE0HDHgjQpsSxVRvX5+mLw4VDaKTw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EWVCbcjDuNkQUV/T1OZvTVn4PbHWJpudOKed051DCG9d0ACPl9ewsQ8Ogvr9LJ+kfVTH9w4F7oPE2WmdcKx7oCodOy6khwHjyVkJ36XFXPG1YhVNqMj6RL2uo5DcZtI6jUd2lrXmt7Z8q5fklg3XUL/S1bHQzUiNROWe1/yL6Jc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Ta301A7l; arc=none smtp.client-ip=209.85.215.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Ta301A7l" Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-5e42b4bbfa4so4208885a12.1 for ; Wed, 24 Apr 2024 08:52:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713973952; x=1714578752; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=rrg8wwpA92kjivH0TKg4TZtfTIvVrn3ddePAYWoa0qw=; b=Ta301A7lDHfvZhNn8Yvri60QGrwM8ArewiyTL97NuO2+HFRd/C8sqIa8hjjVCfcbLL Qy2x+qrOnhXkI6qRV4zRcXkewFzl/YnNRqdryHXU3UHFwk91OaVmmZtr5PKwosMQfc0r rxxj07ddwo6TsJLJlZOwgdK+624PZOWgjxhWSEZ/FXlcsBdg1N8MraZsact/UTT/bJ6r slf3RhcKS7tT4U3DZfUN7OJow46+Vd/4v5YUvL47uKv0N3u3xKTAJYoUTwvcZGky9RoQ eueOoaWIwNaSO+C14JsLPbPPzG9fl5iWPabYkasUmHj1AFSbaq83bhNl7xa1wzKdy3eD vcdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713973952; x=1714578752; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rrg8wwpA92kjivH0TKg4TZtfTIvVrn3ddePAYWoa0qw=; b=WqAJOM5k4/tz5Av/DRUFUflLAMX8linBSG5LV19XY7we8OtEOJmmZP0jNSaFVCUEyY /Nrc5P0zaS4UHniyBiEtafoChOhoXyX1DWBl1BOSl9txlAemqnQk4wPkmG+4wGKY47L1 zIK6KDZdUJY8jiO+gE/pVFvaF+bkjAkZC75sTjBrPFnYMXDZYakO/Pfv6UUJwoVatdWs fhrrdP3bU8+30pi5Zw8sIHZEpTJauXMCeYLkUj7UntCNxBlptzOEdKn3luCgO5fER7Kq PbEL2Jt0955FbKzRsZkstIekKegZSH1u7prQLY+pB/Tdmu7Uh7EB5pHT4hdzjGbE0DgL yNPg== X-Forwarded-Encrypted: i=1; AJvYcCWCVKl4eRvePcVaYimkuGrtXLE04uXM8E+goPHYJUjgPJFEXgyf08jR7YyGoIJ1G/ZL/uxhS3rqqFU37LbO9ek5wN6Z+HJQUD4J7w== X-Gm-Message-State: AOJu0YwR2HWb+NJzbrAhBby3IJ7FH843mNe5L2sSXZzQHC+C32ASKfR0 igvOUJo6ogTAmzZRIiPPskptHBNX0b9UH9VH9BabGTZs3v7FSFV/0UO5rtoorMQ= X-Google-Smtp-Source: AGHT+IFJz2davFxl/umAykqWCqyRrrGNTJwfxgAOiKqEZ16/Hd7Gt5Q+2HCcbgUlPTtL3ULXGxROYQ== X-Received: by 2002:a05:6a21:33a0:b0:1aa:6167:b6d6 with SMTP id yy32-20020a056a2133a000b001aa6167b6d6mr3249147pzb.42.1713973951946; Wed, 24 Apr 2024 08:52:31 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:e523:8f5:a4a3:fdaf]) by smtp.gmail.com with ESMTPSA id v22-20020aa78516000000b006f03a06314esm11614021pfn.195.2024.04.24.08.52.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 08:52:31 -0700 (PDT) Date: Wed, 24 Apr 2024 09:52:28 -0600 From: Mathieu Poirier To: AngeloGioacchino Del Regno Cc: Olivia Wen , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , Tinghan Shen , linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com, jason-ch.chen@mediatek.com, yaya.chang@mediatek.com, teddy.chen@mediatek.com Subject: Re: [PATCH v3 4/4] media: mediatek: imgsys: Support image processing Message-ID: References: <20240424030351.5294-1-olivia.wen@mediatek.com> <20240424030351.5294-5-olivia.wen@mediatek.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Apr 24, 2024 at 12:04:54PM +0200, AngeloGioacchino Del Regno wrote: > Il 24/04/24 12:02, AngeloGioacchino Del Regno ha scritto: > > Il 24/04/24 05:03, Olivia Wen ha scritto: > > > Integrate the imgsys core architecture driver for image processing on > > > the MT8188 platform. > > > > > > Signed-off-by: Olivia Wen > > > > This should be reordered before introducing the 8188 scp core 1 support commit, > > but let's check with Mathieu before sending a v4. > > I don't have a strong preference. > > With that reordered, > > > > Reviewed-by: AngeloGioacchino Del Regno > > Wait, no. Sorry. I just noticed that the commit message is totally wrong. > > This is not a media commit, but remoteproc, and you're not adding support for > image processing with this commit - not in media at least. > Also, you're not adding any imgsys core architecture driver. > > Please fix both commit description and title. > I agree. > Regards, > Angelo > > > > > > --- > > >   include/linux/remoteproc/mtk_scp.h | 1 + > > >   1 file changed, 1 insertion(+) > > > > > > diff --git a/include/linux/remoteproc/mtk_scp.h b/include/linux/remoteproc/mtk_scp.h > > > index 7c2b7cc9..344ff41 100644 > > > --- a/include/linux/remoteproc/mtk_scp.h > > > +++ b/include/linux/remoteproc/mtk_scp.h > > > @@ -43,6 +43,7 @@ enum scp_ipi_id { > > >       SCP_IPI_CROS_HOST_CMD, > > >       SCP_IPI_VDEC_LAT, > > >       SCP_IPI_VDEC_CORE, > > > +    SCP_IPI_IMGSYS_CMD, > > >       SCP_IPI_NS_SERVICE = 0xFF, > > >       SCP_IPI_MAX = 0x100, > > >   }; > > >