* [PATCH] dt-bindings: iommu: renesas,ipmmu-vmsa: add r8a779h0 support
@ 2024-04-19 11:42 Geert Uytterhoeven
2024-04-22 0:20 ` Yoshihiro Shimoda
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2024-04-19 11:42 UTC (permalink / raw)
To: Joerg Roedel, Will Deacon, Robin Murphy, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Magnus Damm, Yoshihiro Shimoda
Cc: iommu, devicetree, linux-renesas-soc, Thanh Le,
Geert Uytterhoeven
From: Thanh Le <thanh.le.xv@renesas.com>
Document support for the I/O Memory Management Unit (IPMMU) on the
Renesas R-Car V4M (R8A779H0) SoC.
Signed-off-by: Thanh Le <thanh.le.xv@renesas.com>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Interestingly, the IMSSTR register is documented for R-Car V4M, unlike
for R-Car S4 and R-Car V4H, so the second cell of the renesas,ipmmu-main
property could be added again.
As nothing really uses this register and the associated bit numbers,
I think it is better to keep it simple, and not partially revert commit
b67ab6fb63bbbe6d ("dt-bindings: iommu: renesas, ipmmu-vmsa: Update for
R-Car Gen4").
---
Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml b/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
index be90f68c11d18b03..0acaa2bcec0898b2 100644
--- a/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
+++ b/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
@@ -50,6 +50,7 @@ properties:
- renesas,ipmmu-r8a779a0 # R-Car V3U
- renesas,ipmmu-r8a779f0 # R-Car S4-8
- renesas,ipmmu-r8a779g0 # R-Car V4H
+ - renesas,ipmmu-r8a779h0 # R-Car V4M
- const: renesas,rcar-gen4-ipmmu-vmsa # R-Car Gen4
reg:
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* RE: [PATCH] dt-bindings: iommu: renesas,ipmmu-vmsa: add r8a779h0 support
2024-04-19 11:42 [PATCH] dt-bindings: iommu: renesas,ipmmu-vmsa: add r8a779h0 support Geert Uytterhoeven
@ 2024-04-22 0:20 ` Yoshihiro Shimoda
2024-04-22 14:33 ` Rob Herring
2024-04-26 10:04 ` Joerg Roedel
2 siblings, 0 replies; 4+ messages in thread
From: Yoshihiro Shimoda @ 2024-04-22 0:20 UTC (permalink / raw)
To: Geert Uytterhoeven, Joerg Roedel, Will Deacon, Robin Murphy,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Magnus Damm
Cc: iommu@lists.linux.dev, devicetree@vger.kernel.org,
linux-renesas-soc@vger.kernel.org, Thanh Le
Hi Geert-san,
> From: Geert Uytterhoeven, Sent: Friday, April 19, 2024 8:42 PM
>
> From: Thanh Le <thanh.le.xv@renesas.com>
>
> Document support for the I/O Memory Management Unit (IPMMU) on the
> Renesas R-Car V4M (R8A779H0) SoC.
>
> Signed-off-by: Thanh Le <thanh.le.xv@renesas.com>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Interestingly, the IMSSTR register is documented for R-Car V4M, unlike
> for R-Car S4 and R-Car V4H, so the second cell of the renesas,ipmmu-main
> property could be added again.
> As nothing really uses this register and the associated bit numbers,
> I think it is better to keep it simple, and not partially revert commit
> b67ab6fb63bbbe6d ("dt-bindings: iommu: renesas, ipmmu-vmsa: Update for
> R-Car Gen4").
Thank you for the patch! I think so. So,
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Best regards,
Yoshihiro Shimoda
> ---
> Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
> b/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
> index be90f68c11d18b03..0acaa2bcec0898b2 100644
> --- a/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
> +++ b/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
> @@ -50,6 +50,7 @@ properties:
> - renesas,ipmmu-r8a779a0 # R-Car V3U
> - renesas,ipmmu-r8a779f0 # R-Car S4-8
> - renesas,ipmmu-r8a779g0 # R-Car V4H
> + - renesas,ipmmu-r8a779h0 # R-Car V4M
> - const: renesas,rcar-gen4-ipmmu-vmsa # R-Car Gen4
>
> reg:
> --
> 2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: iommu: renesas,ipmmu-vmsa: add r8a779h0 support
2024-04-19 11:42 [PATCH] dt-bindings: iommu: renesas,ipmmu-vmsa: add r8a779h0 support Geert Uytterhoeven
2024-04-22 0:20 ` Yoshihiro Shimoda
@ 2024-04-22 14:33 ` Rob Herring
2024-04-26 10:04 ` Joerg Roedel
2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2024-04-22 14:33 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Will Deacon, Magnus Damm, Joerg Roedel, Thanh Le,
Krzysztof Kozlowski, iommu, devicetree, Robin Murphy,
Yoshihiro Shimoda, Conor Dooley, linux-renesas-soc
On Fri, 19 Apr 2024 13:42:11 +0200, Geert Uytterhoeven wrote:
> From: Thanh Le <thanh.le.xv@renesas.com>
>
> Document support for the I/O Memory Management Unit (IPMMU) on the
> Renesas R-Car V4M (R8A779H0) SoC.
>
> Signed-off-by: Thanh Le <thanh.le.xv@renesas.com>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Interestingly, the IMSSTR register is documented for R-Car V4M, unlike
> for R-Car S4 and R-Car V4H, so the second cell of the renesas,ipmmu-main
> property could be added again.
> As nothing really uses this register and the associated bit numbers,
> I think it is better to keep it simple, and not partially revert commit
> b67ab6fb63bbbe6d ("dt-bindings: iommu: renesas, ipmmu-vmsa: Update for
> R-Car Gen4").
> ---
> Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: iommu: renesas,ipmmu-vmsa: add r8a779h0 support
2024-04-19 11:42 [PATCH] dt-bindings: iommu: renesas,ipmmu-vmsa: add r8a779h0 support Geert Uytterhoeven
2024-04-22 0:20 ` Yoshihiro Shimoda
2024-04-22 14:33 ` Rob Herring
@ 2024-04-26 10:04 ` Joerg Roedel
2 siblings, 0 replies; 4+ messages in thread
From: Joerg Roedel @ 2024-04-26 10:04 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Will Deacon, Robin Murphy, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Magnus Damm, Yoshihiro Shimoda, iommu, devicetree,
linux-renesas-soc, Thanh Le
On Fri, Apr 19, 2024 at 01:42:11PM +0200, Geert Uytterhoeven wrote:
> From: Thanh Le <thanh.le.xv@renesas.com>
>
> Document support for the I/O Memory Management Unit (IPMMU) on the
> Renesas R-Car V4M (R8A779H0) SoC.
>
> Signed-off-by: Thanh Le <thanh.le.xv@renesas.com>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-04-26 10:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-19 11:42 [PATCH] dt-bindings: iommu: renesas,ipmmu-vmsa: add r8a779h0 support Geert Uytterhoeven
2024-04-22 0:20 ` Yoshihiro Shimoda
2024-04-22 14:33 ` Rob Herring
2024-04-26 10:04 ` Joerg Roedel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).