public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Petar Stoykov <pd.pstoykov@gmail.com>
Cc: linux-iio@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Rob Herring <robh+dt@kernel.org>,
	Angel Iglesias <ang.iglesiasg@gmail.com>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 0/3] Add support for Sensirion SDP500
Date: Tue, 30 Apr 2024 18:37:14 +0300	[thread overview]
Message-ID: <ZjEQKqkWA66HtiD4@smile.fi.intel.com> (raw)
In-Reply-To: <CADFWO8EZWkXeAMcURgGGEmzVjiSxFTVAbKpsb2Qmv66EZiTc+A@mail.gmail.com>

On Tue, Apr 30, 2024 at 05:27:17PM +0200, Petar Stoykov wrote:
> From c4437fd0ea296c4c964b1fb924144ae24a2ce443 Mon Sep 17 00:00:00 2001
> From: Petar Stoykov <pd.pstoykov@gmail.com>
> Date: Mon, 29 Apr 2024 16:41:30 +0200
> Subject: [PATCH 0/3] Add support for Sensirion SDP500
> 
> This patch series

It's not. I mean from the email chaining perspective. Have you forgotten
to add --thread to git format-patch?

Also, what is that in above?

> introduces support for Sensirion SDP500 in the IIO
> subsystem. The series is split into three patches:
> 
> 1. The first patch adds the device tree bindings.
> 2. The second patch implements the device driver.
> 3. The third patch updates the MAINTAINERS file.
> 
> The driver is relatively simple. It provides a way to read the measured
> differential pressure directly in Pa, as the device has a fixed scale
> factor of 1/60. When an applications wants to read the pressure value,
> 3 bytes are read from the device, 2 are data and 1 is CRC8. If the crc
> check passes, the calculated pressure value is returned in Pa units.
> 
> The initialization of the device just starts the measurement process.
> 
> We have been using this device and driver in a product development for
> almost a year now. There the pressure is read every 25ms and is used in a
> control loop. We have not even seen crc errors. We are using the
> "linux-imx" repository and not the mainline one but I see no risky kernel
> functions in use so it should be fine here too.
> 
> All feedback is appreciated! Thank you for taking the time to review this.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2024-04-30 15:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-30 15:27 [PATCH v2 0/3] Add support for Sensirion SDP500 Petar Stoykov
2024-04-30 15:37 ` Andy Shevchenko [this message]
2024-04-30 16:45   ` Conor Dooley
2024-05-01 10:47     ` Petar Stoykov
2024-05-01 16:39       ` Conor Dooley
2024-05-01  9:45 ` Krzysztof Kozlowski
2024-05-01 10:58   ` Petar Stoykov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZjEQKqkWA66HtiD4@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=ang.iglesiasg@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pd.pstoykov@gmail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox