Re: [PATCH 3/3] phy: airoha: Add PCIe PHY driver for EN7581 SoC.

[Lorenzo Bianconi <lorenzo@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 3030 bytes --]

> Il 12/05/24 17:27, Lorenzo Bianconi ha scritto:
> > Introduce support for Airoha PCIe PHY controller available in EN7581
> > SoC.
> > 
> > Tested-by: Zhengping Zhang <zhengping.zhang@airoha.com>
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > ---
> >   MAINTAINERS                        |    8 +
> >   arch/arm64/configs/defconfig       |    1 +
> >   drivers/phy/Kconfig                |   10 +
> >   drivers/phy/Makefile               |    1 +
> >   drivers/phy/phy-airoha-pcie-regs.h |  476 +++++++++++
> >   drivers/phy/phy-airoha-pcie.c      | 1227 ++++++++++++++++++++++++++++
> >   6 files changed, 1723 insertions(+)
> >   create mode 100644 drivers/phy/phy-airoha-pcie-regs.h
> >   create mode 100644 drivers/phy/phy-airoha-pcie.c
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index ce9fac46f741..d918d41a80a3 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -653,6 +653,14 @@ S:	Supported
> >   F:	fs/aio.c
> >   F:	include/linux/*aio*.h
> > +AIROHA PCIE PHY DRIVER
> > +M:	Lorenzo Bianconi <lorenzo@kernel.org>
> > +L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
> > +S:	Maintained
> > +F:	Documentation/devicetree/bindings/phy/airoha,pcie-phy.yaml
> > +F:	drivers/phy/phy-airoha-pcie-regs.h
> > +F:	drivers/phy/phy-airoha-pcie.c
> > +
> >   AIROHA SPI SNFI DRIVER
> >   M:	Lorenzo Bianconi <lorenzo@kernel.org>
> >   M:	Ray Liu <ray.liu@airoha.com>
> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index a53c58584bcf..c0eacced5d41 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> 
> No, this should be in a different commit.

ack, I will do in v2

> 
> > @@ -1479,6 +1479,7 @@ CONFIG_RESET_QCOM_AOSS=y
> >   CONFIG_RESET_QCOM_PDC=m
> >   CONFIG_RESET_RZG2L_USBPHY_CTRL=y
> >   CONFIG_RESET_TI_SCI=y
> > +CONFIG_PHY_AIROHA_PCIE=y
> >   CONFIG_PHY_XGENE=y
> >   CONFIG_PHY_CAN_TRANSCEIVER=m
> >   CONFIG_PHY_SUN4I_USB=y
> > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> > index 787354b849c7..8f9a7a6c4bba 100644
> > --- a/drivers/phy/Kconfig
> > +++ b/drivers/phy/Kconfig
> > @@ -72,6 +72,16 @@ config PHY_CAN_TRANSCEIVER
> >   	  functional modes using gpios and sets the attribute max link
> >   	  rate, for CAN drivers.
> > +config PHY_AIROHA_PCIE
> > +	tristate "Airoha PCIe-PHY Driver"
> > +	depends on ARCH_AIROHA || COMPILE_TEST
> > +	depends on OF
> > +	select GENERIC_PHY
> > +	help
> > +	  Say 'Y' here to add support for Airoha PCIe PHY driver.
> 
> Say Y here (without quotes)

ack, I will fix in v2

Regards,
Lorenzo

> 
> Apart from that:
> 
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> 
> > +	  This driver create the basic PHY instance and provides initialize
> > +	  callback for PCIe GEN3 port.
> > +
> >   source "drivers/phy/allwinner/Kconfig"
> >   source "drivers/phy/amlogic/Kconfig"
> >   source "drivers/phy/broadcom/Kconfig"
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]