From: Andy Shevchenko <andy@kernel.org>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Alisa-Dariana Roman <alisadariana@gmail.com>,
Jonathan Cameron <jic23@kernel.org>,
michael.hennerich@analog.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
lars@metafoo.de, robh@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
lgirdwood@gmail.com, broonie@kernel.org, nuno.sa@analog.com,
marcelo.schmitt@analog.com, bigunclemax@gmail.com,
dlechner@baylibre.com, okan.sahin@analog.com,
fr0st61te@gmail.com, alisa.roman@analog.com,
marcus.folkesson@gmail.com, schnelle@linux.ibm.com,
liambeguin@gmail.com
Subject: Re: [PATCH v8 6/6] iio: adc: ad7192: Add AD7194 support
Date: Mon, 20 May 2024 15:28:20 +0300 [thread overview]
Message-ID: <ZktB5Ex5oQ2E45QR@smile.fi.intel.com> (raw)
In-Reply-To: <20240520132030.00000838@Huawei.com>
On Mon, May 20, 2024 at 01:20:30PM +0100, Jonathan Cameron wrote:
> On Sun, 19 May 2024 22:37:58 +0300
> Alisa-Dariana Roman <alisadariana@gmail.com> wrote:
> > On 19.05.2024 21:03, Jonathan Cameron wrote:
...
> > +static bool ad7194_validate_ain_channel(struct device *dev, u32 ain)
> > +{
> > + return in_range(ain, AD7194_CH_AIN_START, AD7194_CH_AIN_NR);
> > +}
> > And the negation got lost here.
>
> Ouch :(
And negation most likely should be on the caller's side.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-05-20 12:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-14 12:02 [PATCH v8 0/6] iio: adc: ad7192: Add AD7194 support Alisa-Dariana Roman
2024-05-14 12:02 ` [PATCH v8 1/6] iio: adc: ad7192: Use standard attribute Alisa-Dariana Roman
2024-05-19 17:45 ` Jonathan Cameron
2024-05-14 12:02 ` [PATCH v8 2/6] dt-bindings: iio: adc: ad7192: Add aincom supply Alisa-Dariana Roman
2024-05-19 17:54 ` Jonathan Cameron
2024-05-14 12:02 ` [PATCH v8 3/6] " Alisa-Dariana Roman
2024-05-14 13:13 ` Andy Shevchenko
2024-05-19 17:53 ` Jonathan Cameron
2024-05-14 12:02 ` [PATCH v8 4/6] dt-bindings: iio: adc: Add single-channel property Alisa-Dariana Roman
2024-05-14 18:57 ` Conor Dooley
2024-05-14 12:02 ` [PATCH v8 5/6] dt-bindings: iio: adc: ad7192: Add AD7194 support Alisa-Dariana Roman
2024-05-14 18:58 ` Conor Dooley
2024-05-14 12:02 ` [PATCH v8 6/6] " Alisa-Dariana Roman
2024-05-14 13:09 ` Andy Shevchenko
2024-05-19 18:03 ` Jonathan Cameron
2024-05-19 19:37 ` Alisa-Dariana Roman
2024-05-20 12:20 ` Jonathan Cameron
2024-05-20 12:28 ` Andy Shevchenko [this message]
2024-05-22 9:50 ` [PATCH] fix Alisa-Dariana Roman
2024-05-25 16:35 ` Jonathan Cameron
2024-05-14 13:14 ` [PATCH v8 0/6] iio: adc: ad7192: Add AD7194 support Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZktB5Ex5oQ2E45QR@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=alisa.roman@analog.com \
--cc=alisadariana@gmail.com \
--cc=bigunclemax@gmail.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=fr0st61te@gmail.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=liambeguin@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt@analog.com \
--cc=marcus.folkesson@gmail.com \
--cc=michael.hennerich@analog.com \
--cc=nuno.sa@analog.com \
--cc=okan.sahin@analog.com \
--cc=robh@kernel.org \
--cc=schnelle@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).