From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 009F53B2A2 for ; Fri, 24 May 2024 18:13:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716574385; cv=none; b=uGborkEXbSHjlOiMNLAh29o1za1SraD4KDedG0EzcDlIRjDnnL0/z5NEzzgJYykeTmXNGwf2esvhxCghBVUqu6nYLBQTAXqA1pQ6rQkb2L1xUDTPi8mehgLGYkkUKcnpftyfZV2Sv86wcjYLsb+19vUI19/fkxFduTDM2RSg4TM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716574385; c=relaxed/simple; bh=6YjW4gPlBJUm+qGoxCi73uLtqlLtfdqeWevPkQB22lc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ciaF6qTIdBU7XWgKMdNwuSAVdC/jL9t+sh8hrSbTVw84J2Ht24KBFz16jsecT0FxOgetRa6NjkDryVf833N1C97z9qtFXrOXFdYdgqBttbhULfuhIzwoNTUxvl4NCmTs0F6nkx2sxu130oW7jJt2gTaYYQjKryGWmvOVZw2stZs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ferroamp.se; spf=fail smtp.mailfrom=ferroamp.se; dkim=pass (2048-bit key) header.d=ferroamp-se.20230601.gappssmtp.com header.i=@ferroamp-se.20230601.gappssmtp.com header.b=gq4HrcxL; arc=none smtp.client-ip=209.85.208.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ferroamp.se Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=ferroamp.se Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ferroamp-se.20230601.gappssmtp.com header.i=@ferroamp-se.20230601.gappssmtp.com header.b="gq4HrcxL" Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-2e724bc46bfso74632611fa.3 for ; Fri, 24 May 2024 11:13:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ferroamp-se.20230601.gappssmtp.com; s=20230601; t=1716574381; x=1717179181; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=PAb4E/ylNY4nYQpT5wwWxISxDYgnB6L1bhxHr5GF4gY=; b=gq4HrcxLbKcxY4xGNxp/Wu5SbfLAYE356WysmVfak2yJxK1BspdOUQ+nAqg5tB0D4P iv7L7bBRRealMxEwq53JkLg020P8VpKLo5M/G6x4Jzkr6uHMXWaOIwAPeF5KN0wtb7Ok xvKyMrdMt6htLQmd5Axqw7miYa2HWikILGcugvB/K4k9T981yrb0cch5FM7k1csFZpgQ +tOvDhJfoiyZCUq0Bm+og2RKbo6U9AWXQUwAfVs494bWacPorBIcQwmIVSzapJvG/amB SjFNMzsh3ssKOvtk3udQo1MCyRIGkfXO778MlMxr1zwYTS5Fw7euwy45Xq7lGH8xQdMJ GuGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716574381; x=1717179181; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PAb4E/ylNY4nYQpT5wwWxISxDYgnB6L1bhxHr5GF4gY=; b=tpf7tMZhCAYN350M1EplqVgW7KF+ag0IpCgu06b/W4qmnigeU2IpeOixb9m2UV0GZM Vp6YKBU1LyAX4xhnWUnP1eUg3seROK7S4E2K3PfX89vLi2VWgFDMwOmEqfRwaMc3WA8T AXQhViDiiV8VwxIaqQqUjRlhgVQ5QM+F2QuqN8roL1XDb59zXe5Tr7zOStuwYCCTe+Ka Mfz4KlOH/gHtACrD0sYgPIRAvxhsjdRJsXHHtmSn5o+MmczfnXLIt5QXVhL77KzFyd6D mgKAsyowrWbc7130VR4rm+PI8sqLYnz5911TjMhYrROLx/1yVFKIvJ00ziFTmM5b+Nq9 y7Kg== X-Forwarded-Encrypted: i=1; AJvYcCVpt8DOixs/9Gkbk0YVvbIm6xzutjbw0FKYWC2gaLI4AN0HjIva31I3ZgId2+LpWBVPjLpMwXCmztSyWhx6mSr4/toYFOzhhXPYiw== X-Gm-Message-State: AOJu0YykF0SXt6N5IsJOUgjsACAybGjCDrlehJtp5xEd9JOuWRMa3C5d ryirOAdhY4kr032lql/Uqla7jc7dG48WNNrhx3eOEgzPo61eMdR+ov706Xsv3VE= X-Google-Smtp-Source: AGHT+IGquvASHix50Y6m7trq1iJckrrLIxXAt0DDnEtvLQfEYyKMu5W3KCNL43t4St1VdKAYYOiaXA== X-Received: by 2002:a05:651c:10a5:b0:2e7:f9a4:ee07 with SMTP id 38308e7fff4ca-2e95b280f73mr19336131fa.53.1716574380842; Fri, 24 May 2024 11:13:00 -0700 (PDT) Received: from minibuilder (c83-249-74-52.bredband.tele2.se. [83.249.74.52]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2e95bdcd234sm2874081fa.99.2024.05.24.11.12.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 May 2024 11:13:00 -0700 (PDT) Date: Fri, 24 May 2024 20:12:58 +0200 From: =?iso-8859-1?Q?Ram=F3n?= Nordin Rodriguez To: Parthiban.Veerasooran@microchip.com Cc: andrew@lunn.ch, Pier.Beruto@onsemi.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, saeedm@nvidia.com, anthony.l.nguyen@intel.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, corbet@lwn.net, linux-doc@vger.kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org, Horatiu.Vultur@microchip.com, ruanjinjie@huawei.com, Steen.Hegelund@microchip.com, vladimir.oltean@nxp.com, UNGLinuxDriver@microchip.com, Thorsten.Kummermehr@microchip.com, Selvamani.Rajagopal@onsemi.com, Nicolas.Ferre@microchip.com, benjamin.bigler@bernformulastudent.ch Subject: Re: [PATCH net-next v4 05/12] net: ethernet: oa_tc6: implement error interrupts unmasking Message-ID: References: <708d29de-b54a-40a4-8879-67f6e246f851@lunn.ch> <6e4207cd-2bd5-4f5b-821f-bc87c1296367@microchip.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: > >>>> Is it doing this in an endless cycle? > >>> > >>> Exactly, so what I'm seeing is when the driver livelocks the macphy is > >>> periodically pulling the irq pin low, the driver clears the interrupt > >>> and repeat. > >> If I understand correctly, you are keep on getting interrupt without > >> indicating anything in the footer?. Are you using LAN8650 Rev.B0 or B1?. > >> If it is B0 then can you try with Rev.B1 once? > >> After a considerable ammount of headscratching it seems that disabling collision detection on the macphy is the only way of getting it stable. When PLCA is enabled it's expected that CD causes problems, when running in CSMA/CD mode it was unexpected (for me at least). Disabling collision detection was discussed here https://lore.kernel.org/netdev/20231127104045.96722-1-ramon.nordin.rodriguez@ferroamp.se/ in a patchset that I haven't gotten around to testing through properly and fixing up, but now it's definetly a priority. Rev.b0 and b1 gives similar results in this domain, though I'm getting lower throughput and it's easier/faster to get the internal error state on rev.b1. When CD is disabled both chip revs seems stable in all of my testing. > > > > I'll check the footer content, thanks for the tip! > > > > All testing has bee done with Rev.B0, we've located a set of B1 chips. > > So we'll get on resoldering and rerunning the test scenario. > Thanks for the consideration. But be informed that the internal PHY > initial settings are updated for the Rev.B1. But the one from the > mainline still supports for Rev.B0. So that microchip_t1s.c to be > updated to support Rev.B1. I posted a suggestion for how to bringup rev.b1 https://lore.kernel.org/netdev/20240524140706.359537-1-ramon.nordin.rodriguez@ferroamp.se/ I should have prefaced the cover letter with 'ugly hacks ahead'. > > Also I am in talk with our design team that whether the updated initial > settings for B1 are also applicable for B0. If so, then we will have > only one updated initial setting which supports both B0 and B1. Any update on this? I will submit a new revision of the lan8670 revc + disable collision detection pathset where CD is disabled regardless of operating mode. R