From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fgw23-7.mail.saunalahti.fi (fgw23-7.mail.saunalahti.fi [62.142.5.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 687F523BF for ; Tue, 28 May 2024 19:41:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.142.5.84 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716925316; cv=none; b=UT76cPXKPmou+SIabSTMLmNf2dyPepFRcoDAz1jW9nh//atAlC78hHCKOqKhJG4Bhx//9D8XimbYnPM0THoKlkLA1Ly36ME2DFYZmitJYwj0dwiP1FtTCNa3FqdcbwibX1fMrlr+r+iOaJ5zlKNm+zj9EKUgzO3LMgj/m2qt+RQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716925316; c=relaxed/simple; bh=XL5XfZPSAColagJjESsQyLbsnaVT0FBnyZJo1Q2iBzs=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=k59fdhOnPNxguZdAtipj2EumXNviy1Fr59mL/fvriGLUvnsgN6ePRAHj6bE50cP5KKU9151kKYH76n5Zf3zmnMoA2/y/k/aPdCRxYtCjonQRphozuYIIAf9zL0RYXOcimAwjj+4GFb/vjt1PSosszHIP87RmUJycwan7mBTfadk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com; spf=fail smtp.mailfrom=gmail.com; arc=none smtp.client-ip=62.142.5.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=gmail.com Received: from localhost (88-113-26-230.elisa-laajakaista.fi [88.113.26.230]) by fgw21.mail.saunalahti.fi (Halon) with ESMTP id 54d390ee-1d2a-11ef-aaf5-005056bdd08f; Tue, 28 May 2024 22:41:52 +0300 (EEST) From: Andy Shevchenko Date: Tue, 28 May 2024 22:41:51 +0300 To: Laurent Pinchart Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org, Alexandru Ardelean , Bartosz Golaszewski , Conor Dooley , Krzysztof Kozlowski , Lee Jones , Linus Walleij , Rob Herring , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Clark Wang Subject: Re: [PATCH v2 4/4] pwm: adp5585: Add Analog Devices ADP5585 support Message-ID: References: <20240528190315.3865-1-laurent.pinchart@ideasonboard.com> <20240528190315.3865-5-laurent.pinchart@ideasonboard.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240528190315.3865-5-laurent.pinchart@ideasonboard.com> Tue, May 28, 2024 at 10:03:14PM +0300, Laurent Pinchart kirjoitti: > From: Clark Wang > > The ADP5585 is a 10/11 input/output port expander with a built in keypad > matrix decoder, programmable logic, reset generator, and PWM generator. > This driver supports the PWM function using the platform device > registered by the core MFD driver. > > The driver is derived from an initial implementation from NXP, available > in commit 113113742208 ("MLK-25922-1 pwm: adp5585: add adp5585 PWM > support") in their BSP kernel tree. It has been extensively rewritten. ... > +#include + err.h > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include ... > +#define ADP5585_PWM_OSC_FREQ_HZ 1000000U (1 * HZ_PER_MHZ) ? > +#define ADP5585_PWM_MIN_PERIOD_NS (2ULL * NSEC_PER_SEC / ADP5585_PWM_OSC_FREQ_HZ) > +#define ADP5585_PWM_MAX_PERIOD_NS (2ULL * 0xffff * NSEC_PER_SEC / ADP5585_PWM_OSC_FREQ_HZ) Wouldn't be better to use GENMASK() or (BIT(x) - 1) notation to show that the limit is due to HW register bits in use? ... > + ret = regmap_write(regmap, ADP5585_PWM_OFFT_LOW, > + off & 0xff); > + if (ret) > + return ret; > + ret = regmap_write(regmap, ADP5585_PWM_OFFT_HIGH, > + (off >> 8) & 0xff); > + if (ret) > + return ret; > + ret = regmap_write(regmap, ADP5585_PWM_ONT_LOW, > + on & 0xff); > + if (ret) > + return ret; > + ret = regmap_write(regmap, ADP5585_PWM_ONT_HIGH, > + (on >> 8) & 0xff); > + if (ret) > + return ret; Can be proper __le16/__be16 be used in conjunction with regmap bulk API? ... > + /* Enable PWM in continuous mode and no external AND'ing. */ > + ret = regmap_update_bits(regmap, ADP5585_PWM_CFG, > + ADP5585_PWM_IN_AND | ADP5585_PWM_MODE | > + ADP5585_PWM_EN, ADP5585_PWM_EN); > + if (ret) > + return ret; > + > + return 0; return regmap_update_bits(...); ... > + regmap_read(regmap, ADP5585_PWM_OFFT_LOW, &off); > + regmap_read(regmap, ADP5585_PWM_OFFT_HIGH, &val); > + off |= val << 8; > + > + regmap_read(regmap, ADP5585_PWM_ONT_LOW, &on); > + regmap_read(regmap, ADP5585_PWM_ONT_HIGH, &val); > + on |= val << 8; As per above, can it be converted to use proper __le16/__be16 type and regmap bulk API? ... > + device_set_of_node_from_dev(dev, dev->parent); Why this one? What's wrong with device_set_node()? -- With Best Regards, Andy Shevchenko