Re: [PATCH net-next 2/3] arm64: dts: airoha: Add EN7581 ethernet node

[Lorenzo Bianconi <lorenzo@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1350 bytes --]

> On Sun, Jun 02, 2024 at 07:38:17PM +0200, Lorenzo Bianconi wrote:
> > > On Fri, May 31, 2024 at 12:22:19PM +0200, Lorenzo Bianconi wrote:
> > > > Introduce the Airoha EN7581 ethernet node in Airoha EN7581 dtsi
> > > > 
> > > > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > > > ---
> > > >  arch/arm64/boot/dts/airoha/en7581-evb.dts |  4 +++
> > > >  arch/arm64/boot/dts/airoha/en7581.dtsi    | 31 +++++++++++++++++++++++
> > > >  2 files changed, 35 insertions(+)
> > > > 
> > > > diff --git a/arch/arm64/boot/dts/airoha/en7581-evb.dts b/arch/arm64/boot/dts/airoha/en7581-evb.dts
> > > > index cf58e43dd5b2..82da86ae00b0 100644
> > > > --- a/arch/arm64/boot/dts/airoha/en7581-evb.dts
> > > > +++ b/arch/arm64/boot/dts/airoha/en7581-evb.dts
> > > > @@ -24,3 +24,7 @@ memory@80000000 {
> > > >  		reg = <0x0 0x80000000 0x2 0x00000000>;
> > > >  	};
> > > >  };
> > > > +
> > > > +&eth0 {
> > > > +	status = "okay";
> > > > +};
> > > 
> > > Is that enough to make it useful? Don't you need a phy-handle, or
> > > phy-mode?
> > 
> > This changes is actually in a subsequent patch (not posted yet) where I will
> > add support for the mt7530 dsa switch. Do you prefer to add it here?
> 
> I would prefer you move this later when you add the switch.

ack, I will do in v2.

Regards,
Lorenzo

> 
> 	Andrew

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]