devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm: dts: imx53-qsb-hdmi: Disable panel instead of deleting node
@ 2024-05-14  3:07 Liu Ying
  2024-06-02 10:40 ` Dmitry Baryshkov
  2024-06-15  8:07 ` Shawn Guo
  0 siblings, 2 replies; 3+ messages in thread
From: Liu Ying @ 2024-05-14  3:07 UTC (permalink / raw)
  To: imx, devicetree, linux-arm-kernel, linux-kernel
  Cc: robh, krzk+dt, conor+dt, shawnguo, s.hauer, kernel, festevam,
	dmitry.baryshkov

We cannot use /delete-node/ directive to delete a node in a DT
overlay.  The node won't be deleted effectively.  Instead, set
the node's status property to "disabled" to achieve something
similar.

Fixes: eeb403df953f ("ARM: dts: imx53-qsb: add support for the HDMI expander")
Signed-off-by: Liu Ying <victor.liu@nxp.com>
---
 arch/arm/boot/dts/nxp/imx/imx53-qsb-common.dtsi | 2 +-
 arch/arm/boot/dts/nxp/imx/imx53-qsb-hdmi.dtso   | 6 ++++--
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx53-qsb-common.dtsi b/arch/arm/boot/dts/nxp/imx/imx53-qsb-common.dtsi
index d80440446473..05d7a462ea25 100644
--- a/arch/arm/boot/dts/nxp/imx/imx53-qsb-common.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx53-qsb-common.dtsi
@@ -85,7 +85,7 @@ led-user {
 		};
 	};
 
-	panel {
+	panel_dpi: panel {
 		compatible = "sii,43wvf1g";
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_display_power>;
diff --git a/arch/arm/boot/dts/nxp/imx/imx53-qsb-hdmi.dtso b/arch/arm/boot/dts/nxp/imx/imx53-qsb-hdmi.dtso
index c84e9b052527..151e9cee3c87 100644
--- a/arch/arm/boot/dts/nxp/imx/imx53-qsb-hdmi.dtso
+++ b/arch/arm/boot/dts/nxp/imx/imx53-qsb-hdmi.dtso
@@ -10,8 +10,6 @@
 /plugin/;
 
 &{/} {
-	/delete-node/ panel;
-
 	hdmi: connector-hdmi {
 		compatible = "hdmi-connector";
 		label = "hdmi";
@@ -82,6 +80,10 @@ sii9022_out: endpoint {
 	};
 };
 
+&panel_dpi {
+	status = "disabled";
+};
+
 &tve {
 	status = "disabled";
 };
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm: dts: imx53-qsb-hdmi: Disable panel instead of deleting node
  2024-05-14  3:07 [PATCH] arm: dts: imx53-qsb-hdmi: Disable panel instead of deleting node Liu Ying
@ 2024-06-02 10:40 ` Dmitry Baryshkov
  2024-06-15  8:07 ` Shawn Guo
  1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2024-06-02 10:40 UTC (permalink / raw)
  To: Liu Ying
  Cc: imx, devicetree, linux-arm-kernel, linux-kernel, robh, krzk+dt,
	conor+dt, shawnguo, s.hauer, kernel, festevam

On Tue, 14 May 2024 at 05:59, Liu Ying <victor.liu@nxp.com> wrote:
>
> We cannot use /delete-node/ directive to delete a node in a DT
> overlay.  The node won't be deleted effectively.  Instead, set
> the node's status property to "disabled" to achieve something
> similar.
>
> Fixes: eeb403df953f ("ARM: dts: imx53-qsb: add support for the HDMI expander")
> Signed-off-by: Liu Ying <victor.liu@nxp.com>
> ---
>  arch/arm/boot/dts/nxp/imx/imx53-qsb-common.dtsi | 2 +-
>  arch/arm/boot/dts/nxp/imx/imx53-qsb-hdmi.dtso   | 6 ++++--
>  2 files changed, 5 insertions(+), 3 deletions(-)

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm: dts: imx53-qsb-hdmi: Disable panel instead of deleting node
  2024-05-14  3:07 [PATCH] arm: dts: imx53-qsb-hdmi: Disable panel instead of deleting node Liu Ying
  2024-06-02 10:40 ` Dmitry Baryshkov
@ 2024-06-15  8:07 ` Shawn Guo
  1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2024-06-15  8:07 UTC (permalink / raw)
  To: Liu Ying
  Cc: imx, devicetree, linux-arm-kernel, linux-kernel, robh, krzk+dt,
	conor+dt, shawnguo, s.hauer, kernel, festevam, dmitry.baryshkov

On Tue, May 14, 2024 at 11:07:18AM +0800, Liu Ying wrote:
> We cannot use /delete-node/ directive to delete a node in a DT
> overlay.  The node won't be deleted effectively.  Instead, set
> the node's status property to "disabled" to achieve something
> similar.
> 
> Fixes: eeb403df953f ("ARM: dts: imx53-qsb: add support for the HDMI expander")
> Signed-off-by: Liu Ying <victor.liu@nxp.com>

Applied, thanks!


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-06-15  8:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-14  3:07 [PATCH] arm: dts: imx53-qsb-hdmi: Disable panel instead of deleting node Liu Ying
2024-06-02 10:40 ` Dmitry Baryshkov
2024-06-15  8:07 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).