* [PATCH] dts: imx8mq-librem5: Don't wake up on volume key press
@ 2024-05-20 10:57 Guido Günther
2024-06-10 10:17 ` Martin Kepplinger
2024-06-15 8:29 ` Shawn Guo
0 siblings, 2 replies; 3+ messages in thread
From: Guido Günther @ 2024-05-20 10:57 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, devicetree,
imx, linux-arm-kernel, linux-kernel, phone-devel, kernel,
Martin Kepplinger
The only key that should wake up the phone is power button press. This
prevents accidental wakeup due to e.g. pressing the buttons in the
pocket or backpack and is in line what userspace uses to unblank the
device.
Signed-off-by: Guido Günther <agx@sigxcpu.org>
---
arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
index ffb5fe61630d..1b39514d5c12 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
@@ -45,7 +45,6 @@ key-vol-down {
gpios = <&gpio1 17 GPIO_ACTIVE_LOW>;
linux,code = <KEY_VOLUMEDOWN>;
debounce-interval = <50>;
- wakeup-source;
};
key-vol-up {
@@ -53,7 +52,6 @@ key-vol-up {
gpios = <&gpio1 16 GPIO_ACTIVE_LOW>;
linux,code = <KEY_VOLUMEUP>;
debounce-interval = <50>;
- wakeup-source;
};
};
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dts: imx8mq-librem5: Don't wake up on volume key press
2024-05-20 10:57 [PATCH] dts: imx8mq-librem5: Don't wake up on volume key press Guido Günther
@ 2024-06-10 10:17 ` Martin Kepplinger
2024-06-15 8:29 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Martin Kepplinger @ 2024-06-10 10:17 UTC (permalink / raw)
To: Guido Günther, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, devicetree, imx, linux-arm-kernel, linux-kernel,
phone-devel, kernel
Am Montag, dem 20.05.2024 um 12:57 +0200 schrieb Guido Günther:
> The only key that should wake up the phone is power button press.
> This
> prevents accidental wakeup due to e.g. pressing the buttons in the
> pocket or backpack and is in line what userspace uses to unblank the
> device.
>
> Signed-off-by: Guido Günther <agx@sigxcpu.org>
Reviewed-by: Martin Kepplinger <martink@posteo.de>
thank you,
martin
> ---
> arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> index ffb5fe61630d..1b39514d5c12 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> @@ -45,7 +45,6 @@ key-vol-down {
> gpios = <&gpio1 17 GPIO_ACTIVE_LOW>;
> linux,code = <KEY_VOLUMEDOWN>;
> debounce-interval = <50>;
> - wakeup-source;
> };
>
> key-vol-up {
> @@ -53,7 +52,6 @@ key-vol-up {
> gpios = <&gpio1 16 GPIO_ACTIVE_LOW>;
> linux,code = <KEY_VOLUMEUP>;
> debounce-interval = <50>;
> - wakeup-source;
> };
> };
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dts: imx8mq-librem5: Don't wake up on volume key press
2024-05-20 10:57 [PATCH] dts: imx8mq-librem5: Don't wake up on volume key press Guido Günther
2024-06-10 10:17 ` Martin Kepplinger
@ 2024-06-15 8:29 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2024-06-15 8:29 UTC (permalink / raw)
To: Guido Günther
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, devicetree,
imx, linux-arm-kernel, linux-kernel, phone-devel, kernel,
Martin Kepplinger
On Mon, May 20, 2024 at 12:57:05PM +0200, Guido Günther wrote:
> The only key that should wake up the phone is power button press. This
> prevents accidental wakeup due to e.g. pressing the buttons in the
> pocket or backpack and is in line what userspace uses to unblank the
> device.
>
> Signed-off-by: Guido Günther <agx@sigxcpu.org>
'arm64: dts: ...' for subject prefix.
Fixed it up and applied, thanks!
Shawn
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-06-15 8:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-20 10:57 [PATCH] dts: imx8mq-librem5: Don't wake up on volume key press Guido Günther
2024-06-10 10:17 ` Martin Kepplinger
2024-06-15 8:29 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).