devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: nxp: imx6: convert NVMEM content to layout syntax
@ 2024-05-20  6:02 Rafał Miłecki
  2024-06-15  8:26 ` Shawn Guo
  2024-06-27  6:11 ` Shawn Guo
  0 siblings, 2 replies; 4+ messages in thread
From: Rafał Miłecki @ 2024-05-20  6:02 UTC (permalink / raw)
  To: Shawn Guo, Sascha Hauer, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: Pengutronix Kernel Team, Fabio Estevam, devicetree, imx,
	linux-arm-kernel, Rafał Miłecki

From: Rafał Miłecki <rafal@milecki.pl>

Use cleaner (and non-deprecated) bindings syntax. See commit
bd912c991d2e ("dt-bindings: nvmem: layouts: add fixed-layout") for
details.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 arch/arm/boot/dts/nxp/imx/imx6qdl-mba6a.dtsi | 12 ++++++++----
 arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi | 12 ++++++++----
 2 files changed, 16 insertions(+), 8 deletions(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6a.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6a.dtsi
index 238f3af42822..807f3c95e3ce 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6a.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6a.dtsi
@@ -22,12 +22,16 @@ m24c64_57: eeprom@57 {
 		compatible = "atmel,24c64";
 		reg = <0x57>;
 		pagesize = <32>;
-		#address-cells = <1>;
-		#size-cells = <1>;
 		vcc-supply = <&reg_mba6_3p3v>;
 
-		mba_mac_address: mac-address@20 {
-			reg = <0x20 0x6>;
+		nvmem-layout {
+			compatible = "fixed-layout";
+			#address-cells = <1>;
+			#size-cells = <1>;
+
+			mba_mac_address: mac-address@20 {
+				reg = <0x20 0x6>;
+			};
 		};
 	};
 
diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi
index a587bc88f76f..789733a45b95 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi
@@ -32,12 +32,16 @@ m24c64_57: eeprom@57 {
 		compatible = "atmel,24c64";
 		reg = <0x57>;
 		pagesize = <32>;
-		#address-cells = <1>;
-		#size-cells = <1>;
 		vcc-supply = <&reg_mba6_3p3v>;
 
-		mba_mac_address: mac-address@20 {
-			reg = <0x20 0x6>;
+		nvmem-layout {
+			compatible = "fixed-layout";
+			#address-cells = <1>;
+			#size-cells = <1>;
+
+			mba_mac_address: mac-address@20 {
+				reg = <0x20 0x6>;
+			};
 		};
 	};
 
-- 
2.35.3


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: nxp: imx6: convert NVMEM content to layout syntax
  2024-05-20  6:02 [PATCH] ARM: dts: nxp: imx6: convert NVMEM content to layout syntax Rafał Miłecki
@ 2024-06-15  8:26 ` Shawn Guo
  2024-06-19 11:54   ` Alexander Stein
  2024-06-27  6:11 ` Shawn Guo
  1 sibling, 1 reply; 4+ messages in thread
From: Shawn Guo @ 2024-06-15  8:26 UTC (permalink / raw)
  To: Rafał Miłecki, Markus Niebel, Alexander Stein
  Cc: Shawn Guo, Sascha Hauer, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Pengutronix Kernel Team, Fabio Estevam, devicetree,
	imx, linux-arm-kernel, Rafał Miłecki

On Mon, May 20, 2024 at 08:02:22AM +0200, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> Use cleaner (and non-deprecated) bindings syntax. See commit
> bd912c991d2e ("dt-bindings: nvmem: layouts: add fixed-layout") for
> details.
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>

Markus, Alexander

Are you guys good with this change?

Shawn

> ---
>  arch/arm/boot/dts/nxp/imx/imx6qdl-mba6a.dtsi | 12 ++++++++----
>  arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi | 12 ++++++++----
>  2 files changed, 16 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6a.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6a.dtsi
> index 238f3af42822..807f3c95e3ce 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6a.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6a.dtsi
> @@ -22,12 +22,16 @@ m24c64_57: eeprom@57 {
>  		compatible = "atmel,24c64";
>  		reg = <0x57>;
>  		pagesize = <32>;
> -		#address-cells = <1>;
> -		#size-cells = <1>;
>  		vcc-supply = <&reg_mba6_3p3v>;
>  
> -		mba_mac_address: mac-address@20 {
> -			reg = <0x20 0x6>;
> +		nvmem-layout {
> +			compatible = "fixed-layout";
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +
> +			mba_mac_address: mac-address@20 {
> +				reg = <0x20 0x6>;
> +			};
>  		};
>  	};
>  
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi
> index a587bc88f76f..789733a45b95 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi
> @@ -32,12 +32,16 @@ m24c64_57: eeprom@57 {
>  		compatible = "atmel,24c64";
>  		reg = <0x57>;
>  		pagesize = <32>;
> -		#address-cells = <1>;
> -		#size-cells = <1>;
>  		vcc-supply = <&reg_mba6_3p3v>;
>  
> -		mba_mac_address: mac-address@20 {
> -			reg = <0x20 0x6>;
> +		nvmem-layout {
> +			compatible = "fixed-layout";
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +
> +			mba_mac_address: mac-address@20 {
> +				reg = <0x20 0x6>;
> +			};
>  		};
>  	};
>  
> -- 
> 2.35.3
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: nxp: imx6: convert NVMEM content to layout syntax
  2024-06-15  8:26 ` Shawn Guo
@ 2024-06-19 11:54   ` Alexander Stein
  0 siblings, 0 replies; 4+ messages in thread
From: Alexander Stein @ 2024-06-19 11:54 UTC (permalink / raw)
  To: Rafał Miłecki, Markus Niebel, Shawn Guo
  Cc: Shawn Guo, Sascha Hauer, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Pengutronix Kernel Team, Fabio Estevam, devicetree,
	imx, linux-arm-kernel, Rafał Miłecki

Hi Shawn,

Am Samstag, 15. Juni 2024, 10:26:57 CEST schrieb Shawn Guo:
> On Mon, May 20, 2024 at 08:02:22AM +0200, Rafał Miłecki wrote:
> > From: Rafał Miłecki <rafal@milecki.pl>
> > 
> > Use cleaner (and non-deprecated) bindings syntax. See commit
> > bd912c991d2e ("dt-bindings: nvmem: layouts: add fixed-layout") for
> > details.
> > 
> > Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> 
> Markus, Alexander
> 
> Are you guys good with this change?

Thanks for bringing this up. The MAINTAINERS file still has not been updated
since the arm dts directory split..

Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com>

> > ---
> >  arch/arm/boot/dts/nxp/imx/imx6qdl-mba6a.dtsi | 12 ++++++++----
> >  arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi | 12 ++++++++----
> >  2 files changed, 16 insertions(+), 8 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6a.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6a.dtsi
> > index 238f3af42822..807f3c95e3ce 100644
> > --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6a.dtsi
> > +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6a.dtsi
> > @@ -22,12 +22,16 @@ m24c64_57: eeprom@57 {
> >  		compatible = "atmel,24c64";
> >  		reg = <0x57>;
> >  		pagesize = <32>;
> > -		#address-cells = <1>;
> > -		#size-cells = <1>;
> >  		vcc-supply = <&reg_mba6_3p3v>;
> >  
> > -		mba_mac_address: mac-address@20 {
> > -			reg = <0x20 0x6>;
> > +		nvmem-layout {
> > +			compatible = "fixed-layout";
> > +			#address-cells = <1>;
> > +			#size-cells = <1>;
> > +
> > +			mba_mac_address: mac-address@20 {
> > +				reg = <0x20 0x6>;
> > +			};
> >  		};
> >  	};
> >  
> > diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi
> > index a587bc88f76f..789733a45b95 100644
> > --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi
> > +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi
> > @@ -32,12 +32,16 @@ m24c64_57: eeprom@57 {
> >  		compatible = "atmel,24c64";
> >  		reg = <0x57>;
> >  		pagesize = <32>;
> > -		#address-cells = <1>;
> > -		#size-cells = <1>;
> >  		vcc-supply = <&reg_mba6_3p3v>;
> >  
> > -		mba_mac_address: mac-address@20 {
> > -			reg = <0x20 0x6>;
> > +		nvmem-layout {
> > +			compatible = "fixed-layout";
> > +			#address-cells = <1>;
> > +			#size-cells = <1>;
> > +
> > +			mba_mac_address: mac-address@20 {
> > +				reg = <0x20 0x6>;
> > +			};
> >  		};
> >  	};
> >  
> 
> 


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/



^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: nxp: imx6: convert NVMEM content to layout syntax
  2024-05-20  6:02 [PATCH] ARM: dts: nxp: imx6: convert NVMEM content to layout syntax Rafał Miłecki
  2024-06-15  8:26 ` Shawn Guo
@ 2024-06-27  6:11 ` Shawn Guo
  1 sibling, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2024-06-27  6:11 UTC (permalink / raw)
  To: Rafał Miłecki
  Cc: Shawn Guo, Sascha Hauer, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Pengutronix Kernel Team, Fabio Estevam, devicetree,
	imx, linux-arm-kernel, Rafał Miłecki

On Mon, May 20, 2024 at 08:02:22AM +0200, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> Use cleaner (and non-deprecated) bindings syntax. See commit
> bd912c991d2e ("dt-bindings: nvmem: layouts: add fixed-layout") for
> details.
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>

Applied, thanks!


^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-06-27  6:43 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-20  6:02 [PATCH] ARM: dts: nxp: imx6: convert NVMEM content to layout syntax Rafał Miłecki
2024-06-15  8:26 ` Shawn Guo
2024-06-19 11:54   ` Alexander Stein
2024-06-27  6:11 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).