* [PATCH] arm64: dts: imx8mp: Fix pgc vpu locations
@ 2024-06-19 10:10 Adam Ford
2024-06-20 11:37 ` Alexander Stein
2024-06-27 7:52 ` Shawn Guo
0 siblings, 2 replies; 3+ messages in thread
From: Adam Ford @ 2024-06-19 10:10 UTC (permalink / raw)
To: linux-arm-kernel
Cc: aford, Adam Ford, Alexander Stein, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Peng Fan, devicetree, imx,
linux-kernel
The various pgv_vpu nodes have a mismatch between the value after
the @ symbol and what is referenced by 'reg' so reorder the nodes
to align.
Fixes: df680992dd62 ("arm64: dts: imx8mp: add vpu pgc nodes")
Suggested-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Signed-off-by: Adam Ford <aford173@gmail.com>
diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index 3576d2b89b43..ee0c864f27e8 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -838,6 +838,12 @@ pgc_gpumix: power-domain@7 {
assigned-clock-rates = <800000000>, <400000000>;
};
+ pgc_vpumix: power-domain@8 {
+ #power-domain-cells = <0>;
+ reg = <IMX8MP_POWER_DOMAIN_VPUMIX>;
+ clocks = <&clk IMX8MP_CLK_VPU_ROOT>;
+ };
+
pgc_gpu3d: power-domain@9 {
#power-domain-cells = <0>;
reg = <IMX8MP_POWER_DOMAIN_GPU3D>;
@@ -853,6 +859,28 @@ pgc_mediamix: power-domain@10 {
<&clk IMX8MP_CLK_MEDIA_APB_ROOT>;
};
+ pgc_vpu_g1: power-domain@11 {
+ #power-domain-cells = <0>;
+ power-domains = <&pgc_vpumix>;
+ reg = <IMX8MP_POWER_DOMAIN_VPU_G1>;
+ clocks = <&clk IMX8MP_CLK_VPU_G1_ROOT>;
+ };
+
+ pgc_vpu_g2: power-domain@12 {
+ #power-domain-cells = <0>;
+ power-domains = <&pgc_vpumix>;
+ reg = <IMX8MP_POWER_DOMAIN_VPU_G2>;
+ clocks = <&clk IMX8MP_CLK_VPU_G2_ROOT>;
+
+ };
+
+ pgc_vpu_vc8000e: power-domain@13 {
+ #power-domain-cells = <0>;
+ power-domains = <&pgc_vpumix>;
+ reg = <IMX8MP_POWER_DOMAIN_VPU_VC8000E>;
+ clocks = <&clk IMX8MP_CLK_VPU_VC8KE_ROOT>;
+ };
+
pgc_hdmimix: power-domain@14 {
#power-domain-cells = <0>;
reg = <IMX8MP_POWER_DOMAIN_HDMIMIX>;
@@ -890,33 +918,6 @@ pgc_ispdwp: power-domain@18 {
reg = <IMX8MP_POWER_DOMAIN_MEDIAMIX_ISPDWP>;
clocks = <&clk IMX8MP_CLK_MEDIA_ISP_ROOT>;
};
-
- pgc_vpumix: power-domain@19 {
- #power-domain-cells = <0>;
- reg = <IMX8MP_POWER_DOMAIN_VPUMIX>;
- clocks = <&clk IMX8MP_CLK_VPU_ROOT>;
- };
-
- pgc_vpu_g1: power-domain@20 {
- #power-domain-cells = <0>;
- power-domains = <&pgc_vpumix>;
- reg = <IMX8MP_POWER_DOMAIN_VPU_G1>;
- clocks = <&clk IMX8MP_CLK_VPU_G1_ROOT>;
- };
-
- pgc_vpu_g2: power-domain@21 {
- #power-domain-cells = <0>;
- power-domains = <&pgc_vpumix>;
- reg = <IMX8MP_POWER_DOMAIN_VPU_G2>;
- clocks = <&clk IMX8MP_CLK_VPU_G2_ROOT>;
- };
-
- pgc_vpu_vc8000e: power-domain@22 {
- #power-domain-cells = <0>;
- power-domains = <&pgc_vpumix>;
- reg = <IMX8MP_POWER_DOMAIN_VPU_VC8000E>;
- clocks = <&clk IMX8MP_CLK_VPU_VC8KE_ROOT>;
- };
};
};
};
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: imx8mp: Fix pgc vpu locations
2024-06-19 10:10 [PATCH] arm64: dts: imx8mp: Fix pgc vpu locations Adam Ford
@ 2024-06-20 11:37 ` Alexander Stein
2024-06-27 7:52 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Alexander Stein @ 2024-06-20 11:37 UTC (permalink / raw)
To: linux-arm-kernel, Adam Ford
Cc: aford, Adam Ford, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Peng Fan, devicetree, imx, linux-kernel
Hi Adam,
Am Mittwoch, 19. Juni 2024, 12:10:44 CEST schrieb Adam Ford:
> The various pgv_vpu nodes have a mismatch between the value after
> the @ symbol and what is referenced by 'reg' so reorder the nodes
> to align.
>
> Fixes: df680992dd62 ("arm64: dts: imx8mp: add vpu pgc nodes")
> Suggested-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> Signed-off-by: Adam Ford <aford173@gmail.com>
Thanks for the patch.
Reviewd-by: Alexander Stein <alexander.stein@ew.tq-group.com>
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index 3576d2b89b43..ee0c864f27e8 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -838,6 +838,12 @@ pgc_gpumix: power-domain@7 {
> assigned-clock-rates = <800000000>, <400000000>;
> };
>
> + pgc_vpumix: power-domain@8 {
> + #power-domain-cells = <0>;
> + reg = <IMX8MP_POWER_DOMAIN_VPUMIX>;
> + clocks = <&clk IMX8MP_CLK_VPU_ROOT>;
> + };
> +
> pgc_gpu3d: power-domain@9 {
> #power-domain-cells = <0>;
> reg = <IMX8MP_POWER_DOMAIN_GPU3D>;
> @@ -853,6 +859,28 @@ pgc_mediamix: power-domain@10 {
> <&clk IMX8MP_CLK_MEDIA_APB_ROOT>;
> };
>
> + pgc_vpu_g1: power-domain@11 {
> + #power-domain-cells = <0>;
> + power-domains = <&pgc_vpumix>;
> + reg = <IMX8MP_POWER_DOMAIN_VPU_G1>;
> + clocks = <&clk IMX8MP_CLK_VPU_G1_ROOT>;
> + };
> +
> + pgc_vpu_g2: power-domain@12 {
> + #power-domain-cells = <0>;
> + power-domains = <&pgc_vpumix>;
> + reg = <IMX8MP_POWER_DOMAIN_VPU_G2>;
> + clocks = <&clk IMX8MP_CLK_VPU_G2_ROOT>;
> +
> + };
> +
> + pgc_vpu_vc8000e: power-domain@13 {
> + #power-domain-cells = <0>;
> + power-domains = <&pgc_vpumix>;
> + reg = <IMX8MP_POWER_DOMAIN_VPU_VC8000E>;
> + clocks = <&clk IMX8MP_CLK_VPU_VC8KE_ROOT>;
> + };
> +
> pgc_hdmimix: power-domain@14 {
> #power-domain-cells = <0>;
> reg = <IMX8MP_POWER_DOMAIN_HDMIMIX>;
> @@ -890,33 +918,6 @@ pgc_ispdwp: power-domain@18 {
> reg = <IMX8MP_POWER_DOMAIN_MEDIAMIX_ISPDWP>;
> clocks = <&clk IMX8MP_CLK_MEDIA_ISP_ROOT>;
> };
> -
> - pgc_vpumix: power-domain@19 {
> - #power-domain-cells = <0>;
> - reg = <IMX8MP_POWER_DOMAIN_VPUMIX>;
> - clocks = <&clk IMX8MP_CLK_VPU_ROOT>;
> - };
> -
> - pgc_vpu_g1: power-domain@20 {
> - #power-domain-cells = <0>;
> - power-domains = <&pgc_vpumix>;
> - reg = <IMX8MP_POWER_DOMAIN_VPU_G1>;
> - clocks = <&clk IMX8MP_CLK_VPU_G1_ROOT>;
> - };
> -
> - pgc_vpu_g2: power-domain@21 {
> - #power-domain-cells = <0>;
> - power-domains = <&pgc_vpumix>;
> - reg = <IMX8MP_POWER_DOMAIN_VPU_G2>;
> - clocks = <&clk IMX8MP_CLK_VPU_G2_ROOT>;
> - };
> -
> - pgc_vpu_vc8000e: power-domain@22 {
> - #power-domain-cells = <0>;
> - power-domains = <&pgc_vpumix>;
> - reg = <IMX8MP_POWER_DOMAIN_VPU_VC8000E>;
> - clocks = <&clk IMX8MP_CLK_VPU_VC8KE_ROOT>;
> - };
> };
> };
> };
>
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: imx8mp: Fix pgc vpu locations
2024-06-19 10:10 [PATCH] arm64: dts: imx8mp: Fix pgc vpu locations Adam Ford
2024-06-20 11:37 ` Alexander Stein
@ 2024-06-27 7:52 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2024-06-27 7:52 UTC (permalink / raw)
To: Adam Ford
Cc: linux-arm-kernel, aford, Alexander Stein, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Peng Fan, devicetree, imx,
linux-kernel
On Wed, Jun 19, 2024 at 05:10:44AM -0500, Adam Ford wrote:
> The various pgv_vpu nodes have a mismatch between the value after
> the @ symbol and what is referenced by 'reg' so reorder the nodes
> to align.
>
> Fixes: df680992dd62 ("arm64: dts: imx8mp: add vpu pgc nodes")
> Suggested-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> Signed-off-by: Adam Ford <aford173@gmail.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-06-27 7:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-19 10:10 [PATCH] arm64: dts: imx8mp: Fix pgc vpu locations Adam Ford
2024-06-20 11:37 ` Alexander Stein
2024-06-27 7:52 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).