From: Johan Hovold <johan@kernel.org>
To: Abel Vesa <abel.vesa@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Rajendra Nayak <quic_rjendra@quicinc.com>
Subject: Re: [PATCH v2] arm64: dts: qcom: x1e80100: Enable tsens and thermal zone nodes
Date: Mon, 17 Jun 2024 11:24:22 +0200 [thread overview]
Message-ID: <ZnAAxlH6yhlJf6fV@hovoldconsulting.com> (raw)
In-Reply-To: <20240614-x1e80100-dts-thermal-v2-1-4d4f9effacc6@linaro.org>
On Fri, Jun 14, 2024 at 01:50:07PM +0300, Abel Vesa wrote:
> From: Rajendra Nayak <quic_rjendra@quicinc.com>
>
> Add tsens and thermal zones nodes for x1e80100 SoC.
>
> Signed-off-by: Rajendra Nayak <quic_rjendra@quicinc.com>
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
> Changes in v2:
> - Dropped the thermal engine nodes.
> - Dropped comments from tsens nodes.
> - Droppd the polling-delay entirely and polling-delay-passive where not
> necessary.
> - Added top/bottom location to all sensors (where applicable).
> - Fixed trip points with duplicate values for same temp.
> - Marked as critical the 125°C throughout all trip points.
> - Link to v1: https://lore.kernel.org/r/20240527-x1e80100-dts-thermal-v1-1-ea13b8fa6ffc@linaro.org
> ---
> arch/arm64/boot/dts/qcom/x1e80100.dtsi | 1176 ++++++++++++++++++++++++++++++++
> 1 file changed, 1176 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> index 9944c654851e..df13df7967db 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> + cpu0-0-bottom-thermal {
> + thermal-sensors = <&tsens0 2>;
> +
> + trips {
> + trip-point0 {
> + temperature = <90000>;
> + hysteresis = <2000>;
> + type = "passive";
> + };
> +
> + trip-point1 {
> + temperature = <95000>;
> + hysteresis = <2000>;
> + type = "passive";
> + };
> +
> + cpu-critical {
> + temperature = <110000>;
> + hysteresis = <1000>;
> + type = "critical";
> + };
> + };
> + };
The CPU bottom thermal zones fail to register with v2:
[ 0.146219] thermal_sys: Thermal zone name (cpu0-0-bottom-thermal) too long, should be under 20 chars
[ 0.146241] thermal_sys: Failed to register thermal zone cpu0-0-bottom-thermal: -22
[ 0.146474] thermal_sys: Thermal zone name (cpu0-1-bottom-thermal) too long, should be under 20 chars
[ 0.146495] thermal_sys: Failed to register thermal zone cpu0-1-bottom-thermal: -22
[ 0.146753] thermal_sys: Thermal zone name (cpu0-2-bottom-thermal) too long, should be under 20 chars
[ 0.146774] thermal_sys: Failed to register thermal zone cpu0-2-bottom-thermal: -22
[ 0.147024] thermal_sys: Thermal zone name (cpu0-3-bottom-thermal) too long, should be under 20 chars
[ 0.147045] thermal_sys: Failed to register thermal zone cpu0-3-bottom-thermal: -22
[ 0.147297] thermal_sys: Thermal zone name (cpuss0-bottom-thermal) too long, should be under 20 chars
[ 0.147319] thermal_sys: Failed to register thermal zone cpuss0-bottom-thermal: -22
[ 0.149401] thermal_sys: Thermal zone name (cpu1-0-bottom-thermal) too long, should be under 20 chars
[ 0.149423] thermal_sys: Failed to register thermal zone cpu1-0-bottom-thermal: -22
[ 0.149765] thermal_sys: Thermal zone name (cpu1-1-bottom-thermal) too long, should be under 20 chars
[ 0.149787] thermal_sys: Failed to register thermal zone cpu1-1-bottom-thermal: -22
[ 0.150098] thermal_sys: Thermal zone name (cpu1-2-bottom-thermal) too long, should be under 20 chars
[ 0.150119] thermal_sys: Failed to register thermal zone cpu1-2-bottom-thermal: -22
[ 0.150437] thermal_sys: Thermal zone name (cpu1-3-bottom-thermal) too long, should be under 20 chars
[ 0.150458] thermal_sys: Failed to register thermal zone cpu1-3-bottom-thermal: -22
[ 0.150775] thermal_sys: Thermal zone name (cpuss1-bottom-thermal) too long, should be under 20 chars
[ 0.150796] thermal_sys: Failed to register thermal zone cpuss1-bottom-thermal: -22
[ 0.152838] thermal_sys: Thermal zone name (cpu2-0-bottom-thermal) too long, should be under 20 chars
[ 0.152859] thermal_sys: Failed to register thermal zone cpu2-0-bottom-thermal: -22
[ 0.153211] thermal_sys: Thermal zone name (cpu2-1-bottom-thermal) too long, should be under 20 chars
[ 0.153232] thermal_sys: Failed to register thermal zone cpu2-1-bottom-thermal: -22
[ 0.153603] thermal_sys: Thermal zone name (cpu2-2-bottom-thermal) too long, should be under 20 chars
[ 0.153624] thermal_sys: Failed to register thermal zone cpu2-2-bottom-thermal: -22
[ 0.153994] thermal_sys: Thermal zone name (cpu2-3-bottom-thermal) too long, should be under 20 chars
[ 0.154015] thermal_sys: Failed to register thermal zone cpu2-3-bottom-thermal: -22
[ 0.154386] thermal_sys: Thermal zone name (cpuss2-bottom-thermal) too long, should be under 20 chars
[ 0.154407] thermal_sys: Failed to register thermal zone cpuss2-bottom-thermal: -22
Johan
next prev parent reply other threads:[~2024-06-17 9:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 10:50 [PATCH v2] arm64: dts: qcom: x1e80100: Enable tsens and thermal zone nodes Abel Vesa
2024-06-17 9:24 ` Johan Hovold [this message]
2024-06-18 10:00 ` Abel Vesa
2024-06-18 11:40 ` Johan Hovold
2024-06-18 11:06 ` Konrad Dybcio
2024-06-20 12:52 ` Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZnAAxlH6yhlJf6fV@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_rjendra@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).