From: Frank Li <Frank.li@nxp.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Yangbo Lu <yangbo.lu@nxp.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Madalin Bucur <madalin.bucur@nxp.com>,
Sean Anderson <sean.anderson@seco.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev
Subject: Re: [PATCH 2/2] dt-bindings: net: Convert fsl-fman to yaml
Date: Tue, 18 Jun 2024 17:03:56 -0400 [thread overview]
Message-ID: <ZnH2PDXn4l062NPK@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <fc8a117d-9723-44fe-afa3-f1a5af37a1a6@kernel.org>
On Tue, Jun 18, 2024 at 08:18:41AM +0200, Krzysztof Kozlowski wrote:
> On 17/06/2024 20:19, Frank Li wrote:
> >>> + reg:
> >>> + maxItems: 1
> >>> +
> >>> + ranges: true
> >>
> >> That's odd. Why do you need ranges without children?
> >
> > It think it is legacy method in driver.
> >
> > muram_node = of_find_matching_node(fm_node, fman_muram_match);
> > if (!muram_node) {
> > err = -EINVAL;
> > dev_err(&of_dev->dev, "%s: could not find MURAM node\n",
> > __func__);
> > goto fman_free;
> > }
> >
> > err = of_address_to_resource(muram_node, 0,
> > &fman->dts_params.muram_res);
> > if (err) {
> > of_node_put(muram_node);
> > dev_err(&of_dev->dev, "%s: of_address_to_resource() = %d\n",
> > __func__, err);
> > goto fman_free;
> > }
>
> And how is this related to ranges?
You are right. Old document is wrong. Thanks.
Frank
>
> >>
>
> Best regards,
> Krzysztof
>
prev parent reply other threads:[~2024-06-18 21:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 20:33 [PATCH 0/2] dt-bindings: net: Convert fsl,fman related file to yaml format Frank Li
2024-06-14 20:33 ` [PATCH 1/2] dt-bindings: ptp: Convert ptp-qoirq " Frank Li
2024-06-14 22:03 ` kernel test robot
2024-06-17 6:59 ` Krzysztof Kozlowski
2024-06-14 20:33 ` [PATCH 2/2] dt-bindings: net: Convert fsl-fman to yaml Frank Li
2024-06-14 22:24 ` kernel test robot
2024-06-17 7:14 ` Krzysztof Kozlowski
2024-06-17 18:19 ` Frank Li
2024-06-18 6:18 ` Krzysztof Kozlowski
2024-06-18 21:03 ` Frank Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZnH2PDXn4l062NPK@lizhi-Precision-Tower-5810 \
--to=frank.li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=madalin.bucur@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=sean.anderson@seco.com \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).