From: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Marcelo Schmitt <marcelo.schmitt@analog.com>,
lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, nuno.sa@analog.com, dlechner@baylibre.com,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/6] spi: Enable controllers to extend the SPI protocol with MOSI idle configuration
Date: Wed, 19 Jun 2024 09:42:23 -0300 [thread overview]
Message-ID: <ZnLSL6wvyhGAVyUz@debian-BULLSEYE-live-builder-AMD64> (raw)
In-Reply-To: <5f89baeb-c95a-4ad9-adc7-769fb124c0d4@sirena.org.uk>
On 06/19, Mark Brown wrote:
> On Tue, Jun 18, 2024 at 08:10:44PM -0300, Marcelo Schmitt wrote:
>
> > First replies to v3 brought the idea of having a feature detection mechanism.
> > I didn't really get how to do that. If feature detection is required, can
> > somebody please provide some pointers on how to implement that?
>
> Look at the checks in spi_setup() for bad_bits.
Yes, I added MOSI idle configuration bits to bad_bits so spi_setup() fails
if the feature is requested but not supported:
bad_bits = spi->mode & ~(spi->controller->mode_bits | SPI_CS_WORD |
SPI_NO_TX | SPI_NO_RX | SPI_MOSI_IDLE_LOW |
SPI_MOSI_IDLE_HIGH);
am I still missing anything?
Thanks,
Marcelo
next prev parent reply other threads:[~2024-06-19 12:41 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 23:10 [PATCH v4 0/6] Add support for AD4000 series of ADCs Marcelo Schmitt
2024-06-18 23:10 ` [PATCH v4 1/6] spi: Enable controllers to extend the SPI protocol with MOSI idle configuration Marcelo Schmitt
2024-06-19 12:07 ` Mark Brown
2024-06-19 12:42 ` Marcelo Schmitt [this message]
2024-06-19 12:42 ` Mark Brown
2024-06-19 13:53 ` David Lechner
2024-06-19 18:58 ` Marcelo Schmitt
2024-06-19 20:36 ` David Lechner
2024-06-20 15:12 ` Marcelo Schmitt
2024-06-20 15:52 ` David Lechner
2024-06-20 18:21 ` Marcelo Schmitt
2024-06-20 18:55 ` David Lechner
2024-06-19 21:29 ` Mark Brown
2024-06-20 15:14 ` Marcelo Schmitt
2024-06-19 17:24 ` David Lechner
2024-06-20 14:29 ` Marcelo Schmitt
2024-06-18 23:11 ` [PATCH v4 2/6] spi: bitbang: Implement support for MOSI idle state configuration Marcelo Schmitt
2024-06-18 23:11 ` [PATCH v4 3/6] spi: spi-gpio: Add " Marcelo Schmitt
2024-06-18 23:11 ` [PATCH v4 4/6] spi: spi-axi-spi-engine: Add support for MOSI idle configuration Marcelo Schmitt
2024-06-19 13:56 ` David Lechner
2024-06-19 17:27 ` Marcelo Schmitt
2024-06-19 18:20 ` David Lechner
2024-06-18 23:12 ` [PATCH v4 5/6] dt-bindings: iio: adc: Add AD4000 Marcelo Schmitt
2024-06-19 13:13 ` David Lechner
2024-06-19 17:04 ` Marcelo Schmitt
2024-06-19 19:57 ` David Lechner
2024-06-18 23:12 ` [PATCH v4 6/6] iio: adc: Add support for AD4000 Marcelo Schmitt
2024-06-19 17:02 ` David Lechner
2024-06-20 20:08 ` Jonathan Cameron
2024-06-20 20:02 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZnLSL6wvyhGAVyUz@debian-BULLSEYE-live-builder-AMD64 \
--to=marcelo.schmitt1@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=marcelo.schmitt@analog.com \
--cc=nuno.sa@analog.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).