From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/3] media: dt-bindings: Add description of OmniVision OG01A1B image sensor
Date: Fri, 21 Jun 2024 17:12:07 +0000 [thread overview]
Message-ID: <ZnW0Z7miY7bWfC_B@kekkonen.localdomain> (raw)
In-Reply-To: <9824cc10-ab59-4cac-9a88-a1f9bb84a1d5@kernel.org>
Hi Krzysztof,
On Thu, Jun 20, 2024 at 10:28:03PM +0200, Krzysztof Kozlowski wrote:
> On 20/06/2024 22:04, Sakari Ailus wrote:
> > Hi Krzysztof,
> >
> > On Thu, Jun 20, 2024 at 05:33:15PM +0200, Krzysztof Kozlowski wrote:
> >> On 20/06/2024 14:47, Vladimir Zapolskiy wrote:
> >>> + properties:
> >>> + endpoint:
> >>> + $ref: /schemas/media/video-interfaces.yaml#
> >>> + unevaluatedProperties: false
> >>> +
> >>> + properties:
> >>> + data-lanes:
> >>> + minItems: 1
> >>> + maxItems: 2
> >>> +
> >>> + link-frequencies: true
> >>
> >> This should not be needed.
> >
> > Why?
>
> Because it is a no-op. Changes nothing, absolutely nothing. Property is
> allowed from video-interfaces via unevaluatedProperties.
Right, indeed.
This should be listeed as required instead.
>
> >
> > Please see
> > <URL:https://hverkuil.home.xs4all.nl/spec/driver-api/camera-sensor.html#handling-clocks>.
>
> This doe snot cover empty link-frequencies or I could not spot what you
> are referring to.
>
> Unless you are suggesting that this should be fixed into proper
> frequencies? Then yes, Ack. Keep it with proper values.
--
Kind regards,
Sakari Ailus
next prev parent reply other threads:[~2024-06-21 17:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 12:47 [PATCH 0/3] media: i2c: og01a1b: Add OF support to OmniVision OG01A1B Vladimir Zapolskiy
2024-06-20 12:47 ` [PATCH 1/3] media: dt-bindings: Add description of OmniVision OG01A1B image sensor Vladimir Zapolskiy
2024-06-20 15:33 ` Krzysztof Kozlowski
2024-06-20 20:04 ` Sakari Ailus
2024-06-20 20:28 ` Krzysztof Kozlowski
2024-06-21 17:12 ` Sakari Ailus [this message]
2024-06-24 15:25 ` kernel test robot
2024-06-20 12:47 ` [PATCH 2/3] media: i2c: og01a1b: Add OF support to the image sensor driver Vladimir Zapolskiy
2024-06-20 12:47 ` [PATCH 3/3] media: i2c: og01a1b: Add support of an input system clock Vladimir Zapolskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZnW0Z7miY7bWfC_B@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox