From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6ACB074BF5 for ; Tue, 25 Jun 2024 21:30:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719351057; cv=none; b=cIZwASWtVD8wx7GDNMFHSr/fLBffMsMWqnhL31MtjjoW2OasI/MZrdSYgXKoWZFZWpeM9lIBVZmU/z5n7PuZBeeAND7HITMvyMpsWkDp4NRaR3v8bdZNj0hbtzpiJmaupJlrjYuRfd1lTakavH9ePMScjaB9Xmnhi+uoI3sXoMw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719351057; c=relaxed/simple; bh=cj7Gt+uQU5ptKgdIzkqkZMdjHHsqa2VwADHNYHlv+yI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TmEZ6kqd2ka2jGKYun+Ov4GfltJNjgIdLnR0bdfsw7tFdpwDS4XAmv5vY5CIr16Z6QSjgwVpyecY4ULoseVQ0xLD+zzDBFOonk0+L1t0o+LZ2jE6GSw027muTJs8UlpY6K3CNw6IMWugEPqSEHTKIb9fIIqJW461xkFqSEyFQN8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=tenstorrent.com; spf=pass smtp.mailfrom=tenstorrent.com; dkim=pass (2048-bit key) header.d=tenstorrent.com header.i=@tenstorrent.com header.b=UESqX9y8; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=tenstorrent.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tenstorrent.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tenstorrent.com header.i=@tenstorrent.com header.b="UESqX9y8" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1f9c6e59d34so50050795ad.2 for ; Tue, 25 Jun 2024 14:30:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tenstorrent.com; s=google; t=1719351056; x=1719955856; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=B2W8rgNXG1QVMuA1bBYIoQVqie0Y2SU5GMCzLUNZnjw=; b=UESqX9y87/Xp7F769iJHetz59DFJjHKn3pCjsrw8Q47W0yvo8E4Ds+PrmhfujQ4FzG WNxO6cf4tC6BrTVgLSPk41f8uYgcODWIzgMFCpo+8VYsWzIyXw/e9yuyWazMSpMX0+X4 jI5jqjkW2FxDCR1bcjhZxWBBkspLh/LQ+vWhq0PPhmbtD0KD0+aq3iCVgx9TD5pvUM+C GCG4Qj0J0n+npxj74ge7tzgLDEHsuunpeDlK2Zlpz3jKvo9w+s/z5o/gcTYNrPzah5fc 4H+PUbGuIL+6BxS/PIYDYxnfoWMsHbVGfs7ez8pRXOebTRj9fgpbcFbA9QKMl5u4Opp8 vJqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719351056; x=1719955856; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=B2W8rgNXG1QVMuA1bBYIoQVqie0Y2SU5GMCzLUNZnjw=; b=qO6BgVFP7gzmRgICUqVALVBPiYp2qj7zCdIo3GOKujjqZ0vcRh/UdL4qKOGF6Idmd+ BYDytmD52t3JIoIUpQtDTQvI6TvY3iHazL5R4PnEEwiG3/wL7XhV0faJqkMq0aj07SA7 G0kmeWC/gdTzefGhUvwOE2tvBwWMsVzFWsfRfy3kfjSj97fkC6RpM5tB2FZR789CiOPs jlEbouRbQZJPA02j5Dx8OUfyFhF2iNKp6N5tGCZ8/PwLOQMlh9lP+SMWUMXc3FUM5sAm VRl1TdrELorrdBlmMY8uLV3oORxHR2FSrAKXgX/9JSurFQOSENUpG5bIoNCdMMj7jBMM 77VA== X-Forwarded-Encrypted: i=1; AJvYcCW7ej0Ykq1zLBzygYjK0FMOiBgaSrC7X+EeD4W2EZ/9GJbPAIbz0HnfTTB5TP5HjZsTAxIoUduNAPk3DZfTe8U3b2RrC2C3q7yP+Q== X-Gm-Message-State: AOJu0YygoAKERKDfm6K8nbcWxKPhjrLX1r80wsvXVOVCicRca7CyzPKt K6wi9XkcIeHyGHtlvOVdJWofcwBlFi6u3GAEYkb/v+D/HmTx8/FKupEvfpivouw= X-Google-Smtp-Source: AGHT+IHLYzhYJqgZIhjVBl957rNEit7/68mjSYfy0ZR3K9f3qNxYJuPCUrQQrG4u1+TQDgmb+OtrJg== X-Received: by 2002:a17:902:d4cd:b0:1fa:18c3:2788 with SMTP id d9443c01a7336-1fa1d51c210mr95820215ad.24.1719351049966; Tue, 25 Jun 2024 14:30:49 -0700 (PDT) Received: from x1 ([2601:1c2:1802:170:efe7:d185:104e:b7b]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f9eb7d245asm86453135ad.232.2024.06.25.14.30.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Jun 2024 14:30:49 -0700 (PDT) Date: Tue, 25 Jun 2024 14:30:47 -0700 From: Drew Fustini To: Thomas Bonnefille Cc: Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jisheng Zhang , Guo Ren , Fu Wei , Emil Renner Berthing , Conor Dooley , Jarkko Nikula , Palmer Dabbelt , Albert Ou , Paul Walmsley , Thomas Petazzoni , =?iso-8859-1?Q?Miqu=E8l?= Raynal , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v3 3/3] riscv: dts: thead: Enable I2C on the BeagleV-Ahead Message-ID: References: <20240618-i2c-th1520-v3-0-3042590a16b1@bootlin.com> <20240618-i2c-th1520-v3-3-3042590a16b1@bootlin.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240618-i2c-th1520-v3-3-3042590a16b1@bootlin.com> On Tue, Jun 18, 2024 at 09:42:40AM +0200, Thomas Bonnefille wrote: > This commit enables the I2C0 controller of the TH1520, together with > the FT24C32A EEPROM that is connected to it. > In addition, this commit also enables the I2C controllers I2C2, I2C4 > and I2C5 as they are all three exposed on headers (P9 19 and 20 for I2C2, > P9 17 and 18 for I2C5 and MikroBus 7 and 5 for I2C4). > It also defined the required pinctrl nodes. > > Signed-off-by: Thomas Bonnefille > --- > arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts | 84 ++++++++++++++++++++++ > 1 file changed, 84 insertions(+) > > diff --git a/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts b/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts > index 57a2578123eb..b5c4f1811955 100644 > --- a/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts > +++ b/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts > @@ -122,6 +122,19 @@ led-pins { > }; > > &padctrl0_apsys { > + i2c2_pins: i2c2-0 { > + i2c-pins { > + pins = "I2C2_SDA", > + "I2C2_SCL"; > + function = "i2c"; > + bias-pull-up = <48000>; > + drive-strength = <7>; > + input-enable; > + input-schmitt-enable; > + slew-rate = <0>; > + }; > + }; > + > uart0_pins: uart0-0 { > tx-pins { > pins = "UART0_TXD"; > @@ -145,8 +158,79 @@ rx-pins { > }; > }; > > +&padctrl1_apsys { > + i2c0_pins: i2c0-0 { > + i2c-pins { > + pins = "I2C0_SDA", > + "I2C0_SCL"; > + function = "i2c"; > + bias-pull-up = <48000>; > + drive-strength = <7>; > + input-enable; > + input-schmitt-enable; > + slew-rate = <0>; > + }; > + }; > + > + i2c4_pins: i2c4-0 { > + i2c-pins { > + pins = "GPIO0_19", /* I2C4_SDA */ > + "GPIO0_18"; /* I2C4_SCL */ > + function = "i2c"; > + bias-pull-up = <48000>; > + drive-strength = <7>; > + input-enable; > + input-schmitt-enable; > + slew-rate = <0>; > + }; > + }; > + > + i2c5_pins: i2c5-0 { > + i2c-pins { > + pins = "QSPI1_D0_MOSI", /* I2C5_SDA */ > + "QSPI1_CSN0"; /* I2C5_SCL */ > + function = "i2c"; > + bias-pull-up = <48000>; > + drive-strength = <7>; > + input-enable; > + input-schmitt-enable; > + slew-rate = <0>; > + }; > + }; > +}; > + > &uart0 { > pinctrl-names = "default"; > pinctrl-0 = <&uart0_pins>; > status = "okay"; > }; > + > +&i2c0 { > + clock-frequency = <100000>; > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c0_pins>; > + status = "okay"; > + > + eeprom@50 { > + compatible = "atmel,24c32"; > + reg = <0x50>; > + }; > +}; > + > +&i2c2 { > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c2_pins>; > + status = "okay"; > +}; > + > +&i2c4 { > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c4_pins>; > + status = "okay"; > +}; > + > +&i2c5 { > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c5_pins>; > + status = "okay"; > +}; > > -- > 2.45.2 > Reviewed-by: Drew Fustini