From: Abel Vesa <abel.vesa@linaro.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Sibi Sankar <quic_sibis@quicinc.com>,
Rajendra Nayak <quic_rjendra@quicinc.com>,
Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: x1e80100: Fix up BAR spaces
Date: Wed, 10 Jul 2024 17:43:07 +0300 [thread overview]
Message-ID: <Zo6d+3T/wcVHiWi1@linaro.org> (raw)
In-Reply-To: <20240710-topic-barman-v1-1-5f63fca8d0fc@linaro.org>
On 24-07-10 16:07:23, Konrad Dybcio wrote:
> The 32-bit BAR spaces are reaching outside their assigned register
> regions. Shrink them to match their actual sizes.
> While at it, unify the style.
>
> Fixes: 5eb83fc10289 ("arm64: dts: qcom: x1e80100: Add PCIe nodes")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Also tested on CRD, so:
Tested-by: Abel Vesa <abel.vesa@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/x1e80100.dtsi | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> index 7bca5fcd7d52..bc5b4f5ea127 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> @@ -2895,9 +2895,9 @@ pcie6a: pci@1bf8000 {
> "mhi";
> #address-cells = <3>;
> #size-cells = <2>;
> - ranges = <0x01000000 0 0x00000000 0 0x70200000 0 0x100000>,
> - <0x02000000 0 0x70300000 0 0x70300000 0 0x3d00000>;
> - bus-range = <0 0xff>;
> + ranges = <0x01000000 0x0 0x00000000 0x0 0x70200000 0x0 0x100000>,
> + <0x02000000 0x0 0x70300000 0x0 0x70300000 0x0 0x1d00000>;
> + bus-range = <0x00 0xff>;
>
> dma-coherent;
>
> @@ -3016,8 +3016,8 @@ pcie4: pci@1c08000 {
> "mhi";
> #address-cells = <3>;
> #size-cells = <2>;
> - ranges = <0x01000000 0 0x00000000 0 0x7c200000 0 0x100000>,
> - <0x02000000 0 0x7c300000 0 0x7c300000 0 0x3d00000>;
> + ranges = <0x01000000 0x0 0x00000000 0x0 0x7c200000 0x0 0x100000>,
> + <0x02000000 0x0 0x7c300000 0x0 0x7c300000 0x0 0x1d00000>;
> bus-range = <0x00 0xff>;
>
> dma-coherent;
>
> ---
> base-commit: 0b58e108042b0ed28a71cd7edf5175999955b233
> change-id: 20240710-topic-barman-57a52f7de103
>
> Best regards,
> --
> Konrad Dybcio <konrad.dybcio@linaro.org>
>
next prev parent reply other threads:[~2024-07-10 14:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-10 14:07 [PATCH] arm64: dts: qcom: x1e80100: Fix up BAR spaces Konrad Dybcio
2024-07-10 14:20 ` Abel Vesa
2024-07-10 14:43 ` Abel Vesa [this message]
2024-10-22 16:25 ` Johan Hovold
2024-10-24 15:55 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zo6d+3T/wcVHiWi1@linaro.org \
--to=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_rjendra@quicinc.com \
--cc=quic_sibis@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).