devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: imx8mp: Remove 'snps,rx-sched-sp'
@ 2024-07-01 20:54 Fabio Estevam
  2024-07-01 21:04 ` Frank Li
  2024-07-02  4:14 ` Shawn Guo
  0 siblings, 2 replies; 4+ messages in thread
From: Fabio Estevam @ 2024-07-01 20:54 UTC (permalink / raw)
  To: shawnguo
  Cc: robh, krzk+dt, conor+dt, imx, devicetree, linux-arm-kernel,
	Fabio Estevam

From: Fabio Estevam <festevam@denx.de>

According to nxp,dwmac-imx.yaml, 'snps,rx-sched-sp' is not a valid
property.

Remove it from the imx8mp board devicetree files to avoid
dt-schema warnings:

... 'snps,tx-sched-sp' does not match any of the regexes

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm64/boot/dts/freescale/imx8mp-beacon-som.dtsi | 2 --
 arch/arm64/boot/dts/freescale/imx8mp-evk.dts         | 1 -
 arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi     | 2 --
 3 files changed, 5 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-beacon-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-beacon-som.dtsi
index 8be251b69378..15f7ab58db36 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-beacon-som.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp-beacon-som.dtsi
@@ -71,7 +71,6 @@ ethphy0: ethernet-phy@3 {
 
 	mtl_rx_setup: rx-queues-config {
 		snps,rx-queues-to-use = <5>;
-		snps,rx-sched-sp;
 
 		queue0 {
 			snps,dcb-algorithm;
@@ -106,7 +105,6 @@ queue4 {
 
 	mtl_tx_setup: tx-queues-config {
 		snps,tx-queues-to-use = <5>;
-		snps,tx-sched-sp;
 
 		queue0 {
 			snps,dcb-algorithm;
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
index c2c708c492c0..35e0ed23bbdb 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
@@ -294,7 +294,6 @@ ethphy0: ethernet-phy@1 {
 
 	mtl_tx_setup: tx-queues-config {
 		snps,tx-queues-to-use = <5>;
-		snps,tx-sched-sp;
 
 		queue0 {
 			snps,dcb-algorithm;
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
index c96e74684e03..d23a3942174d 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
@@ -241,7 +241,6 @@ ethphy0: ethernet-phy@7 {
 
 	mtl_rx_setup: rx-queues-config {
 		snps,rx-queues-to-use = <5>;
-		snps,rx-sched-sp;
 
 		queue0 {
 			snps,dcb-algorithm;
@@ -276,7 +275,6 @@ queue4 {
 
 	mtl_tx_setup: tx-queues-config {
 		snps,tx-queues-to-use = <5>;
-		snps,tx-sched-sp;
 
 		queue0 {
 			snps,dcb-algorithm;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: imx8mp: Remove 'snps,rx-sched-sp'
  2024-07-01 20:54 [PATCH] arm64: dts: imx8mp: Remove 'snps,rx-sched-sp' Fabio Estevam
@ 2024-07-01 21:04 ` Frank Li
  2024-07-01 21:08   ` Fabio Estevam
  2024-07-02  4:14 ` Shawn Guo
  1 sibling, 1 reply; 4+ messages in thread
From: Frank Li @ 2024-07-01 21:04 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: shawnguo, robh, krzk+dt, conor+dt, imx, devicetree,
	linux-arm-kernel, Fabio Estevam

On Mon, Jul 01, 2024 at 05:54:58PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> According to nxp,dwmac-imx.yaml, 'snps,rx-sched-sp' is not a valid
> property.
> 
> Remove it from the imx8mp board devicetree files to avoid
> dt-schema warnings:
> 
> ... 'snps,tx-sched-sp' does not match any of the regexes
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---

No sure why Krzysztof NACK a similar patch

https://lore.kernel.org/imx/cc7aba44-e111-4cb3-b842-f7fedda24113@kernel.org/#t

Frank

>  arch/arm64/boot/dts/freescale/imx8mp-beacon-som.dtsi | 2 --
>  arch/arm64/boot/dts/freescale/imx8mp-evk.dts         | 1 -
>  arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi     | 2 --
>  3 files changed, 5 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-beacon-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-beacon-som.dtsi
> index 8be251b69378..15f7ab58db36 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-beacon-som.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-beacon-som.dtsi
> @@ -71,7 +71,6 @@ ethphy0: ethernet-phy@3 {
>  
>  	mtl_rx_setup: rx-queues-config {
>  		snps,rx-queues-to-use = <5>;
> -		snps,rx-sched-sp;
>  
>  		queue0 {
>  			snps,dcb-algorithm;
> @@ -106,7 +105,6 @@ queue4 {
>  
>  	mtl_tx_setup: tx-queues-config {
>  		snps,tx-queues-to-use = <5>;
> -		snps,tx-sched-sp;
>  
>  		queue0 {
>  			snps,dcb-algorithm;
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
> index c2c708c492c0..35e0ed23bbdb 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
> @@ -294,7 +294,6 @@ ethphy0: ethernet-phy@1 {
>  
>  	mtl_tx_setup: tx-queues-config {
>  		snps,tx-queues-to-use = <5>;
> -		snps,tx-sched-sp;
>  
>  		queue0 {
>  			snps,dcb-algorithm;
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
> index c96e74684e03..d23a3942174d 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
> @@ -241,7 +241,6 @@ ethphy0: ethernet-phy@7 {
>  
>  	mtl_rx_setup: rx-queues-config {
>  		snps,rx-queues-to-use = <5>;
> -		snps,rx-sched-sp;
>  
>  		queue0 {
>  			snps,dcb-algorithm;
> @@ -276,7 +275,6 @@ queue4 {
>  
>  	mtl_tx_setup: tx-queues-config {
>  		snps,tx-queues-to-use = <5>;
> -		snps,tx-sched-sp;
>  
>  		queue0 {
>  			snps,dcb-algorithm;
> -- 
> 2.34.1
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: imx8mp: Remove 'snps,rx-sched-sp'
  2024-07-01 21:04 ` Frank Li
@ 2024-07-01 21:08   ` Fabio Estevam
  0 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2024-07-01 21:08 UTC (permalink / raw)
  To: Frank Li
  Cc: shawnguo, robh, krzk+dt, conor+dt, imx, devicetree,
	linux-arm-kernel, Fabio Estevam

On Mon, Jul 1, 2024 at 6:04 PM Frank Li <Frank.li@nxp.com> wrote:

> No sure why Krzysztof NACK a similar patch

If I understood correctly, he did not provide a Reviewed-by tag on that patch.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: imx8mp: Remove 'snps,rx-sched-sp'
  2024-07-01 20:54 [PATCH] arm64: dts: imx8mp: Remove 'snps,rx-sched-sp' Fabio Estevam
  2024-07-01 21:04 ` Frank Li
@ 2024-07-02  4:14 ` Shawn Guo
  1 sibling, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2024-07-02  4:14 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: shawnguo, robh, krzk+dt, conor+dt, imx, devicetree,
	linux-arm-kernel, Fabio Estevam

On Mon, Jul 01, 2024 at 05:54:58PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> According to nxp,dwmac-imx.yaml, 'snps,rx-sched-sp' is not a valid
> property.
> 
> Remove it from the imx8mp board devicetree files to avoid
> dt-schema warnings:
> 
> ... 'snps,tx-sched-sp' does not match any of the regexes
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Applied, thanks!


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-07-02  4:15 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-01 20:54 [PATCH] arm64: dts: imx8mp: Remove 'snps,rx-sched-sp' Fabio Estevam
2024-07-01 21:04 ` Frank Li
2024-07-01 21:08   ` Fabio Estevam
2024-07-02  4:14 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).