From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 52B6478C75; Mon, 8 Jul 2024 14:55:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720450537; cv=none; b=eBJYLeVgGjv71D/vzWoFHdldddZXEjB4/NX8dEr4Hi35fj9PFhC3Cp6pVwxS5UlwRq7cv5zGCt3bza/sMV24y3UHwnL2EMuSeh+2kZn47mHuozN4K6wNGTcRstlYxZeW1yJMULNR1bMMYyMGNi5DMok9UNQZ5zx9gguUU0OPCVA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720450537; c=relaxed/simple; bh=PE42KBFhGlWopSbb9HwFgyvZxhtwLCUTz4w/jhjsbmQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kS6u0pqi3xVeqFTEaywxi2ODH94cmxhAtknkPYGUMwAqahr7ZHd273aEqByeFTv6feGxQdM2fVwP8h2atcr4qwgqLbjP0HJ6Eayky/h68rXdMMe2S8w2HMmM3/xctEocQRj+ohBQB4fHLm0cWmoDYl3VpvGLcVyUnTRPeDoacZ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A3B3C1042; Mon, 8 Jul 2024 07:55:59 -0700 (PDT) Received: from pluto (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1E6513F641; Mon, 8 Jul 2024 07:55:33 -0700 (PDT) Date: Mon, 8 Jul 2024 15:55:30 +0100 From: Cristian Marussi To: Peng Fan Cc: Cristian Marussi , Sudeep Holla , "Peng Fan (OSS)" , "robh@kernel.org" , "krzk+dt@kernel.org" , "conor+dt@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "arm-scmi@vger.kernel.org" , "devicetree@vger.kernel.org" Subject: Re: [PATCH V2 1/2] dt-bindings: firmware: arm,scmi: introduce property mbox-rx-timeout-ms Message-ID: References: <20240703031715.379815-1-peng.fan@oss.nxp.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Jul 04, 2024 at 11:48:31PM +0000, Peng Fan wrote: > > Subject: Re: [PATCH V2 1/2] dt-bindings: firmware: arm,scmi: introduce > > property mbox-rx-timeout-ms > > > > On Thu, Jul 04, 2024 at 12:33:09PM +0000, Peng Fan wrote: > > > > Subject: Re: [PATCH V2 1/2] dt-bindings: firmware: arm,scmi: > > > > introduce property mbox-rx-timeout-ms > > > > > > > > On Thu, Jul 04, 2024 at 10:39:53AM +0000, Peng Fan wrote: > > > > > > Subject: Re: [PATCH V2 1/2] dt-bindings: firmware: arm,scmi: > > > > > > introduce property mbox-rx-timeout-ms > > > > > > > > > > > > On Wed, Jul 03, 2024 at 11:17:14AM +0800, Peng Fan (OSS) > > wrote: > > > > > > > From: Peng Fan > > > > > > > > > > > > > > System Controller Management Interface(SCMI) firmwares > > might > > > > > > have > > > > > > > different designs by SCMI firmware developers. So the > > maximum > > > > > > receive > > > > > > > channel timeout value might also varies in the various designs. > > > > > > > > > > > > > > So introduce property mbox-rx-timeout-ms to let each > > platform > > > > > > > could set its own timeout value in device tree. > > > > > > > > > > > > > > Signed-off-by: Peng Fan > > > > > > > --- > > > > > > > > > > > > > > V2: > > > > > > > Drop defaults, update description. > > > > > > > > > > > > > > Documentation/devicetree/bindings/firmware/arm,scmi.yaml > > | 6 > > > > > > ++++++ > > > > > > > 1 file changed, 6 insertions(+) > > > > > > > > > > > > > > diff --git > > > > > > a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > > > > > > > > > b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > > > > > > > index ebf384e76df1..dcac0b36c76f 100644 > > > > > > > --- > > > > a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > > > > > > > +++ > > > > b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > > > > > > > @@ -121,6 +121,12 @@ properties: > > > > > > > atomic mode of operation, even if requested. > > > > > > > default: 0 > > > > > > > > > > > > > > + max-rx-timeout-ms: > > > > > > > + description: > > > > > > > + An optional time value, expressed in milliseconds, > > > > > > > + representing > > > > > > the > > > > > > > + mailbox maximum timeout value for receive channel. The > > > > > > > + value > > > > > > should > > > > > > > + be a non-zero value if set. > > > > > > > + > > > > > > > > > > > > IIRC, you had the min and max constraint in the earlier response. > > > > > > You need to have rushed and posted another version before I > > > > > > could respond with my preference. > > > > > > > > > > > > So there is no rush, these are v6.12 material. Take time for > > > > > > respining and give some time for the review. > > > > > > > > > > Sure. I just not sure what the maximum should be set, so I drop > > > > > the minimum and maximum from my previous email. > > > > > > > > > > > > > Worst case we can just have min constraint to indicate it must be > > > > non- zero value as you have mentioned above and drop that > > statement > > > > as it becomes explicit with the constraint. > > > > > > I'll use below in v3: > > > max-rx-timeout-ms: > > > description: > > > An optional time value, expressed in milliseconds, representing > > the > > > mailbox maximum timeout value for receive channel. The value > > should > > > be a non-zero value if set. > > > minimum: 1 > > > > > > Put the binding away, when you have time, please check whether the > > > driver changes are good or not. > > > BTW, since our Android team is waiting for this patchset got R-b or > > > A-b, then the patches could be accepted by Google common kernel, > > we > > > could support GKI in our release which is soon in near days. So I am > > > being pushed :) > > > > Hi Peng, > > > > once the bindings are accepted I wanted to fold also this series of yours > > in my transport rework series. > > No problem, feel free to take it into your series, I will post out V3 later(wait > if Sudeep is ok with I add minimum 1 or not), but v3 2/2 should be same > as v2 2/2. > Still not taken in transport rework V1, but not forgotten :D Thanks, Cristian