devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Abel Vesa <abel.vesa@linaro.org>
To: Johan Hovold <johan+linaro@kernel.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Sibi Sankar <quic_sibis@quicinc.com>,
	Rajendra Nayak <quic_rjendra@quicinc.com>,
	Xilin Wu <wuxilin123@gmail.com>,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/12] arm64: dts: qcom: x1e80100-qcp: fix up PCIe6a pinctrl node
Date: Mon, 22 Jul 2024 13:03:01 +0300	[thread overview]
Message-ID: <Zp4uVfQa+Bt026xV@linaro.org> (raw)
In-Reply-To: <20240722095459.27437-3-johan+linaro@kernel.org>

On 24-07-22 11:54:49, Johan Hovold wrote:
> The PCIe6a pinctrl node appears to have been copied from the sc8280xp
> CRD dts, which has the NVMe on pcie2a and uses some funny indentation.
> 
> Fix up the node name to match the x1e80100 use and label and use only
> tabs for indentation.
> 
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>

Reviewed-by: Abel Vesa <abel.vesa@linaro.org>

> ---
>  arch/arm64/boot/dts/qcom/x1e80100-qcp.dts | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts b/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
> index 212ed20b3369..86735f07fbb5 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
> +++ b/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
> @@ -665,7 +665,7 @@ nvme_reg_en: nvme-reg-en-state {
>  		bias-disable;
>  	};
>  
> -	pcie6a_default: pcie2a-default-state {
> +	pcie6a_default: pcie6a-default-state {
>  		clkreq-n-pins {
>  			pins = "gpio153";
>  			function = "pcie6a_clk";
> @@ -681,11 +681,11 @@ perst-n-pins {
>  		};
>  
>  		wake-n-pins {
> -		       pins = "gpio154";
> -		       function = "gpio";
> -		       drive-strength = <2>;
> -		       bias-pull-up;
> -	       };
> +			pins = "gpio154";
> +			function = "gpio";
> +			drive-strength = <2>;
> +			bias-pull-up;
> +		};
>  	};
>  };
>  
> -- 
> 2.44.2
> 

  parent reply	other threads:[~2024-07-22 10:03 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-22  9:54 [PATCH 00/12] arm64: dts: qcom: x1e80100: QCP/Vivobook/Yoga PCIe fixes Johan Hovold
2024-07-22  9:54 ` [PATCH 01/12] arm64: dts: qcom: x1e80100-qcp: fix PCIe4 PHY supply Johan Hovold
2024-07-22 10:02   ` Konrad Dybcio
2024-07-22 10:02   ` Abel Vesa
2024-07-22  9:54 ` [PATCH 02/12] arm64: dts: qcom: x1e80100-qcp: fix up PCIe6a pinctrl node Johan Hovold
2024-07-22 10:02   ` Konrad Dybcio
2024-07-22 10:03   ` Abel Vesa [this message]
2024-07-22  9:54 ` [PATCH 03/12] arm64: dts: qcom: x1e80100-qcp: disable PCIe6a perst pull down Johan Hovold
2024-07-22 10:02   ` Konrad Dybcio
2024-07-22 10:03   ` Abel Vesa
2024-07-22  9:54 ` [PATCH 04/12] arm64: dts: qcom: x1e80100-qcp: fix missing PCIe4 gpios Johan Hovold
2024-07-22 10:02   ` Konrad Dybcio
2024-07-22  9:54 ` [PATCH 05/12] arm64: dts: qcom: x1e80100-vivobook-s15: fix PCIe4 PHY supply Johan Hovold
2024-07-22 10:03   ` Konrad Dybcio
2024-07-22  9:54 ` [PATCH 06/12] arm64: dts: qcom: x1e80100-vivobook-s15: fix up PCIe6a pinctrl node Johan Hovold
2024-07-22 10:03   ` Konrad Dybcio
2024-07-22  9:54 ` [PATCH 07/12] arm64: dts: qcom: x1e80100-vivobook-s15: disable PCIe6a perst pull down Johan Hovold
2024-07-22 10:03   ` Konrad Dybcio
2024-07-22  9:54 ` [PATCH 08/12] arm64: dts: qcom: x1e80100-vivobook-s15: fix missing PCIe4 gpios Johan Hovold
2024-07-22 10:03   ` Konrad Dybcio
2024-07-22  9:54 ` [PATCH 09/12] arm64: dts: qcom: x1e80100-yoga-slim7x: fix PCIe4 PHY supply Johan Hovold
2024-07-22 10:03   ` Konrad Dybcio
2024-07-22  9:54 ` [PATCH 10/12] arm64: dts: qcom: x1e80100-yoga-slim7x: fix up PCIe6a pinctrl node Johan Hovold
2024-07-22 10:03   ` Konrad Dybcio
2024-07-22  9:54 ` [PATCH 11/12] arm64: dts: qcom: x1e80100-yoga-slim7x: disable PCIe6a perst pull down Johan Hovold
2024-07-22 10:04   ` Konrad Dybcio
2024-07-22  9:54 ` [PATCH 12/12] arm64: dts: qcom: x1e80100-yoga-slim7x: fix missing PCIe4 gpios Johan Hovold
2024-07-22 10:04   ` Konrad Dybcio
2024-07-29  3:58 ` [PATCH 00/12] arm64: dts: qcom: x1e80100: QCP/Vivobook/Yoga PCIe fixes Bjorn Andersson
2024-08-01  3:19 ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zp4uVfQa+Bt026xV@linaro.org \
    --to=abel.vesa@linaro.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=johan+linaro@kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_rjendra@quicinc.com \
    --cc=quic_sibis@quicinc.com \
    --cc=robh@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=wuxilin123@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).