From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f67.google.com (mail-ej1-f67.google.com [209.85.218.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7177C125D6 for ; Mon, 22 Jul 2024 14:40:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.67 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721659255; cv=none; b=Jfz2zBV7dFDQVVhu5b/oRy3JL96S3DO7IUOzAfpoL4ZGF1CJfqS74vg3JmogZp8URYbTxitSBSGJBxh+QmmX5VLtH7RHIp5l3sArgLs+DLRb3OZFNhC5aK+srBgKjW0O1CkE0J3DsLc1FXF1JaYPXGigzlhi2Po6QK1XbQw4wpc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721659255; c=relaxed/simple; bh=o51mjZOr7upQQVamh4+U9Js9b7LkHzgOy/EvXR5VmYo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pLAKSrd/ZFt2pQF5mHZuMtR08p4JPLhaoZx7D3VeZWwmgX7ZtgjkrrGS4c35r8/2Vlj2vb8Y4zA4a6LSxJlmx86TnhRhJfBeCMV6TTV1gYh4AosRn4CpjdDdLjzeEE2EpiOovYMCJLX4Lu6xq/LaGLnBWFWBZ25tkBD4ufXSIdE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=cRm8tlkz; arc=none smtp.client-ip=209.85.218.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cRm8tlkz" Received: by mail-ej1-f67.google.com with SMTP id a640c23a62f3a-a6fd513f18bso397863666b.3 for ; Mon, 22 Jul 2024 07:40:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721659252; x=1722264052; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=V2nvyjeyG9ehh9Y2EyZ5Wh77KHFZbpScnbBRLqxpiKU=; b=cRm8tlkz2jqUxLehXLwzAcpaO3eJ8wz1x4nltAUKt9JLziYpLvttISo0uiybp9dKrk DE/EIZOhbsOoGke5wWCfW8G68ENYdJ57pQ7gWW2N+gUt/K7Ec/pnQzBgCV0A0vwnCfyx Y9Yti6vHPv/yUj9gDNqbCrBjGKex/Aij5i+UDNYVlReqkEMzLipOtmHQsAfWkdtSaayv fRx9jMotdKd7vS2zcnOMcRUhWd0uV8EDZkEKa92jDoW0dgD68ShnM1pMspo8kA5ibFhI Ch5vDDdqyLveP7kDxH+NRwj52AVAZSdfbByFZ++liRbNope3FkgIE3YL7slzQ3aMxiiq cUww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721659252; x=1722264052; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=V2nvyjeyG9ehh9Y2EyZ5Wh77KHFZbpScnbBRLqxpiKU=; b=aoX5ej/QEhNs3dWLeZFnM1Xee61YqeyZfNgjePkU/bdr/XadaWT3ZwLMOg8k273SF6 tl9AxOdqa77wiccbvupxKTCdUHKPxN5cESj36K97+ifPPKniKLVWlAcXTKhaQaNbk+BK 6WwT0BuxYWO6qVCzPGxYD9Qt2Av9cNvHdeM5J2q9fVgmjSKWuuqPC7a9JwXjyOBlX6jq uWk/lTaQF074BX7xGIDJSZInud3ZQKMJSC0qZ3bYA69HTHYHKDGZ7Fw9iuL9rBc6hfir PIGtrvsb3FBTUVU2bx9s2tfe18psvmTxQqmgS8pWIrghmibSvdrkkiN4ORhjzxlq+N/b LOhw== X-Forwarded-Encrypted: i=1; AJvYcCXNJ73DInpvTk/8pqrz9I/G2jXsqdHzJ9v6U/TRQ2Yn7958biiAxEso6uohKSSWjB6o9r0cIrbHs6BpcricDUfF4qYIOqIJzhYusA== X-Gm-Message-State: AOJu0YyeBwp08Q1pduXx5Diaouio2O1ORPW1lZay1xgQCDryVVHlaJSI g1RQgItm/ms6wiXo7+vZBTvZZ0j51vBpBUuN4NSuOl72aWtQfsjStXvxRYFzIdY= X-Google-Smtp-Source: AGHT+IEEF4doNpQ4j9pHl5lqNBYbD9TdMrhFVijh96wG9AzNjMvvhfqhK8pCT6DFqqeJb99NbsGvUQ== X-Received: by 2002:a17:907:7d86:b0:a79:81a4:faff with SMTP id a640c23a62f3a-a7a885a1867mr6508766b.66.1721659251733; Mon, 22 Jul 2024 07:40:51 -0700 (PDT) Received: from linaro.org ([2a02:2454:ff1f:b280:702:9410:ae6e:5c88]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7a3c9510e6sm428501066b.222.2024.07.22.07.40.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jul 2024 07:40:51 -0700 (PDT) Date: Mon, 22 Jul 2024 16:40:46 +0200 From: Stephan Gerhold To: Rob Clark Cc: linux-arm-msm@vger.kernel.org, Doug Anderson , Dmitry Baryshkov , Abel Vesa , Rob Clark , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: x1e80100-yoga: Update panel bindings Message-ID: References: <20240719185250.4877-1-robdclark@gmail.com> <20240719185250.4877-2-robdclark@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Jul 22, 2024 at 07:37:05AM -0700, Rob Clark wrote: > On Mon, Jul 22, 2024 at 12:15 AM Stephan Gerhold > wrote: > > > > On Fri, Jul 19, 2024 at 11:52:50AM -0700, Rob Clark wrote: > > > From: Rob Clark > > > > > > Use the correct panel compatible, and wire up enable-gpio. It is wired > > > up in the same way as the x1e80100-crd. > > > > > > Signed-off-by: Rob Clark > > > --- > > > .../boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts | 13 ++++++++++++- > > > 1 file changed, 12 insertions(+), 1 deletion(-) > > > > > > diff --git a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts > > > index f569f0fbd1fc..28a6ea5a24fd 100644 > > > --- a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts > > > +++ b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts > > > @@ -592,9 +592,13 @@ &mdss_dp3 { > > > > > > aux-bus { > > > panel { > > > - compatible = "edp-panel"; > > > + compatible = "samsung,atna45dc02", "samsung,atna33xc20"; > > > + enable-gpios = <&pmc8380_3_gpios 4 GPIO_ACTIVE_HIGH>; > > > power-supply = <&vreg_edp_3p3>; > > > > > > + pinctrl-0 = <&edp_bl_en>; > > > + pinctrl-names = "default"; > > > + > > > port { > > > edp_panel_in: endpoint { > > > remote-endpoint = <&mdss_dp3_out>; > > > @@ -663,6 +667,13 @@ &pcie6a_phy { > > > status = "okay"; > > > }; > > > > > > +&pmc8380_3_gpios { > > > + edp_bl_en: edp-bl-en-state { > > > + pins = "gpio4"; > > > + function = "normal"; > > > + }; > > > > Did you omit the "power-source" here on purpose? It works without > > because the firmware already configures this pin, but ideally we should > > provide the full configuration. > > I just copied the CRD.. other than the panel, things appear to be > wired up in the same way. > It looks like Abel has an older version of my patch in his tree. The patch that I sent upstream has the "power-source": https://lore.kernel.org/linux-arm-msm/20240715-x1e80100-crd-backlight-v2-3-31b7f2f658a3@linaro.org/ Can you copy it from there? Thanks, Stephan