From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 243AA18C336 for ; Mon, 15 Jul 2024 12:55:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721048110; cv=none; b=PGLWHzYkadZsJKh5voX/2asDtyByu/gw8NvVeHHLHOOFsZ5RsEW38v7lnZb27/XhNKDkLlQAIF2jAC7ySqFsZnDevekgdyFPAU7Hynq47iyByDQsIqUSklXj/CXjY3N17qoVsfvxlbM/fJDM6T+/GPbuIb2jcY6uSpTp0BhGqRw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721048110; c=relaxed/simple; bh=zxjn8Ies8hbdduPV97Mi32mWBnX9BtuG8RYZ9bOlCDY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ghr6xJgPd/EIL4wvDbHV/Qv2Mv9+dMMfqLUBIBSCb4DYuyAhzGWf1I19NUDFqaqWQu24wBZtaxJ+OIiXCO/8WuSe2NmgfjyxGJYMp9+DotNGOkQn1AmX9vEaL8sG37NFqlpEGB4PDVOhnoGLjioFWEYC5ksUPFqJ1gXN+cczsDs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=GJHFa6yu; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GJHFa6yu" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4266ea6a488so32996365e9.1 for ; Mon, 15 Jul 2024 05:55:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721048105; x=1721652905; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xD+Qv3tXsMOBLCom0uRSOSXVlQMZrezJqRHpcu3ciB4=; b=GJHFa6yu+AlmUDNLdXlfGbOyl81GlU674mWXP7kJfh1jyfeSu97YKr8QW5tMnVyshC tYKRQ8fgFUpnY4Wwt9rL2dDg9Q/eueAfto9vR3FlVCSrpxJGR2lipMqcMDg2BPwJT2v0 t1vqVCKXoImJpC+AjQosj+dNn2YclnpWuDbkfb+ttDvbf+YquuhtR1Al7kUj13FyvZIs dSYrJuSuJNLwpcLS1w+S9wUmZ+4Vg/GoVgGEDpb3GMn/INXX5s+0Txw+ikqlVtBDgsNW e+wVsSQe2GyLWa4Ta9AIwrjOFxs/XC+RTKodj7cksgv8R0uqdJe8xF8zAAw9hrQ1OsjV 197w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721048105; x=1721652905; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xD+Qv3tXsMOBLCom0uRSOSXVlQMZrezJqRHpcu3ciB4=; b=QdjO4jjEdyT4eOm8worlQTkIlvxVH2qFsd5lB7Ux04Jr3/OgrqsQyWqtZaOacjV8GW Wo/ezZkX0pfxQF/DyO6RxzBSi8v3zlGdU+16tr/sDY5Rl2Oyr98EoOch9ZbYOVKidSOr GPdF+1oyIcYjw+Orz/sJcUOgfwPtT6EDq3bwmT2J/nZ1K7DJF2o1q3XZAeRdUMB6/ziJ v/jcK9XQpO8Z/yU3NFQUNt27JGh88PmbQywMiIrw8u6/XapDLCurLG/YiB9KZtRhqpnc kKh09dzKnklF7Uxw+FrthABPZOiNp+XuwyfBEiyRp40rgF8JsYwQg05VAJPXnhxkXNCI s22A== X-Forwarded-Encrypted: i=1; AJvYcCVGwsuy1cSfPHZGpmGSl4uzDtp1xeSYt9BwhnBlZuh9nEKbNabe3Xf0EIWDd3R/aDOebXNEn5T7NJgWaiUcQQN+FEQMGV3ZHwTAYQ== X-Gm-Message-State: AOJu0YyqKtdyiMQnJ1D5c3gmi7Dgua7p/1QBQk3yzZ/IAIheFdglB/5+ FF2w0YimEXj0EQoMAlTaZPwlRRMS+fT7LBJIzSzYEQSIT5z7ubiPQLj9UGRrrPE= X-Google-Smtp-Source: AGHT+IFVvTPewQl9xsuC6PQHCLCw7VPZ3EYcEq7OprdCTajdkMctnkeRvosj+jwyjRqqLqq4veQmFg== X-Received: by 2002:a5d:6981:0:b0:367:9903:a91 with SMTP id ffacd0b85a97d-367cea45c68mr15872686f8f.11.1721048105426; Mon, 15 Jul 2024 05:55:05 -0700 (PDT) Received: from linaro.org ([2a02:2454:ff1f:b280:82fb:4328:f644:289a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4279f25abf0sm121761985e9.14.2024.07.15.05.55.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jul 2024 05:55:05 -0700 (PDT) Date: Mon, 15 Jul 2024 14:54:59 +0200 From: Stephan Gerhold To: Neil Armstrong Cc: Bjorn Andersson , Konrad Dybcio , Jessica Zhang , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Douglas Anderson , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Abel Vesa , Johan Hovold Subject: Re: [PATCH v2 2/4] Revert "drm/panel-edp: Add SDC ATNA45AF01" Message-ID: References: <20240715-x1e80100-crd-backlight-v2-0-31b7f2f658a3@linaro.org> <20240715-x1e80100-crd-backlight-v2-2-31b7f2f658a3@linaro.org> <7daa3c0d-cecf-4f50-be32-ae116b920db0@linaro.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7daa3c0d-cecf-4f50-be32-ae116b920db0@linaro.org> On Mon, Jul 15, 2024 at 02:42:12PM +0200, Neil Armstrong wrote: > On 15/07/2024 14:15, Stephan Gerhold wrote: > > This reverts commit 8ebb1fc2e69ab8b89a425e402c7bd85e053b7b01. > > > > The panel should be handled through the samsung-atna33xc20 driver for > > correct power up timings. Otherwise the backlight does not work correctly. > > > > We have existing users of this panel through the generic "edp-panel" > > compatible (e.g. the Qualcomm X1E80100 CRD), but the screen works only > > partially in that configuration: It works after boot but once the screen > > gets disabled it does not turn on again until after reboot. It behaves the > > same way with the default "conservative" timings, so we might as well drop > > the configuration from the panel-edp driver. That way, users with old DTBs > > will get a warning and can move to the new driver. > > > > Reviewed-by: Douglas Anderson > > Signed-off-by: Stephan Gerhold > > --- > > drivers/gpu/drm/panel/panel-edp.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c > > index 3a574a9b46e7..d2d682385e89 100644 > > --- a/drivers/gpu/drm/panel/panel-edp.c > > +++ b/drivers/gpu/drm/panel/panel-edp.c > > @@ -1960,8 +1960,6 @@ static const struct edp_panel_entry edp_panels[] = { > > EDP_PANEL_ENTRY('L', 'G', 'D', 0x05af, &delay_200_500_e200_d200, "Unknown"), > > EDP_PANEL_ENTRY('L', 'G', 'D', 0x05f1, &delay_200_500_e200_d200, "Unknown"), > > - EDP_PANEL_ENTRY('S', 'D', 'C', 0x416d, &delay_100_500_e200, "ATNA45AF01"), > > - > > EDP_PANEL_ENTRY('S', 'H', 'P', 0x1511, &delay_200_500_e50, "LQ140M1JW48"), > > EDP_PANEL_ENTRY('S', 'H', 'P', 0x1523, &delay_80_500_e50, "LQ140M1JW46"), > > EDP_PANEL_ENTRY('S', 'H', 'P', 0x153a, &delay_200_500_e50, "LQ140T1JH01"), > > > > How will we handle current/old crd DT with new kernels ? > I think this is answered in the commit message: > > We have existing users of this panel through the generic "edp-panel" > > compatible (e.g. the Qualcomm X1E80100 CRD), but the screen works only > > partially in that configuration: It works after boot but once the screen > > gets disabled it does not turn on again until after reboot. It behaves the > > same way with the default "conservative" timings, so we might as well drop > > the configuration from the panel-edp driver. That way, users with old DTBs > > will get a warning and can move to the new driver. Basically with the entry removed, the panel-edp driver will fallback to default "conservative" timings when using old DTBs. There will be a warning in dmesg, but otherwise the panel will somewhat work just as before. I think this is a good way to remind users to upgrade. > Same question for patch 3, thie serie introduces a bindings that won't be valid > if we backport patch 3. I don't think patch should be backported, and this patch > should be dropped. There would be a dtbs_check warning, yeah. Functionally, it would work just fine. Is that reason enough to keep display partially broken for 6.11? We could also apply the minor binding change for 6.11 if needed. I'm also fine if this just goes into 6.12 though. Thanks, Stephan