From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F7B418C344 for ; Mon, 15 Jul 2024 13:11:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721049064; cv=none; b=qF8qTpUHco9VBw0vT32ODNfsL6aZNE53OXtPp0SN1gGF9TikROpxtyBVEz4EYTkPfKE63Hc+Y92e44B3OPUAzWh0P7gXU1x93wB1f6m4++T4vLX3RSCsyVk7T781l6wUJtJShswNbl8DtoTOD+v2CwqKXTD+cf4eW7+Dh0V7goE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721049064; c=relaxed/simple; bh=QOmrlh86HNBabKQAYhgfGUKbP84IU6qGzPgWb0wPX64=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WgcIqH1BhOwdjJT7G4BqYbWcYZrVUk6D1wN0vSsxamKhTIcGjPGuQ+n9q0xhgbFjUupUwEP0Ov6R+DFIjU3HVVBofQLSqQHcAmOHLGbNwO7h894BZD0uKEJXOLNGZ/atLEcxtaQ/EJtsuM+2R/s1kWgtAQUyveYCiiI6huLJ31Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=gByfCWMu; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gByfCWMu" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4266edee10cso26907165e9.2 for ; Mon, 15 Jul 2024 06:11:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721049061; x=1721653861; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=CccdwCAsE/kNApiEDZLKr3tDI54YdE2r4/ctaUuOXYQ=; b=gByfCWMuLwR6mgICy24frGgBfMsWvmvLjlYw3UNzi4uZx0XktLiSqPRMQzJ8DKtgb3 TF78+1bIDXH6Ms/8HcK+rUWG6GwgsqE29SvJvvg6BpAxyZ/YIUP4bCWPRL5oPwCydFSf bKruXNrvsLDfFt0prsmX9lHNNwYLGW8kDsjPUVvOz3m4F/j+3HFMskI8j6GML2FFoUTk yT78ibJkGIUiX97sZOGgxL1eFDoPf7bshYLQzze3xTx3fE3I3PpPbeYlXxoOSpxXOZX2 ESdHgGIAfrdGPotEqtIwWL21wg7GMyuqLzj9Ue6kIbWtTOTX0tSJNFvHT9AdqUm/IXJG f7NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721049061; x=1721653861; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CccdwCAsE/kNApiEDZLKr3tDI54YdE2r4/ctaUuOXYQ=; b=EvrfexD42iERHugAfYZL+xFKu4hZ7KxL02IaJEaR2zfEhVzQxNh47Z9a26VK6Swl9x /yyPc43gr+1WJe2ylfbMlcy5xgBJ2cwQiqRN2sDWcQrM91lUQZJGcboRnO5y7JxLV6vO j0bZcy0jKYxTRisGej9QboNAHuR6jzuXKFn2x5It9McY3XFb5PWl2TWGf5ldH2Gy1sDh 32CRpfwLkIOg9asEBvpJXmMaxP0sDWTN4Lg6I+ajYH6LGbLpzOhDQB8ar3SZT05lqxGB y0FX0pEVnLeAJ58MOlmW9qQ6evyw6LFS1DPcMSeqIuMZsVGxG61YYmo9Rsf/GV+qo1On TfQw== X-Forwarded-Encrypted: i=1; AJvYcCUNHA9e0YqbsS8LvA/NSm4gmrdabVw2tq+E02aIqmjRXtW/09shoORmYLuAXgWm1XAUDihOqIimPhC2/vrYzqPLhgI8O9WpE8fgYg== X-Gm-Message-State: AOJu0YxslwIq7W0xJEcdprpOZxJmDcrluA7ogIL0kvFGWvVlHwDuFtze +T5vH3vvDNpetiM83MhXHUhBzUztnCVMeLmRaaF42Ny44Zm+wXTr1bYA447WX+A= X-Google-Smtp-Source: AGHT+IHxl518O6ITVCk9V/YPVUHaWCVxMHpCeykVBPqlp1eRMIDm6iZ4oNUH532REJXAAfP1dtKMXw== X-Received: by 2002:a05:6000:50b:b0:367:980a:6aa with SMTP id ffacd0b85a97d-367ceaca978mr11732523f8f.54.1721049060962; Mon, 15 Jul 2024 06:11:00 -0700 (PDT) Received: from linaro.org ([2a02:2454:ff1f:b280:82fb:4328:f644:289a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3680dafbec3sm6389737f8f.85.2024.07.15.06.11.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jul 2024 06:11:00 -0700 (PDT) Date: Mon, 15 Jul 2024 15:10:54 +0200 From: Stephan Gerhold To: Neil Armstrong Cc: Bjorn Andersson , Konrad Dybcio , Jessica Zhang , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Douglas Anderson , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Abel Vesa , Johan Hovold Subject: Re: [PATCH v2 2/4] Revert "drm/panel-edp: Add SDC ATNA45AF01" Message-ID: References: <20240715-x1e80100-crd-backlight-v2-0-31b7f2f658a3@linaro.org> <20240715-x1e80100-crd-backlight-v2-2-31b7f2f658a3@linaro.org> <7daa3c0d-cecf-4f50-be32-ae116b920db0@linaro.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jul 15, 2024 at 03:01:57PM +0200, Neil Armstrong wrote: > On 15/07/2024 14:54, Stephan Gerhold wrote: > > On Mon, Jul 15, 2024 at 02:42:12PM +0200, Neil Armstrong wrote: > > > On 15/07/2024 14:15, Stephan Gerhold wrote: > > > > This reverts commit 8ebb1fc2e69ab8b89a425e402c7bd85e053b7b01. > > > > > > > > The panel should be handled through the samsung-atna33xc20 driver for > > > > correct power up timings. Otherwise the backlight does not work correctly. > > > > > > > > We have existing users of this panel through the generic "edp-panel" > > > > compatible (e.g. the Qualcomm X1E80100 CRD), but the screen works only > > > > partially in that configuration: It works after boot but once the screen > > > > gets disabled it does not turn on again until after reboot. It behaves the > > > > same way with the default "conservative" timings, so we might as well drop > > > > the configuration from the panel-edp driver. That way, users with old DTBs > > > > will get a warning and can move to the new driver. > > > > > > > > Reviewed-by: Douglas Anderson > > > > Signed-off-by: Stephan Gerhold > > > > --- > > > > drivers/gpu/drm/panel/panel-edp.c | 2 -- > > > > 1 file changed, 2 deletions(-) > > > > > > > > diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c > > > > index 3a574a9b46e7..d2d682385e89 100644 > > > > --- a/drivers/gpu/drm/panel/panel-edp.c > > > > +++ b/drivers/gpu/drm/panel/panel-edp.c > > > > @@ -1960,8 +1960,6 @@ static const struct edp_panel_entry edp_panels[] = { > > > > EDP_PANEL_ENTRY('L', 'G', 'D', 0x05af, &delay_200_500_e200_d200, "Unknown"), > > > > EDP_PANEL_ENTRY('L', 'G', 'D', 0x05f1, &delay_200_500_e200_d200, "Unknown"), > > > > - EDP_PANEL_ENTRY('S', 'D', 'C', 0x416d, &delay_100_500_e200, "ATNA45AF01"), > > > > - > > > > EDP_PANEL_ENTRY('S', 'H', 'P', 0x1511, &delay_200_500_e50, "LQ140M1JW48"), > > > > EDP_PANEL_ENTRY('S', 'H', 'P', 0x1523, &delay_80_500_e50, "LQ140M1JW46"), > > > > EDP_PANEL_ENTRY('S', 'H', 'P', 0x153a, &delay_200_500_e50, "LQ140T1JH01"), > > > > > > > > > > How will we handle current/old crd DT with new kernels ? > > > > > > > I think this is answered in the commit message: > > > > > > We have existing users of this panel through the generic "edp-panel" > > > > compatible (e.g. the Qualcomm X1E80100 CRD), but the screen works only > > > > partially in that configuration: It works after boot but once the screen > > > > gets disabled it does not turn on again until after reboot. It behaves the > > > > same way with the default "conservative" timings, so we might as well drop > > > > the configuration from the panel-edp driver. That way, users with old DTBs > > > > will get a warning and can move to the new driver. > > > > Basically with the entry removed, the panel-edp driver will fallback to > > default "conservative" timings when using old DTBs. There will be a > > warning in dmesg, but otherwise the panel will somewhat work just as > > before. I think this is a good way to remind users to upgrade. > > I consider this as a regression > Personally, I don't think we can regress something that was already broken. There is no point in continuing to use the broken state - it is rather frustrating if your display goes off for power saving or suspend and you cannot get it back on until you reboot. > > > > > Same question for patch 3, thie serie introduces a bindings that won't be valid > > > if we backport patch 3. I don't think patch should be backported, and this patch > > > should be dropped. > > > > There would be a dtbs_check warning, yeah. Functionally, it would work > > just fine. Is that reason enough to keep display partially broken for > > 6.11? We could also apply the minor binding change for 6.11 if needed. > > I don't know how to answer this, I'll let the DT maintainer comment this. > > The problem is I do not think we can pass the whole patchset as fixes > for v6.11, patches 2 & 3 could, patches 1 & 4 definitely can't. > Fair enough, I'm also fine if these patches go just into 6.12. I think there are no changes in the patches needed for that, the Fixes tag is still appropriate and I intentionally omitted the Cc stable tag. Thanks, Stephan