From: Johan Hovold <johan@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Akhil P Oommen <quic_akhilpo@quicinc.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: disable GPU on x1e80100 by default
Date: Mon, 15 Jul 2024 18:44:26 +0200 [thread overview]
Message-ID: <ZpVR6vR85BiaFtqx@hovoldconsulting.com> (raw)
In-Reply-To: <CAA8EJprKTm-FzDjUFwi9jKaHJ121W2m655-GN3DjzB9rSOpJ=Q@mail.gmail.com>
On Mon, Jul 15, 2024 at 07:40:22PM +0300, Dmitry Baryshkov wrote:
> On Mon, 15 Jul 2024 at 17:44, Johan Hovold <johan@kernel.org> wrote:
> >
> > On Mon, Jul 15, 2024 at 05:23:58PM +0300, Dmitry Baryshkov wrote:
> > > The GPU on X1E80100 requires ZAP 'shader' file to be useful. Since the
> > > file is signed by the OEM keys and might be not available by default,
> > > disable the GPU node and drop the firmware name from the x1e80100.dtsi
> > > file. Devices not being fused to use OEM keys can specify generic
> > > location at `qcom/x1e80100/gen70500_zap.mbn` while enabling the GPU.
> >
> > Please enable the GPU for the CRD as part of this patch (e.g. move the
> > fw name property there).
>
> I can not just move the property, as it is going to have a different
> value. I think GPU enablement for CRD should come as a separate patch.
The GPU is already enabled, this patch is effectively disabling it
unless you move (and update) the corresponding properties to the CRD
dts.
Johan
next prev parent reply other threads:[~2024-07-15 16:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-15 14:23 [PATCH] arm64: dts: qcom: disable GPU on x1e80100 by default Dmitry Baryshkov
2024-07-15 14:27 ` Konrad Dybcio
2024-07-15 14:44 ` Johan Hovold
2024-07-15 16:40 ` Dmitry Baryshkov
2024-07-15 16:44 ` Johan Hovold [this message]
2024-07-15 17:25 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZpVR6vR85BiaFtqx@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_akhilpo@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).