From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF36F17C7D7 for ; Fri, 26 Jul 2024 16:38:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722011894; cv=none; b=jrdFhn40QvYtpixtMjlSJSJwim6PdB2LH4ptKu/+X/NHBjxYc3yqU7LBlltFWwliiosVlhRRNcjo6qMQBt031KEoB7a+uEi3U1cPO1w4cDz/wK4S+avj22I5b/uCg3PKiYT4CMzu8k9Rm35MccC2uTd9Hf4MQaA6Nbv6yNe2xg0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722011894; c=relaxed/simple; bh=EdT0LNcW/fg+/3EqCSqFErM7Ot3ITnnmLAMCTmrP6I0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cnDp4pr2AFPFFmz3hdnrWGOWK8d50nLFAkN0q3ollRvedDDrH9egjORoZ8Ay4IJ1GD7urS030ZzcvXDUc1hVkpy1wQTB8WfB8luGowv6uWfgX4qBkcnsePJWxrw2skYhYL/Owu4X5xL1DEJ+9Hr+JX+M47PMKjeqsDtNKRdULbE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pdp7.com; spf=none smtp.mailfrom=pdp7.com; dkim=pass (2048-bit key) header.d=pdp7-com.20230601.gappssmtp.com header.i=@pdp7-com.20230601.gappssmtp.com header.b=LN2caqVU; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pdp7.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=pdp7.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=pdp7-com.20230601.gappssmtp.com header.i=@pdp7-com.20230601.gappssmtp.com header.b="LN2caqVU" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1fc52394c92so8420335ad.1 for ; Fri, 26 Jul 2024 09:38:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pdp7-com.20230601.gappssmtp.com; s=20230601; t=1722011892; x=1722616692; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=a0HpN9HmDodrUSDORXqRofIB4AnVMlhB5oPbGsDNiZk=; b=LN2caqVU4451DdiX6i4QfOnjg3dGSMeGIxUlre8GSx1JCcC4nx7Emok8jZTfOaJ4qK 6UFzWawjgCm08F9ztkOl4PZrx4/t5wMuTEQesDzydCNA11+4eKisbRuYs502jOBXqt8m tlacK6KfDDt2XfKtQioBFC8vmrOs+OCxrc7DxKZFXagHpsqjJbZLplGwXAE/hZUCnkMo uV5FJbVIO02eYttnCnJISB463vdwopBvACmA7bx0Nlzv8kye7v/8rAzJgAPCHq6g8Sg1 5aJxhQay6pdepFnUs4RA6HfPgmjroRjI8fQYnc9prcJ/DiqBYM28MAc4QqLkHUXHBn04 Rm4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722011892; x=1722616692; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=a0HpN9HmDodrUSDORXqRofIB4AnVMlhB5oPbGsDNiZk=; b=jPIKl9Bl+pX8LTpEz5U8x7n9gq+WBsiXfduSuHVu+GX1X8+zMF73znZevoc7KPYOpv VKn7miq6LG0AxtwkjY2+sJDUdgnUGhJGsFNshjbJToCHrVesl3YsoMI+ExSfuK/bTIRS ieG6dy95r5tKLzrNRlCFFbkXZBcL/KvGg6YiQ6dxAVLDSqKknzYPUUOK0DkEWC7TS9kD rEZHKJSU8yYCZhuVgXzc37ljIvI0u9j+MB5TKAbLOfu9ecDjA0bzJXr7OeAGL+ogxrcG vD4XGN4278Bs0su/f8SESIH3C2YfQXecS14326H8/qewbOg5kw6CXwNLQNWasRsoDrPK sjPw== X-Forwarded-Encrypted: i=1; AJvYcCVZJ/f06KJobYqXuvnHHINutWOT7mUkuQnBVFpB2FyoVmbnjEGOLy6HvAxaEm31czHvdRcygy4KsJAg37tavd7RdKW2GDau/TIrJw== X-Gm-Message-State: AOJu0YxJ7deFCX3vDLhCDOmf0nuvs+UqBvYhs0YqcANEvqiXXdqsUjZl ZwVQaFAq4wyZjASgIqWjcefyCQ3bipio/5EdYQ4SusvtZaH/EwzyhRQIBlFVNzc= X-Google-Smtp-Source: AGHT+IGgSdGMTreHVjBjvhyywbGtPKuHA78vW4E4X9Wxkh8LiuFv+1u6kKBI9jhD+IpTldIfmpl/Bw== X-Received: by 2002:a17:903:234d:b0:1fd:80f0:e859 with SMTP id d9443c01a7336-1ff047e4564mr2287615ad.2.1722011892159; Fri, 26 Jul 2024 09:38:12 -0700 (PDT) Received: from x1 ([2601:1c2:1802:170:dd1c:823c:f5e3:153f]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fed7edd91asm34682265ad.131.2024.07.26.09.38.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jul 2024 09:38:11 -0700 (PDT) Date: Fri, 26 Jul 2024 09:38:09 -0700 From: Drew Fustini To: Emil Renner Berthing Cc: Stephen Boyd , Albert Ou , Conor Dooley , Drew Fustini , Fu Wei , Guo Ren , Jisheng Zhang , Krzysztof Kozlowski , Michael Turquette , Palmer Dabbelt , Paul Walmsley , Rob Herring , Thomas Bonnefille , Yangtao Li , linux-riscv@lists.infradead.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Conor Dooley Subject: Re: [PATCH v2 1/7] dt-bindings: clock: Document T-Head TH1520 AP_SUBSYS controller Message-ID: References: <20240623-th1520-clk-v2-0-ad8d6432d9fb@tenstorrent.com> <20240623-th1520-clk-v2-1-ad8d6432d9fb@tenstorrent.com> <57ef2eef45f2de15e6607da266b37b2a.sboyd@kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Jul 26, 2024 at 03:45:36AM -0500, Emil Renner Berthing wrote: > Stephen Boyd wrote: > > Quoting Drew Fustini (2024-06-23 19:12:31) > > > Document bindings for the T-Head TH1520 AP sub-system clock controller. > > > > > > Link: https://openbeagle.org/beaglev-ahead/beaglev-ahead/-/blob/main/docs/TH1520%20System%20User%20Manual.pdf > > > Co-developed-by: Yangtao Li > > > Signed-off-by: Yangtao Li > > > Reviewed-by: Conor Dooley > > > Signed-off-by: Drew Fustini > > > --- > > > > Applied to clk-next > > Thanks, but this driver seems a bit incomplete. With this applied the Lichee Pi > 4A no longer boots without the clk_ignore_unused kernel parameter. > > /Emil Is this the case when you apply the dts patches from this series? The dts patches won't go in until 6.12 so I don't think the presence of the clk-th1520-ap.c itself in 6.11 would break existing systems. That said, I have been using clk_ignore_unused. I had been thinking that made sense because the full set of clock controller drivers like AON_SUBSYS (always on), AUDIO_SUBSYS, DSP_SUBSYS, etc, are not present yet in mainline. However, the T-Head vendor kernel does have drivers for all those clock controllers and I was suprised to see that the vendor kernel fails to boot when I just tested removing clk_ignore_unused. As for clk-th1520-ap.c in mainline, I'll investigate further which clk disables seem to causing the boot failure when using the dts from this series. I suspect I may need to add nodes that will cause the necessary clks to be enabled by their respective drivers. Thanks, Drew