From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1698B18DF62 for ; Tue, 30 Jul 2024 23:05:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722380707; cv=none; b=U4FOXGfIQKtUbELWafnzQRytjlbcdksZSlhTZ08XsrV7Oztf2W3HQzhnhbvgsnTYnleO5pAEbG9qLcKEhF80mMwohQr07bta2akcUwx6zAcLwbKs2XdiRMQAfNS2Pp6cG+enadjIaTnudAvOaehg2XzP54yseITItK+QaECx/3M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722380707; c=relaxed/simple; bh=G2ZrxaOWGOWO3TvbZHx3gMXdmw/MeENGpCr7Ho3BAxY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=p1GJFiATdZgW9Rk2BlbDElgHjsOdzSh/2aDmOsfH9/NWDRrxB/erNpJdztkkn59crFTiujdWggETY5Wd8Fj71oksFWAgep9+Whhjh1bHBKbRw2ZgpbVAGK1jSO/acBVv5PixqelbFlAj2jG4Xf5nW7VU+hAa7WcxRB9Z8NJ2tZY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pdp7.com; spf=none smtp.mailfrom=pdp7.com; dkim=pass (2048-bit key) header.d=pdp7-com.20230601.gappssmtp.com header.i=@pdp7-com.20230601.gappssmtp.com header.b=pWFyzLcH; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pdp7.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=pdp7.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=pdp7-com.20230601.gappssmtp.com header.i=@pdp7-com.20230601.gappssmtp.com header.b="pWFyzLcH" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-1fc5549788eso38364685ad.1 for ; Tue, 30 Jul 2024 16:05:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pdp7-com.20230601.gappssmtp.com; s=20230601; t=1722380705; x=1722985505; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=nnXntQdX862gVyIztKO/l+KuxZoqT2mA4f4VoFTiDGg=; b=pWFyzLcHS2nrtZK4eveaan30gpXNMwl8vRsfjXVSI8y3vFoXSNUrSLw+pMvmsT8fpe M/NwX6DGjo8G7fkHkJV4csufYvRBq+wxkwwBTh7jkyhxGdB6CPMFjpEnDv9NvwOouW2M HtOZd7+eaSbY17hnaGkJzzCRtoDVwiUAFZzShrfjyJQzQ2Plqe5WGyTsSbHw5jfYU+sD f2YcS1rHqYocgzQIgv7ZONceUfoZpl9rFvX222r+0s6WhX0nSS316U5UXXWVNoFqfGPQ S2NJgNLauRl4yiQMA7MueMaadyZpUPYnmyKRSdrSfkhNmhuWmbwoofXmlflOfVKwbmnY CpcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722380705; x=1722985505; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nnXntQdX862gVyIztKO/l+KuxZoqT2mA4f4VoFTiDGg=; b=W/o+Rdp7qQWecpwTwMMnJsu7V8ah99LmEjC/IfzfP8N33qJIdB9hVXmVjUGuBsFDFG be2p7XupPBr3Wx85XY38yQGNuXPdZ40suxUPGEG6Z6ukFghSSEffE9n2fU5oiHM80SKA //zVTF1HNdx6atNfVu4G68o/gMML2DYz+zgiQGjZ0b9MKONGLKXJ16mC3SE+eWcdeJnS AdzY4+VJXfNbUW8YBIw0ko906Sor9wvF6FevDALuxAUngkRWLTrmTqfdzj/X/ENrUY3e CtBv4ASbGpDFAgfj5LvV1liWdmbC10Avo51t80GS0PdqlCgsWPLlPnMkYK+EFoM2ym9o FVxA== X-Forwarded-Encrypted: i=1; AJvYcCV5j2jTYkWhUcUmyyC6G0T5uKEWekl4UQzShYgQBQ5lwXuDjSvMlm6denWMu+Bn5PyqDngRaz3h2H6+foOe4bgkfjVhlXJlq08Tzw== X-Gm-Message-State: AOJu0YysG1Qatbczb55891UwmF8z4Ytd2OOW+knHYl+n7gRHL6iUJwtC ceYzM9eInXIaWWURjOocC2TSn0bU7A4ih6hFKVi3LvyQIE1zDuZUoZQ6DxtxFSk= X-Google-Smtp-Source: AGHT+IG8Q55ATj4Ez7sYYAJur1LedubizP92VmcH7tRbhAlzb2pARJxM591+mQYc6UeoR1S4yD8eoA== X-Received: by 2002:a17:902:e5cf:b0:1fd:9135:64e with SMTP id d9443c01a7336-1ff048a048emr150282655ad.50.1722380705274; Tue, 30 Jul 2024 16:05:05 -0700 (PDT) Received: from x1 ([2601:1c2:1802:170:4520:8165:b9e7:a203]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fed7f94ba7sm107791025ad.248.2024.07.30.16.05.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jul 2024 16:05:04 -0700 (PDT) Date: Tue, 30 Jul 2024 16:05:02 -0700 From: Drew Fustini To: Icenowy Zheng , Emil Renner Berthing Cc: Stephen Boyd , Albert Ou , Conor Dooley , Drew Fustini , Fu Wei , Guo Ren , Jisheng Zhang , Krzysztof Kozlowski , Michael Turquette , Palmer Dabbelt , Paul Walmsley , Rob Herring , Thomas Bonnefille , Yangtao Li , linux-riscv@lists.infradead.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Conor Dooley Subject: Re: [PATCH v2 1/7] dt-bindings: clock: Document T-Head TH1520 AP_SUBSYS controller Message-ID: References: <20240623-th1520-clk-v2-0-ad8d6432d9fb@tenstorrent.com> <20240623-th1520-clk-v2-1-ad8d6432d9fb@tenstorrent.com> <57ef2eef45f2de15e6607da266b37b2a.sboyd@kernel.org> <2375ff5fb664d8de9627e76788bd40b5d8eabf35.camel@icenowy.me> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2375ff5fb664d8de9627e76788bd40b5d8eabf35.camel@icenowy.me> On Sat, Jul 27, 2024 at 01:21:39PM +0800, Icenowy Zheng wrote: > 在 2024-07-26星期五的 09:38 -0700，Drew Fustini写道： > > On Fri, Jul 26, 2024 at 03:45:36AM -0500, Emil Renner Berthing wrote: > > > Stephen Boyd wrote: > > > > Quoting Drew Fustini (2024-06-23 19:12:31) > > > > > Document bindings for the T-Head TH1520 AP sub-system clock > > > > > controller. > > > > > > > > > > Link: > > > > > https://openbeagle.org/beaglev-ahead/beaglev-ahead/-/blob/main/docs/TH1520%20System%20User%20Manual.pdf > > > > > Co-developed-by: Yangtao Li > > > > > Signed-off-by: Yangtao Li > > > > > Reviewed-by: Conor Dooley > > > > > Signed-off-by: Drew Fustini > > > > > --- > > > > > > > > Applied to clk-next > > > > > > Thanks, but this driver seems a bit incomplete. With this applied > > > the Lichee Pi > > > 4A no longer boots without the clk_ignore_unused kernel parameter. > > > > > > /Emil > > > > Is this the case when you apply the dts patches from this series? > > > > The dts patches won't go in until 6.12 so I don't think the presence > > of > > the clk-th1520-ap.c itself in 6.11 would break existing systems. > > > > That said, I have been using clk_ignore_unused. I had been thinking > > that > > made sense because the full set of clock controller drivers like > > AON_SUBSYS (always on), AUDIO_SUBSYS, DSP_SUBSYS, etc, are not > > present > > yet in mainline. However, the T-Head vendor kernel does have drivers > > for > > all those clock controllers and I was suprised to see that the vendor > > kernel fails to boot when I just tested removing clk_ignore_unused. > > > > As for clk-th1520-ap.c in mainline, I'll investigate further which > > clk > > disables seem to causing the boot failure when using the dts from > > this > > series. I suspect I may need to add nodes that will cause the > > necessary > > clks to be enabled by their respective drivers. > > If disabling the clock just leads to system hang, setting > CLK_IS_CRITICAL should be useful (and needed) here. Thank you for the suggestion about CLK_IS_CRITICAL. I have found through process of elimination that the "emmc-sdio" clock (CLK_EMMC_SDIO) fails to work after the "vp-axi" clock (CLK_VP_AXI) is disabled. I added the CLK_IGNORE_UNUSED flag to "vp-axi" and the system is able to boot correctly. I think in that case CLK_IS_CRITICAL is not needed. I've been reviewing the TH1520 System User Manual [1] and I am uncertain why the state of "vp-axi" would affect "emmc-sdio": - EMMC_SDIO_REF_CLK_EN is bit 30 in PERI_CLK_CFG (offset 0x204). - VPSYS_AXI_ACLK_EN is bit 15 in VPSYS_CLK_CFG (offsset 0x1e0). I don't see any linkage between them in the public documentation. Regardless, the addition of the CLK_IGNORE_UNUSED flag to "vp-axi" fixes the boot failure, so I will post a patch to that effect. Thanks, Drew [1] https://openbeagle.org/beaglev-ahead/beaglev-ahead/-/blob/main/docs/TH1520%20System%20User%20Manual.pdf