Re: [PATCH v4 12/13] dt-bindings: riscv: Add Ziccrse ISA extension description

Conor Dooley
2024-08-02T14:46:50Z

[-- Attachment #1: Type: text/plain, Size: 2189 bytes --]

On Fri, Aug 02, 2024 at 10:14:21AM +0200, Alexandre Ghiti wrote:
> Hi Cono
>
> On 01/08/2024 16:44, Conor Dooley wrote:
> > On Wed, Jul 31, 2024 at 09:24:04AM +0200, Alexandre Ghiti wrote:
> > > Add description for the Ziccrse ISA extension which was introduced in
> > > the riscv profiles specification v0.9.2.
> > >
> > > Signed-off-by: Alexandre Ghiti <alexghiti@rivosinc.com>
> > > Reviewed-by: Guo Ren <guoren@kernel.org>
> > > ---
> > > Documentation/devicetree/bindings/riscv/extensions.yaml | 6 ++++++
> > > 1 file changed, 6 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/riscv/extensions.yaml b/Documentation/devicetree/bindings/riscv/extensions.yaml
> > > index a63578b95c4a..22824dd30175 100644
> > > --- a/Documentation/devicetree/bindings/riscv/extensions.yaml
> > > +++ b/Documentation/devicetree/bindings/riscv/extensions.yaml
> > > @@ -289,6 +289,12 @@ properties:
> > > in commit 64074bc ("Update version numbers for Zfh/Zfinx") of
> > > riscv-isa-manual.
> > > + - const: ziccrse
> > > + description:
> > > + The standard Ziccrse extension which provides forward progress
> > > + guarantee on LR/SC sequences, as introduced in the riscv profiles
> > > + specification v0.9.2.
> > Do we have a commit hash for this? Also v0.9.2? The profiles spec is a
> > crock and the version depends on the specific profile - for example
> > there's new tags as of last week with 0.5 in them... The original profiles
> > are ratified, so if this definition is in there, please cite that
> > instead of a "random" version.
>
>
> That's not a "random" version, please refer to the existing tag v0.9.2 where
> this was first introduced
> (https://github.com/riscv/riscv-profiles/releases/tag/v0.9.2).

That might be your intent, but the versioning in that repo sucks. If
you'd said the v0.9.2 *tag* that would be clearer than what you wrote,
as there could easily be a v0.9.2 of a new profile - there's already a
v0.4 etc.

> But I'll change that to the profiles specification v1.0.

Still vague IMO, please provide a commit hash.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]